Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-07 Thread Raghavendra K T
On 04/02/2014 06:57 PM, Waiman Long wrote: N.B. Sorry for the duplicate. This patch series were resent as the original one was rejected by the vger.kernel.org list server due to long header. There is no change in content. v7-v8: - Remove one unneeded atomic operation from the

Re: [PATCH] arm, kvm: fix double lock on cpu_add_remove_lock

2014-04-07 Thread Srivatsa S. Bhat
On 04/06/2014 11:06 PM, Ming Lei wrote: The patch of arm, kvm: Fix CPU hotplug callback registration in -next tree holds the lock before calling the two functions: kvm_vgic_hyp_init() kvm_timer_hyp_init() and both the two functions are calling register_cpu_notifier() to

Re: [PATCH v2] powernv: kvm: make _PAGE_NUMA take effect

2014-04-07 Thread Aneesh Kumar K.V
Alexander Graf ag...@suse.com writes: On 03.04.14 04:36, Liu ping fan wrote: Hi Alex, could you help to pick up this patch? since v3.14 kernel can enable numa fault for powerpc. What bad happens without this patch? We map a page even though it was declared to get NUMA migrated? What

Re: [PATCH v2] powernv: kvm: make _PAGE_NUMA take effect

2014-04-07 Thread Alexander Graf
On 07.04.14 09:42, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.com writes: On 03.04.14 04:36, Liu ping fan wrote: Hi Alex, could you help to pick up this patch? since v3.14 kernel can enable numa fault for powerpc. What bad happens without this patch? We map a page even though it was

Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation

2014-04-07 Thread Peter Zijlstra
On Fri, Apr 04, 2014 at 01:08:16PM -0400, Waiman Long wrote: Peter's patch is a rewrite of my patches 1-4, there is no PV or unfair lock support in there. Yes, because your patches were unreadable and entirely non obvious. And while I appreciate that its not entirely your fault; the subject is

Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation

2014-04-07 Thread Peter Zijlstra
On Fri, Apr 04, 2014 at 12:57:27PM -0400, Konrad Rzeszutek Wilk wrote: On Fri, Apr 04, 2014 at 03:00:12PM +0200, Peter Zijlstra wrote: So I'm just not ever going to pick up this patch; I spend a week trying to reverse engineer this; I posted a 7 patch series creating the equivalent, but

Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation

2014-04-07 Thread Peter Zijlstra
On Fri, Apr 04, 2014 at 10:59:09AM -0400, Waiman Long wrote: I am really sorry if you have bad feeling about it. I do not mean to discredit you on your effort to make the qspinlock patch better. I really appreciate your input and would like to work with you on this patch as well as other

Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation

2014-04-07 Thread Konrad Rzeszutek Wilk
On Mon, Apr 07, 2014 at 04:12:58PM +0200, Peter Zijlstra wrote: On Fri, Apr 04, 2014 at 12:57:27PM -0400, Konrad Rzeszutek Wilk wrote: On Fri, Apr 04, 2014 at 03:00:12PM +0200, Peter Zijlstra wrote: So I'm just not ever going to pick up this patch; I spend a week trying to reverse

[PATCH] KVM: x86: Fix CR3 and LDT sel should not be saved in TSS

2014-04-07 Thread Nadav Amit
According to Intel specifications, only general purpose registers and segment selectors should are saved in the old TSS during 32-bit task-switch. Signed-off-by: Nadav Amit na...@cs.technion.ac.il --- arch/x86/kvm/emulate.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-07 Thread Waiman Long
On 04/07/2014 02:14 AM, Raghavendra K T wrote: I tested the v7,v8 of qspinlock with unfair config on kvm guest. I was curious about unfair locks performance in undercommit cases. (overcommit case is expected to perform well) But I am seeing hang in overcommit cases. Gdb showed that many

Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation

2014-04-07 Thread Waiman Long
On 04/07/2014 10:09 AM, Peter Zijlstra wrote: On Fri, Apr 04, 2014 at 01:08:16PM -0400, Waiman Long wrote: Peter's patch is a rewrite of my patches 1-4, there is no PV or unfair lock support in there. Yes, because your patches were unreadable and entirely non obvious. And while I appreciate

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-07 Thread Raghavendra K T
On 04/07/2014 10:08 PM, Waiman Long wrote: On 04/07/2014 02:14 AM, Raghavendra K T wrote: [...] But I am seeing hang in overcommit cases. Gdb showed that many vcpus are halted and there was no progress. Suspecting the problem /race with halting, I removed the halt() part of kvm_hibernate(). I

atualização conta de e-mail

2014-04-07 Thread Webmail
Atenção do usuário, Você excedeu o limite de armazenamento para mensagens, é importante que você renovar o seu armazenamento de e-mail para o novo 5.0GB para o uso efetivo das novas funcionalidades do webmail. Para renovar e aumentar o armazenamento, você deve validar o seu webmail. Sem essa

[PATCH 3/3] vfio/iommu_type1: Avoid overflow

2014-04-07 Thread Alex Williamson
Coverity reports use of a tained scalar used as a loop boundary. For the most part, any values passed from userspace for a DMA mapping size, IOVA, or virtual address are valid, with some alignment constraints. The size is ultimately bound by how many pages the user is able to lock, IOVA is tested

[PATCH 0/3] vfio: Fix coverity found issues

2014-04-07 Thread Alex Williamson
Overall nothing very serious here. We botch the size of a PCIe capability due to a cut-n-paste error, but nobody has noticed due to the rarity of the capability. A 32bit host could possibly see some overflows attempting to do a DMA map, but all of the parameters are also validated elsewhere, so

[PATCH 2/3] vfio/pci: Fix unchecked return value

2014-04-07 Thread Alex Williamson
There's nothing we can do different if pci_load_and_free_saved_state() fails, other than maybe print some log message, but the actual re-load of the state is an unnecessary step here since we've only just saved it. We can cleanup a coverity warning and eliminate the unnecessary stop by freeing

[PATCH 1/3] vfio/pci: Fix sizing of DPA and THP express capabilities

2014-04-07 Thread Alex Williamson
When sizing the TPH capability we store the register containing the table size into the 'dword' variable, but then use the uninitialized 'byte' variable to analyze the size. The table size is also actually reported as an N-1 value, so correct sizing to account for this. The round_up() for both

RE: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM

2014-04-07 Thread Wu, Feng
-Original Message- From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of Paolo Bonzini Sent: Friday, April 04, 2014 3:28 PM To: Wu, Feng; g...@redhat.com; h...@zytor.com; kvm@vger.kernel.org Subject: Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM Il

Re: [PATCH v2] powernv: kvm: make _PAGE_NUMA take effect

2014-04-07 Thread Aneesh Kumar K.V
Alexander Graf ag...@suse.com writes: On 03.04.14 04:36, Liu ping fan wrote: Hi Alex, could you help to pick up this patch? since v3.14 kernel can enable numa fault for powerpc. What bad happens without this patch? We map a page even though it was declared to get NUMA migrated? What

Re: [PATCH v2] powernv: kvm: make _PAGE_NUMA take effect

2014-04-07 Thread Alexander Graf
On 07.04.14 09:42, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.com writes: On 03.04.14 04:36, Liu ping fan wrote: Hi Alex, could you help to pick up this patch? since v3.14 kernel can enable numa fault for powerpc. What bad happens without this patch? We map a page even though it was