Re: [arch/x86/kvm/x86.c:5699]: (error) Uninitialized variable: param

2014-04-27 Thread Paolo Bonzini
Il 26/04/2014 19:16, Toralf Förster ha scritto: If CONFIG_X86_64 is not defined then the condition if (!longmode) is either superfluous or lacks an else branch, right ? It is superfluous indeed. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH] MAINTAINERS: co-maintainance of KVM/{arm,arm64}

2014-04-27 Thread Paolo Bonzini
Il 26/04/2014 12:43, Christoffer Dall ha scritto: From: Marc Zyngier marc.zyng...@arm.com The KVM/{arm,arm64} ports are sharing a lot of code, and are effectively co-maintained (and have been for quite a while). Make the situation official and list the two maintainers for both ports. Cc:

[PATCH 2/2] arch/x86/kvm/x86.c: variable longmode ist just used in one place, remove it therefore

2014-04-27 Thread Toralf Förster
Signed-off-by: Toralf Förster toralf.foers...@gmx.de --- arch/x86/kvm/x86.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 93cf454..05166a0 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5665,7 +5665,7 @@ int

[PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition

2014-04-27 Thread Toralf Förster
Signed-off-by: Toralf Förster toralf.foers...@gmx.de --- arch/x86/kvm/x86.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8b8fc0b..93cf454 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@

Re: [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition

2014-04-27 Thread Paolo Bonzini
Il 27/04/2014 12:30, Toralf Förster ha scritto: Signed-off-by: Toralf Förster toralf.foers...@gmx.de --- arch/x86/kvm/x86.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8b8fc0b..93cf454 100644 ---

Re: [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition

2014-04-27 Thread Toralf Förster
On 04/27/2014 12:45 PM, Paolo Bonzini wrote: Il 27/04/2014 12:30, Toralf Förster ha scritto: Signed-off-by: Toralf Förster toralf.foers...@gmx.de --- arch/x86/kvm/x86.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/x86.c

Re: RFC: sharing config interrupt between virtio devices for saving MSI

2014-04-27 Thread Amos Kong
On Sat, Apr 19, 2014 at 12:08:15PM +0800, Amos Kong wrote: Hi all, I'm working on this item in Upstream Networking todolist: | - Sharing config interrupts |Support more devices by sharing a single msi vector |between multiple virtio devices. |(Applies to virtio-blk too).

Re: [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition

2014-04-27 Thread Paolo Bonzini
Il 27/04/2014 13:40, Toralf Förster ha scritto: On 04/27/2014 12:45 PM, Paolo Bonzini wrote: Il 27/04/2014 12:30, Toralf Förster ha scritto: Signed-off-by: Toralf Förster toralf.foers...@gmx.de --- arch/x86/kvm/x86.c | 23 ++- 1 file changed, 10 insertions(+), 13

Re: RFC: sharing config interrupt between virtio devices for saving MSI

2014-04-27 Thread Michael S. Tsirkin
On Sun, Apr 27, 2014 at 10:35:41PM +0800, Amos Kong wrote: On Sat, Apr 19, 2014 at 12:08:15PM +0800, Amos Kong wrote: Hi all, I'm working on this item in Upstream Networking todolist: | - Sharing config interrupts |Support more devices by sharing a single msi vector |

Re: [PATCH] MAINTAINERS: co-maintainance of KVM/{arm,arm64}

2014-04-27 Thread Catalin Marinas
On 26 Apr 2014, at 11:43, Christoffer Dall christoffer.d...@linaro.org wrote: From: Marc Zyngier marc.zyng...@arm.com The KVM/{arm,arm64} ports are sharing a lot of code, and are effectively co-maintained (and have been for quite a while). Make the situation official and list the two

Re: RFC: sharing config interrupt between virtio devices for saving MSI

2014-04-27 Thread Amos Kong
On Sun, Apr 27, 2014 at 06:03:04PM +0300, Michael S. Tsirkin wrote: On Sun, Apr 27, 2014 at 10:35:41PM +0800, Amos Kong wrote: On Sat, Apr 19, 2014 at 12:08:15PM +0800, Amos Kong wrote: Hi all, I'm working on this item in Upstream Networking todolist: | - Sharing config

Re: [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition

2014-04-27 Thread Toralf Förster
On 04/27/2014 04:41 PM, Paolo Bonzini wrote: Il 27/04/2014 13:40, Toralf Förster ha scritto: Ah, so the following would work, but looks too ugly, right ? : #ifdef CONFIG_X86_64 if (!longmode) { #endif param = ((u64)kvm_register_read(vcpu, VCPU_REGS_RDX) 32) |

[PATCH] arch/x86/kvm/x86.c: remove a superfluous test for !X86_64

2014-04-27 Thread Toralf Förster
compile and runtime tested Signed-off-by: Toralf Förster toralf.foers...@gmx.de --- arch/x86/kvm/x86.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8b8fc0b..a6ca7e0 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@

Re: [PATCH] arch/x86/kvm/x86.c: remove a superfluous test for !X86_64

2014-04-27 Thread Paolo Bonzini
Il 27/04/2014 17:32, Toralf Förster ha scritto: diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8b8fc0b..a6ca7e0 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5680,15 +5680,17 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu) kvm_x86_ops-get_cs_db_l_bits(vcpu,

Re: RFC: sharing config interrupt between virtio devices for saving MSI

2014-04-27 Thread Michael S. Tsirkin
On Sun, Apr 27, 2014 at 11:22:14PM +0800, Amos Kong wrote: On Sun, Apr 27, 2014 at 06:03:04PM +0300, Michael S. Tsirkin wrote: On Sun, Apr 27, 2014 at 10:35:41PM +0800, Amos Kong wrote: On Sat, Apr 19, 2014 at 12:08:15PM +0800, Amos Kong wrote: Hi all, I'm working on this

Re: [PATCH] arch/x86/kvm/x86.c: remove a superfluous test for !X86_64

2014-04-27 Thread Toralf Förster
On 04/27/2014 05:40 PM, Paolo Bonzini wrote: Il 27/04/2014 17:32, Toralf Förster ha scritto: diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8b8fc0b..a6ca7e0 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5680,15 +5680,17 @@ int kvm_hv_hypercall(struct kvm_vcpu

Re: [PATCH v9 00/19] qspinlock: a 4-byte queue spinlock with PV support

2014-04-27 Thread Raghavendra K T
On 04/17/2014 08:33 PM, Waiman Long wrote: v8-v9: - Integrate PeterZ's version of the queue spinlock patch with some modification: http://lkml.kernel.org/r/20140310154236.038181...@infradead.org - Break the more complex patches into smaller ones to ease review effort. - Fix a

[PATCH 0/3] Emulate VMXON region correctly

2014-04-27 Thread Bandan Das
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=54521 The vmxon region is unused by nvmx, but adding these checks are probably harmless and may detect buggy L1 hypervisors in the future! Bandan Das (3): KVM: nVMX: rearrange get_vmx_mem_address KVM: nVMX: additional checks on vmxon

[PATCH 3/3] KVM: nVMX: fail on invalid vmclear/vmptrld pointer

2014-04-27 Thread Bandan Das
The spec mandates that if the vmptrld or vmclear address is equal to the vmxon region pointer, the instruction should fail with error VMPTRLD with VMXON pointer or VMCLEAR with VMXON pointer Signed-off-by: Bandan Das b...@redhat.com --- arch/x86/kvm/vmx.c | 12 1 file changed, 12

[PATCH 1/3] KVM: nVMX: rearrange get_vmx_mem_address

2014-04-27 Thread Bandan Das
handle_vmon will call this function to get the vmxon region pointer in the next patch Signed-off-by: Bandan Das b...@redhat.com --- arch/x86/kvm/vmx.c | 106 ++--- 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/arch/x86/kvm/vmx.c

[PATCH 2/3] KVM: nVMX: additional checks on vmxon region

2014-04-27 Thread Bandan Das
Currently, the vmxon region isn't used in the nested case. However, according to the spec, the vmxon instruction performs additional sanity checks on this region and the associated pointer. Modify emulated vmxon to better adhere to the spec requirements Signed-off-by: Bandan Das b...@redhat.com

Does KVM support the P.A. Semi PA6T cpu?

2014-04-27 Thread Christian Zigotzky
Hi All, I have compiled Mac-on-Linux with KVM support on Lubuntu 12.04.4. I have set up an env variable export CFLAGS=-m32 and the binaries are all in 32-bit. But Mac OS X Jaguar doesn't boot. file /usr/local/bin/mol* /usr/local/bin/mol-img: ELF 32-bit MSB executable, PowerPC or cisco

Re: Does KVM support the P.A. Semi PA6T cpu?

2014-04-27 Thread Alexander Graf
On 27.04.14 19:41, Christian Zigotzky wrote: Hi All, I have compiled Mac-on-Linux with KVM support on Lubuntu 12.04.4. I have set up an env variable export CFLAGS=-m32 and the binaries are all in 32-bit. But Mac OS X Jaguar doesn't boot. file /usr/local/bin/mol* /usr/local/bin/mol-img: