[PATCH] kvm_irqchip_assign_irqfd: just set irqfd in case of kvm_irqfds_enabled()

2014-12-26 Thread Tiejun Chen
We should avoid to set irqfd{} unconditionally. Signed-off-by: Tiejun Chen tiejun.c...@intel.com --- kvm-all.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 18cc6b4..5b9786b 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1257,21

Re: [Qemu-devel] [PATCH] kvm_irqchip_assign_irqfd: just set irqfd in case of kvm_irqfds_enabled()

2014-12-26 Thread Peter Maydell
On 26 December 2014 at 08:05, Tiejun Chen tiejun.c...@intel.com wrote: We should avoid to set irqfd{} unconditionally. Signed-off-by: Tiejun Chen tiejun.c...@intel.com Is there a hot path that we use this on such that the difference in code order matters at all? thanks -- PMM -- To

Re: [Qemu-devel] [PATCH] kvm_irqchip_assign_irqfd: just set irqfd in case of kvm_irqfds_enabled()

2014-12-26 Thread Denis V. Lunev
On 26/12/14 13:00, Peter Maydell wrote: On 26 December 2014 at 08:05, Tiejun Chen tiejun.c...@intel.com wrote: We should avoid to set irqfd{} unconditionally. Signed-off-by: Tiejun Chen tiejun.c...@intel.com Is there a hot path that we use this on such that the difference in code order

Re: [Qemu-devel] [PATCH] kvm_irqchip_assign_irqfd: just set irqfd in case of kvm_irqfds_enabled()

2014-12-26 Thread Peter Maydell
On 26 December 2014 at 10:16, Denis V. Lunev den-li...@parallels.com wrote: IMHO the patch does not change anything even on hot-hot path. the declaration 'struct kvm_irqfd irqfd = {};' will result in memset inside. Thus in order to achieve declared goal author should declare struct

[Bug 90381] New: error when loading kvm_intel module

2014-12-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90381 Bug ID: 90381 Summary: error when loading kvm_intel module Product: Virtualization Version: unspecified Kernel Version: 3.18.1 Hardware: All OS: Linux Tree:

[Bug 90381] error when loading kvm_intel module

2014-12-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90381 --- Comment #1 from Bhasker C V bhas...@unixindia.com --- The machine (also can be found in the crash attachment) is Dell D620 with processor features as below: processor: 1 vendor_id: GenuineIntel cpu family: 6 model: 15

[Bug 90381] error when loading kvm_intel module

2014-12-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90381 --- Comment #2 from Bhasker C V bhas...@unixindia.com --- The 3.14.x stock kernel (of debian) works fine but 3.17.x also does the same crash. I do nott have any other kernel revisions inbetween to iterate. -- You are receiving this mail

[Bug 90381] error when loading kvm_intel module kvm_intel unuseable

2014-12-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90381 Bhasker C V bhas...@unixindia.com changed: What|Removed |Added Summary|error when loading |error when loading

[Bug 90381] error when loading kvm_intel module kvm_intel unuseable

2014-12-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90381 --- Comment #3 from Bhasker C V bhas...@unixindia.com --- Managed to load the kvm_intel without a crash. This crash seems to happen _only_ if nested=1 is given in the options. -- You are receiving this mail because: You are watching the assignee