Re: [PATCH 0/5] KVM: nVMX: Enable nested apicv support.

2015-01-19 Thread Wincy Van
Hi, Yang, Could you please have a look at this patch set? Your comment is very appreciated! Thanks, Wincy -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/5] KVM: nVMX: Enable nested apicv support.

2015-01-19 Thread Zhang, Yang Z
Wincy Van wrote on 2015-01-20: Hi, Yang, Could you please have a look at this patch set? Your comment is very appreciated! Sure. I will take a look. Thanks, Wincy Best regards, Yang

Re: [PATCH/RFC 14/21] KVM: s390: clear the pfault queue if user space sets the invalid token

2015-01-19 Thread Christian Borntraeger
Am 17.01.2015 um 11:50 schrieb Heiko Carstens: [...] +/* for KVM_SYNC_PFAULT and KVM_REG_S390_PFTOKEN */ +#define KVM_S390_PFAULT_TOKEN_INVALID 0xUL uapi is for both 64 bit and (theoretically) also 32 bit. So this should be 0xfff...ffULL instead of UL to prevent a

Re: [PATCH/RFC] KVM: fix sparse warning in include/trace/events/kvm.h

2015-01-19 Thread Christian Borntraeger
Adding Alex and Marcelo CC as git blame gives them authorship to that piece of code. Paolo, I assume that you will pick that up without a git tree if Alex/Marcelo ack that change. Christian Am 15.01.2015 um 15:21 schrieb Christian Borntraeger: sparse complains about

Re: [PATCH 5/5] KVM: nVMX: Enable nested posted interrupt processing.

2015-01-19 Thread Paolo Bonzini
On 19/01/2015 13:34, Wincy Van wrote: Actually, there is a race window between vmx_deliver_nested_posted_interrupt and nested_release_vmcs12 since posted intr delivery is async: cpu 1 cpu 2 (nested posted intr) (dest vcpu,

Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu-wq

2015-01-19 Thread Paul Mackerras
On Mon, Jan 19, 2015 at 12:41:00PM -0200, Marcelo Tosatti wrote: On Fri, Jan 16, 2015 at 11:48:46AM -0500, Steven Rostedt wrote: static void kvmppc_vcore_blocked(struct kvmppc_vcore *vc) { - DEFINE_WAIT(wait); + DEFINE_SWAITER(wait); - prepare_to_wait(vc-wq, wait,

Re: [PATCH 5/5] KVM: nVMX: Enable nested posted interrupt processing.

2015-01-19 Thread Wincy Van
On Tue, Jan 20, 2015 at 3:34 PM, Paolo Bonzini pbonz...@redhat.com wrote: Hence, we can disable local interrupts while delivering nested posted interrupts to make sure we are faster than the destination vcpu. This is a bit tricky but it an avoid that race. I think we do not need to add a spin

Re: [PATCH 5/5] KVM: nVMX: Enable nested posted interrupt processing.

2015-01-19 Thread Wincy Van
On Mon, Jan 19, 2015 at 7:43 PM, Paolo Bonzini pbonz...@redhat.com wrote: Hi Wincy, there is only one thing that I don't understand in this patchset, and it is: On 16/01/2015 06:59, Wincy Van wrote: + /* +* if vcpu is in L2, we are fast enough to complete +* before L1

Re: use dedicated I/O service domain in KVM

2015-01-19 Thread Stefan Hajnoczi
On Fri, Jan 16, 2015 at 3:14 PM, Yidao Liu zeroless@gmail.com wrote: 2015-01-16 19:00 GMT+08:00 Stefan Hajnoczi stefa...@gmail.com: On Fri, Jan 16, 2015 at 12:14:17PM +0800, Yidao Liu wrote: Hi, I want to use a dedicated guest VM to handle I/O request just as I/O service domain used in

Re: [PATCH v7 4/4] KVM: arm/arm64: add irqfd support

2015-01-19 Thread Eric Auger
Hi Andre, On 01/16/2015 11:07 AM, André Przywara wrote: Hi Eric, On 01/15/2015 02:47 PM, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This patch enables CONFIG_HAVE_KVM_EVENTFD and

[PATCH kvm] KVM: kvm_read_nested_guest_page() can be static

2015-01-19 Thread kbuild test robot
arch/x86/kvm/x86.c:495:5: sparse: symbol 'kvm_read_nested_guest_page' was not declared. Should it be static? arch/x86/kvm/x86.c:646:5: sparse: symbol '__kvm_set_xcr' was not declared. Should it be static? arch/x86/kvm/x86.c:1183:15: sparse: symbol 'max_tsc_khz' was not declared. Should it be

[kvm:master 1/1] arch/x86/kvm/../../../virt/kvm/kvm_main.c:2062:25: sparse: incorrect type in assignment (different address spaces)

2015-01-19 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/virt/kvm/kvm.git master head: cdef511985374dd042a40bb32c1c346c2662c9dc commit: cdef511985374dd042a40bb32c1c346c2662c9dc [1/1] KVM: fix sparse warning in include/trace/events/kvm.h reproduce: # apt-get install sparse git checkout

Re: [PATCH v7 4/4] KVM: arm/arm64: add irqfd support

2015-01-19 Thread Eric Auger
On 01/19/2015 04:01 PM, Eric Auger wrote: Hi Andre, On 01/16/2015 11:07 AM, André Przywara wrote: Hi Eric, On 01/15/2015 02:47 PM, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This

Re: [PATCH 1/1] arch/x86/kvm/vmx.c: Fix external interrupts inject directly bug with guestos RFLAGS.IF=0

2015-01-19 Thread Paolo Bonzini
On 15/01/2015 13:36, Li Kaihang wrote: This patch fix a external interrupt injecting bug in linux 3.19-rc4. GuestOS is running and handling some interrupt with RFLAGS.IF = 0 while a external interrupt coming, then can lead to a vm exit,in this case,we must avoid inject this external

Re: [PATCH/RFC] KVM: fix sparse warning in include/trace/events/kvm.h

2015-01-19 Thread Marcelo Tosatti
On Mon, Jan 19, 2015 at 09:54:53AM +0100, Christian Borntraeger wrote: Adding Alex and Marcelo CC as git blame gives them authorship to that piece of code. Paolo, I assume that you will pick that up without a git tree if Alex/Marcelo ack that change. Christian Looks good to me.

KVM call for agenda for 2015-01-20

2015-01-19 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ (Let me know if you have

Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu-wq

2015-01-19 Thread Marcelo Tosatti
On Fri, Jan 16, 2015 at 11:48:46AM -0500, Steven Rostedt wrote: @@ -971,8 +971,8 @@ kvm_mips_callbacks-queue_timer_int(vcpu); vcpu-arch.wait = 0; - if (waitqueue_active(vcpu-wq)) { - wake_up_interruptible(vcpu-wq); + if (swaitqueue_active(vcpu-wq)) { +

Re: [PATCH/RFC] KVM: fix sparse warning in include/trace/events/kvm.h

2015-01-19 Thread Paolo Bonzini
On 15/01/2015 15:21, Christian Borntraeger wrote: sparse complains about include/trace/events/kvm.h:163:1: error: directive in argument list include/trace/events/kvm.h:167:1: error: directive in argument list include/trace/events/kvm.h:169:1: error: directive in argument list and sparse is

Re: [PATCH 5/5] KVM: nVMX: Enable nested posted interrupt processing.

2015-01-19 Thread Paolo Bonzini
Hi Wincy, there is only one thing that I don't understand in this patchset, and it is: On 16/01/2015 06:59, Wincy Van wrote: + /* +* if vcpu is in L2, we are fast enough to complete +* before L1 changes/destroys vmcs12. +*/ ... this comment. What do you mean

[PATCH v8 1/5] KVM: arm/arm64: unset CONFIG_HAVE_KVM_IRQCHIP

2015-01-19 Thread Eric Auger
CONFIG_HAVE_KVM_IRQCHIP is needed to support IRQ routing (along with irq_comm.c and irqchip.c usage). This is not the case for arm/arm64 currently. This patch unsets the flag for both arm and arm64. Signed-off-by: Eric Auger eric.au...@linaro.org Reviewed-by: Andre Przywara

[PATCH v8 5/5] KVM: arm/arm64: add irqfd support

2015-01-19 Thread Eric Auger
This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This patch enables CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQFD. KVM_CAP_IRQFD is now advertised. KVM_CAP_IRQFD_RESAMPLE capability automatically is

[PATCH v8 0/5] irqfd support for arm/arm64

2015-01-19 Thread Eric Auger
This patch series enables irqfd on arm and arm64. Irqfd framework enables to inject a virtual IRQ into a guest upon an eventfd trigger. User-side uses KVM_IRQFD VM ioctl to provide KVM with a kvm_irqfd struct that associates a VM, an eventfd, a virtual IRQ number (aka. the gsi). When an actor

Payment

2015-01-19 Thread Finance Department
Dear Recipient, You have been awarded the sum of 8,000,000.00 (Eight Million Pounds sterling) with reference number 77100146 by office of the ministry of finance UK.Send us your personal details to deliver your funds. Gloria Peter -- To unsubscribe from this list: send the line unsubscribe

[PATCH v8 2/5] KVM: introduce kvm_arch_intc_initialized and use it in irqfd

2015-01-19 Thread Eric Auger
Introduce __KVM_HAVE_ARCH_INTC_INITIALIZED define and associated kvm_arch_intc_initialized function. This latter allows to test whether the virtual interrupt controller is initialized and ready to accept virtual IRQ injection. On some architectures, the virtual interrupt controller is dynamically

[PATCH v8 3/5] KVM: arm/arm64: implement kvm_arch_intc_initialized

2015-01-19 Thread Eric Auger
On arm/arm64 the VGIC is dynamically instantiated and it is useful to expose its state, especially for irqfd setup. This patch defines __KVM_HAVE_ARCH_INTC_INITIALIZED and implements kvm_arch_intc_initialized. Signed-off-by: Eric Auger eric.au...@linaro.org Acked-by: Christoffer Dall

[PATCH v8 4/5] KVM: arm/arm64: remove coarse grain dist locking at kvm_vgic_sync_hwstate

2015-01-19 Thread Eric Auger
To prepare for irqfd addition, coarse grain locking is removed at kvm_vgic_sync_hwstate level and finer grain locking is introduced in vgic_process_maintenance only. Signed-off-by: Eric Auger eric.au...@linaro.org --- virt/kvm/arm/vgic.c | 13 + 1 file changed, 5 insertions(+), 8

Re: [kvm:master 1/1] arch/x86/kvm/../../../virt/kvm/kvm_main.c:2062:25: sparse: incorrect type in assignment (different address spaces)

2015-01-19 Thread Christian Borntraeger
Am 19.01.2015 um 15:33 schrieb kbuild test robot: tree: git://git.kernel.org/pub/scm/virt/kvm/kvm.git master head: cdef511985374dd042a40bb32c1c346c2662c9dc commit: cdef511985374dd042a40bb32c1c346c2662c9dc [1/1] KVM: fix sparse warning in include/trace/events/kvm.h reproduce: # apt-get