[PATCH 1/1] target-i386: get/put MSR_TSC_AUX across reset and migration

2015-09-23 Thread Amit Shah
There's one report of migration breaking due to missing MSR_TSC_AUX save/restore. Fix this by adding a new subsection that saves the state of this MSR. https://bugzilla.redhat.com/show_bug.cgi?id=1261797 Reported-by: Xiaoqing Wei <x...@redhat.com> Signed-off-by: Amit Shah <amit.s...@r

Re: [PATCH v3] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-15 Thread Amit Shah
On (Tue) 15 Sep 2015 [14:26:06], David Gibson wrote: > On Mon, Sep 14, 2015 at 08:32:36AM +0200, Thomas Huth wrote: > > On 14/09/15 04:15, David Gibson wrote: > > > On Fri, Sep 11, 2015 at 11:17:01AM +0200, Thomas Huth wrote: > > >> The PAPR interface defines a hypercall to pass high-quality > >

Re: [BUG] Balloon malfunctions with memory hotplug

2015-03-01 Thread Amit Shah
On (Fri) 27 Feb 2015 [12:09:20], zhanghailiang wrote: On 2015/2/27 3:26, Luiz Capitulino wrote: Hello, Reproducer: 1. Start QEMU with balloon and memory hotplug support: # qemu [...] -m 1G,slots=2,maxmem=2G -balloon virtio 2. Check balloon size: (qemu) info balloon balloon:

Re: [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore

2014-10-07 Thread Amit Shah
: Amit Shah amit.s...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com I didn't see my previous questions answered from the initial posting -- can you please respond to them? Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore

2014-10-07 Thread Amit Shah
On (Tue) 07 Oct 2014 [15:53:55], Michael S. Tsirkin wrote: On Mon, Oct 06, 2014 at 06:10:40PM +0300, Michael S. Tsirkin wrote: On restore, virtio pci does the following: + set features + init vqs etc - device can be used at this point! + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits

Re: [PATCH 1/2] virtio-rng cleanup: move some code out of mutex protection

2014-09-11 Thread Amit Shah
On (Wed) 10 Sep 2014 [17:07:06], Amos Kong wrote: It doesn't save too much cpu time as expected, just a cleanup. Frankly I won't bother with this. It doesn't completely remove all copying from the mutex, so it's not worthwhile. Signed-off-by: Amos Kong ak...@redhat.com ---

Re: [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes

2014-09-11 Thread Amit Shah
for this one: one to remove the need_resched() check, and the other to increase the timeout. Anyway, Reviewed-by: Amit Shah amit.s...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- drivers/char/hw_random/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

Re: [Qemu-devel] [question] virtio-blk performance degradationhappenedwith virito-serial

2014-09-11 Thread Amit Shah
On (Sun) 07 Sep 2014 [17:46:26], Zhang Haoyu wrote: Hi, Paolo, Amit, any ideas? I'll check this, thanks for testing with Linux guests. Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3 1/2] virtio-rng: fix stuck of hot-unplugging busy device

2014-09-10 Thread Amit Shah
unregistering, resets data_avail to avoid the hwrng core use wrong buffer bytes. Signed-off-by: Amos Kong ak...@redhat.com Cc: sta...@vger.kernel.org Reviewed-by: Amit Shah amit.s...@redhat.com Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH v3 2/2] virtio-rng: skip reading when we start to remove the device

2014-09-10 Thread Amit Shah
Reviewed-by: Amit Shah amit.s...@redhat.com Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] virtio-rng: fix stuck of hot-unplugging busy device

2014-09-09 Thread Amit Shah
Hi Amos, On (Tue) 09 Sep 2014 [19:14:02], Amos Kong wrote: When we try to hot-remove a busy virtio-rng device from QEMU monitor, the device can't be hot-removed. Because virtio-rng driver hangs at wait_for_completion_killable(). This patch exits the waiting by completing have_data

Re: RFC virtio-rng: fail to read sysfs of a busy device

2014-09-09 Thread Amit Shah
On (Tue) 09 Sep 2014 [23:23:07], Amos Kong wrote: (Resend to fix the subject) Hi Amit, Rusty RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1127062 steps: - Read random data by 'dd if=/dev/hwrng of=/dev/null' in guest - check sysfs files in the same time, 'cat

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-02 Thread Amit Shah
On (Mon) 01 Sep 2014 [20:52:46], Zhang Haoyu wrote: Hi, all I start a VM with virtio-serial (default ports number: 31), and found that virtio-blk performance degradation happened, about 25%, this problem can be reproduced 100%. without virtio-serial: 4k-read-random 1186 IOPS

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-02 Thread Amit Shah
On (Tue) 02 Sep 2014 [22:05:45], Andrey Korolyov wrote: Can confirm serious degradation comparing to the 1.1 with regular serial output - I am able to hang VM forever after some tens of seconds after continuously printing dmest to the ttyS0. VM just ate all available CPU quota during test

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-01 Thread Amit Shah
On (Mon) 01 Sep 2014 [20:38:20], Zhang Haoyu wrote: Hi, all I start a VM with virtio-serial (default ports number: 31), and found that virtio-blk performance degradation happened, about 25%, this problem can be reproduced 100%. without virtio-serial: 4k-read-random 1186 IOPS

Re: [Qemu-devel] [question] virtio-blk performance degradation happened with virito-serial

2014-08-29 Thread Amit Shah
On (Fri) 29 Aug 2014 [15:45:30], Zhang Haoyu wrote: Hi, all I start a VM with virtio-serial (default ports number: 31), and found that virtio-blk performance degradation happened, about 25%, this problem can be reproduced 100%. without virtio-serial: 4k-read-random 1186 IOPS with

[PATCH v3 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-14 Thread Amit Shah
to cause all sorts of badness, and a compromised hwrng is the least of the user's worries. Given this, we might as well assume that the quality of randomness we receive is perfectly trustworthy. Hence, we use 100% for the factor, indicating maximum confidence in the source. Signed-off-by: Amit Shah

[PULL] virtio-rng: add derating factor for use by hwrng core

2014-08-14 Thread Amit Shah
derating factor for use by hwrng core (2014-08-15 10:26:01 +0530) Amit Shah (1): virtio: rng: add derating factor for use by hwrng core drivers/char/hw_random/virtio-rng.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.3

[PATCH v2 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-12 Thread Amit Shah
of badness, and a compromised hwrng is not the biggest threat. Given this, we are certain the quality of randomness we receive is perfectly trustworthy. Hence, we use 100% for the factor, indicating maximum confidence in the source. Signed-off-by: Amit Shah amit.s...@redhat.com --- Pretty small

[PATCH 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-11 Thread Amit Shah
receive is perfectly trustworthy. Hence, we use 100% for the factor, indicating maximum confidence in the source. Signed-off-by: Amit Shah amit.s...@redhat.com --- Pretty small and contained patch; would be great if it is picked up for 3.17. --- drivers/char/hw_random/virtio-rng.c | 1 + 1 file

Re: [PATCH 1/1] virtio: rng: add derating factor for use by hwrng core

2014-08-11 Thread Amit Shah
On (Mon) 11 Aug 2014 [15:11:03], H. Peter Anvin wrote: On 08/11/2014 11:49 AM, Amit Shah wrote: The khwrngd thread is started when a hwrng device of sufficient quality is registered. The virtio-rng device is backed by the hypervisor, and we trust the hypervisor to provide real entropy

Re: [PATCH] virtio-rng: complete have_data completion in removing device

2014-08-06 Thread Amit Shah
On (Wed) 06 Aug 2014 [16:05:41], Amos Kong wrote: On Wed, Aug 06, 2014 at 01:35:15AM +0800, Amos Kong wrote: When we try to hot-remove a busy virtio-rng device from QEMU monitor, the device can't be hot-removed. Because virtio-rng driver hangs at wait_for_completion_killable(). This

Re: When I boot two virtio-rng devices, guest will hang

2014-07-28 Thread Amit Shah
: ec1aa555b67628beefa0ac6902baa2cc2e156f58.1406533638.git.amit.s...@redhat.com From: Amit Shah amit.s...@redhat.com Date: Mon, 21 Jul 2014 14:46:28 +0530 Subject: [PATCH 1/1] virtio-rng: add some trace events Add some trace events to virtio-rng for easier debugging Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio/virtio-rng.c

Re: When I boot two virtio-rng devices, guest will hang

2014-07-28 Thread Amit Shah
On (Mon) 28 Jul 2014 [16:49:20], Amos Kong wrote: On Mon, Jul 28, 2014 at 01:25:14PM +0530, Amit Shah wrote: On (Mon) 28 Jul 2014 [15:32:42], Amos Kong wrote: QEMU commandline: ./x86_64-softmmu/qemu-system-x86_64 --enable-kvm -m 2000 -drive file=/images/nolvm.qcow2 --kernel

Re: [PATCH 0/2] virtio-serial: set up vqs on demand

2013-04-08 Thread Amit Shah
On (Thu) 12 Jan 2012 [09:20:05], zanghongy...@huawei.com wrote: From: Hongyong Zang zanghongy...@huawei.com Virtio-serial set up (max_ports+1)*2 vqs when device probes, but may not all io_ports are used. These patches create vqs of port0 and control port when probing the device, then

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-10-08 Thread Amit Shah
On (Sun) 30 Sep 2012 [20:05:16], Marcelo Tosatti wrote: On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop notification, but it did it in a way

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-10-08 Thread Amit Shah
On (Sun) 30 Sep 2012 [21:50:07], Amos Kong wrote: - Original Message - On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop

[PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Amit Shah
: Paolo Bonzini pbonz...@redhat.com CC: Laszlo Ersek ler...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/kvm/clock.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/kvm/clock.c b/hw/kvm/clock.c index 824b978..f3427eb 100644 --- a/hw

Re: KVM: x86: fix pvclock guest stopped flag reporting (v2)

2012-08-07 Thread Amit Shah
-by: Amit Shah amit.s...@redhat.com Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-25 Thread Amit Shah
On (Wed) 25 Jul 2012 [10:06:37], Rusty Russell wrote: On Tue, 24 Jul 2012 15:01:59 +0200, Sasha Levin levinsasha...@gmail.com wrote: virtio on it's own was introduced to help solve the fragmentation around virtualized devices, so I don't think that the main purpose of doing virtio drivers

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-06-27 Thread Amit Shah
On (Tue) 26 Jun 2012 [13:32:58], Frank Swiderski wrote: This implementation of a virtio balloon driver uses the page cache to store pages that have been released to the host. The communication (outside of target counts) is one way--the guest notifies the host when it adds a page to the page

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-03 Thread Amit Shah
On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: disable_cb is just an optimization: it can not guarantee that there are no callbacks. Even then, what's the harm in keeping it? If indeed there's an attempt to raise an interrupt after the host has been notified, it will be suppressed.

Call for Proposals: Linux Plumbers Conference (Aug 2012)

2012-04-19 Thread Amit Shah
Hello, The Call for Proposals for the Linux Plumbers Conf 2012 is out. We're looking for speakers to talk at the Virtualization microconference as well as the main conference. The deadline for proposal submissions is 1st May. This year's edition of LPC is co-located with LinuxCon NA and will

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-04-02 Thread Amit Shah
On (Mon) 02 Apr 2012 [18:05:45], Wen Congyang wrote: At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is:

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: At 03/14/2012 05:51 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:52:07], Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13

Re: [KVM paravirt issue?] Re: vsyscall=emulate regression

2012-02-28 Thread Amit Shah
On (Tue) 28 Feb 2012 [12:00:34], Avi Kivity wrote: On 02/24/2012 08:58 PM, Andy Lutomirski wrote: On Thu, Feb 23, 2012 at 8:34 PM, H. Peter Anvin h...@zytor.com wrote: On 02/16/2012 09:39 AM, Avi Kivity wrote: Yes, this is on purpose Why? I think the this refers to the

Re: vsyscall=emulate regression

2012-02-15 Thread Amit Shah
On (Tue) 14 Feb 2012 [08:26:22], Andy Lutomirski wrote: On Tue, Feb 14, 2012 at 4:22 AM, Amit Shah amit.s...@redhat.com wrote: On (Fri) 03 Feb 2012 [13:57:48], Amit Shah wrote: Hello, I'm booting some latest kernels on a Fedora 11 (released June 2009) guest.  After the recent change

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-13 Thread Amit Shah
On (Fri) 10 Feb 2012 [21:58:47], Igor Mammedov wrote: BTW Amit, your config doesn't have CONFIG_KVM_GUEST set, which causes primary cpu clock to be uninitialized too in case of SMP kernel. Interesting. I didn't notice that. However, if I enable that option, resume fails for me even the

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-13 Thread Amit Shah
On (Fri) 10 Feb 2012 [13:43:05], Igor Mammedov wrote: Another thing is to try smp guest without kvmclock and see if it helps. It might be just something else. Nope, it's related to kvmclock. Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-13 Thread Amit Shah
On (Fri) 10 Feb 2012 [10:33:37], Marcelo Tosatti wrote: On Fri, Feb 10, 2012 at 10:32:16AM -0200, Marcelo Tosatti wrote: On Fri, Feb 10, 2012 at 03:32:11PM +0530, Amit Shah wrote: On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote: Stalls are probably caused by uninitialized percpu

Re: x86: kvmclock: abstract save/restore sched_clock_state (v2)

2012-02-13 Thread Amit Shah
it down. Fixes suspend-to-disk with kvmclock. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com This works fine, thanks. Tested-by: Amit Shah amit.s...@redhat.com Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-10 Thread Amit Shah
On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote: Stalls are probably caused by uninitialized percpu hv_clock, with following patch I don't see stalls. Although I might be just lucky. http://git.kernel.org/?p=virt/kvm/kvm.git;a=commit;h=e2971ac7e1d186af059e088d305496c5cb47d487 Your commit

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-10 Thread Amit Shah
On (Fri) 10 Feb 2012 [05:11:00], Igor Mammedov wrote: Could you send me your .config and commit id of kernel you are using? Kernel's based on bd3ce7d57c380af110c86d19e256115d0e7053ca plus your commit + Marcelo's patch. config is attached below. # # Automatically generated file; DO NOT EDIT. #

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-10 Thread Amit Shah
On (Fri) 10 Feb 2012 [10:32:16], Marcelo Tosatti wrote: On Fri, Feb 10, 2012 at 03:32:11PM +0530, Amit Shah wrote: On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote: Stalls are probably caused by uninitialized percpu hv_clock, with following patch I don't see stalls. Although I

Re: x86: kvmclock: abstract save/restore sched_clock_state

2012-02-09 Thread Amit Shah
On (Tue) 07 Feb 2012 [19:05:42], Marcelo Tosatti wrote: Upon resume from hibernation, CPU 0's hvclock area contains the old values for system_time and tsc_timestamp. It is necessary for the hypervisor to update these values with uptodate ones before the CPU uses them. Abstract TSC's

Re: [PATCH 2/2] virtio-serial: setup_port_vq when adding port

2012-02-01 Thread Amit Shah
Hi, Sorry for the late reply. On (Thu) 12 Jan 2012 [09:20:07], zanghongy...@huawei.com wrote: From: Hongyong Zang zanghongy...@huawei.com Add setup_port_vq(). Create the io ports' vqs when add_port. Can you describe the changes in more detail, please? Signed-off-by: Hongyong Zang

Re: [PATCH 1/2] virtio-pci: add setup_vqs flag in vp_try_to_find_vqs

2012-02-01 Thread Amit Shah
Michael, Rusty, any comments? On (Thu) 12 Jan 2012 [09:20:06], zanghongy...@huawei.com wrote: From: Hongyong Zang zanghongy...@huawei.com changes in vp_try_to_find_vqs: Virtio-serial's probe() calls it to request irqs and setup vqs of port0 and controls; add_port() calls it to set up vqs of

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-19 Thread Amit Shah
On (Thu) 15 Dec 2011 [13:55:15], Avi Kivity wrote: On 12/08/2011 01:34 PM, Amit Shah wrote: On (Mon) 05 Dec 2011 [15:18:59], Eric B Munson wrote: When a guest kernel is stopped by the host hypervisor it can look like a soft lockup to the guest kernel. This false warning can mask

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-19 Thread Amit Shah
On (Mon) 19 Dec 2011 [14:59:36], Avi Kivity wrote: On 12/19/2011 02:52 PM, Amit Shah wrote: (snip) S4 needs some treatment, though, as resume after s4 doesn't work with kvmclock enabled. I didn't realise this series was only handling the soft lockup case. What's the issue

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-18 Thread Amit Shah
On (Mon) 19 Dec 2011 [14:09:43], Zang Hongyong wrote: 于 2011/12/16,星期五 17:39, Amit Shah 写道: On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: From: Hongyong Zangzanghongy...@huawei.com In pci_enable_msix(), the guest's virtio-serial driver tries to set msi-x with one vector

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-16 Thread Amit Shah
On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: From: Hongyong Zang zanghongy...@huawei.com In pci_enable_msix(), the guest's virtio-serial driver tries to set msi-x with one vector per queue. But it fails and eventually all virtio-serial ports share one MSI-X vector. Because

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-08 Thread Amit Shah
On (Mon) 05 Dec 2011 [15:18:59], Eric B Munson wrote: When a guest kernel is stopped by the host hypervisor it can look like a soft lockup to the guest kernel. This false warning can mask later soft lockup warnings which may be real. This patch series adds a method for a host hypervisor to

Re: [PATCH 0/1] virtio: console: fix for early console

2011-10-31 Thread Amit Shah
On (Thu) 22 Sep 2011 [23:44:22], Amit Shah wrote: Hi Rusty, This is a fix from Christian for early console handling with multiport support. Please apply. Christian, I've made some changes to the patch as noted in the commit message. Nothing major, but an ACK would be nice. Thanks

Re: [RFC/PATCH] virtio-console: wait for console ports

2011-09-22 Thread Amit Shah
Hi Christian, On (Wed) 21 Sep 2011 [17:52:23], Christian Borntraeger wrote: Amit, can you have a look at the patch below and give feedback or apply if appropriate? The patch looks good. Just a couple of comments: On s390 I have seen some random Warning: unable to open an initial console

Re: [RFC/PATCH] virtio-console: wait for console ports

2011-09-22 Thread Amit Shah
On (Thu) 22 Sep 2011 [13:20:07], Christian Borntraeger wrote: On 22/09/11 12:08, Amit Shah wrote: + /* If there was an early virtio console, assume that there are no + * other consoles. We need to wait until the hvc_alloc matches the + * hvc_instantiate, otherwise tty_open

[PATCH 0/1] virtio: console: fix for early console

2011-09-22 Thread Amit Shah
Hi Rusty, This is a fix from Christian for early console handling with multiport support. Please apply. Christian, I've made some changes to the patch as noted in the commit message. Nothing major, but an ACK would be nice. Thanks. Christian Borntraeger (1): virtio: console: wait for

[PATCH 1/1] virtio: console: wait for first console port for early console output

2011-09-22 Thread Amit Shah
* Rename 'port_added' to 'early_console_added' * Re-format, re-word commit message * Rebase patch on top of current queue] Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- drivers/char/virtio_console.c | 20 1

[PATCH] kvm: balloon: test multiple devices

2011-08-08 Thread Amit Shah
Multiple balloon devices should not be allowed. Check if the qemu we're running under has the right fixes. Signed-off-by: Amit Shah amit.s...@redhat.com --- client/tests/kvm/tests/balloon_check.py | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/client

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Amit Shah
On (Wed) 16 Feb 2011 [08:41:27], Anthony Liguori wrote: On 02/16/2011 08:39 AM, Amit Shah wrote: On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote: On 02/15/2011 10:26 AM, Chris Wright wrote: revisit new - old migration - Amit offers virtio-serial patches and some legwork So, to me

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-16 Thread Amit Shah
On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote: On 02/15/2011 10:26 AM, Chris Wright wrote: revisit new - old migration - Amit offers virtio-serial patches and some legwork So, to me, migration correctness trumps compatibility. I don't think compatibility is useful if it means

Re: [PATCH 1/2] KVM test: virtio subtest: Add subtest layer v2

2010-11-25 Thread Amit Shah
Hi Lucas, Jiri, Lukas, On (Thu) Nov 25 2010 [17:28:57], Lucas Meneghel Rodrigues wrote: From: Jiri Zupka jzu...@redhat.com This patch changes structure of the virtio_console test and prepares this test for simpler porting of another required tests. It creates a new layer for running the

Re: [PATCH 1/1] virtio_console: perf-test fix [FIX] read-out all data after perf-test [FIX] code clean-up

2010-09-28 Thread Amit Shah
On (Thu) Sep 23 2010 [14:11:52], Lukas Doktor wrote: @@ -829,6 +832,11 @@ def run_virtio_console(test, params, env): exit_event.set() thread.join() +# Let the guest read-out all the remaining data +while not _on_guest(virt.poll('%s', %s) +

Re: [KVM-autotest] virtio_console test v3.0

2010-09-17 Thread Amit Shah
On (Wed) Sep 15 2010 [17:41:28], Lukas Doktor wrote: New version of virtio_console test is more similar to upstream C virtio_console test so it will be easier to maintain. Also we moved the scripts/console_switch.py to more sensible scripts/virtio_guest.py There are still some

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-16 Thread Amit Shah
On (Thu) Sep 16 2010 [15:32:54], Rusty Russell wrote: On Wed, 15 Sep 2010 11:16:24 pm Amit Shah wrote: On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote: --- linux-2.6.35.x86_64/drivers/char/virtio_console.c~ 2010-08-02 00:11:14.0 +0200 +++ linux-2.6.35.x86_64/drivers/char

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Amit Shah
On (Wed) Sep 15 2010 [15:04:53], Hans de Goede wrote: Hi All, I found this while working on a Linux agent for spice, the symptom I was seeing was select blocking on the spice vdagent virtio serial port even though there were messages queued up there. I found this while working on a Linux

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Amit Shah
On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote: --- linux-2.6.35.x86_64/drivers/char/virtio_console.c~ 2010-08-02 00:11:14.0 +0200 +++ linux-2.6.35.x86_64/drivers/char/virtio_console.c 2010-09-15 13:39:29.043505000 +0200 @@ -642,7 +642,7 @@ static unsigned int

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read (version 2)

2010-09-15 Thread Amit Shah
On (Wed) Sep 15 2010 [17:18:23], Hans de Goede wrote: diff -up linux-2.6.35.x86_64/drivers/char/virtio_console.c~ linux-2.6.35.x86_64/drivers/char/virtio_console.c --- linux-2.6.35.x86_64/drivers/char/virtio_console.c~2010-08-02 00:11:14.0 +0200 +++

Re: [KVM-autotest] virtio_console test

2010-08-23 Thread Amit Shah
On (Fri) Aug 20 2010 [16:12:51], Lukáš Doktor wrote: Dne 20.8.2010 15:40, Lukas Doktor napsal(a): Hi, This patch adds new test for virtio_console. It supports booth, serialport and console, virtio_console types and it contains three tests: 1) smoke 2) loopback 3) perf This is great,

Re: [KVM-autotest] virtio_console test

2010-08-23 Thread Amit Shah
On (Mon) Aug 23 2010 [15:20:17], Lukáš Doktor wrote: Hi Amit, Dne 23.8.2010 09:53, Amit Shah napsal(a): On (Fri) Aug 20 2010 [16:12:51], Lukáš Doktor wrote: Dne 20.8.2010 15:40, Lukas Doktor napsal(a): Hi, This patch adds new test for virtio_console. It supports booth, serialport

Re: kvm IPC

2010-08-04 Thread Amit Shah
On (Tue) Aug 03 2010 [11:37:38], Nirmal Guhan wrote: Thanks. Will this work if the guest or host are different combo Yes, it would. Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: kvm IPC

2010-08-03 Thread Amit Shah
On (Thu) Jul 29 2010 [16:17:48], Nirmal Guhan wrote: Hi, I run Fedora 12 and guest is also Fedora 12. I use br0/tap0 for networking and communicate between host-guest using socket. I do see some references to virtio, pci based ipc and inter-vm shared memory but they are not current. My

Re: [PATCH] vhost-net: fix reversed logic in mask notifiers

2010-05-25 Thread Amit Shah
it to mask the vector. This, unless vector is already masked which unassigns irqfd already. The logic in unassign was reversed, which left kvm irqfd assigned. This patch is qemu-kvm only as irqfd is not upstream. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reported-by: Amit Shah amit.s

Re: Question on copy paste

2010-04-15 Thread Amit Shah
On (Thu) Apr 15 2010 [08:45:23], Stephen Liu wrote: Hi folks, host - Debian 5.04 What will the easy way to enable copy_and_paste function between guest and hosts? Also among guests. TIA This doesn't exist yet, but something should be available in a few months. Amit --

Re: hi, may I ask some help on the paravirtualization of KVM?

2010-03-23 Thread Amit Shah
On (Sun) Mar 21 2010 [20:18:53], Liang YANG wrote: I want to set up the virtio-net for the GuestOS on KVM. Following is my steps: 1.Compile the kvm-88 and make, make install. 2.Compile the GuestOS(redhat) with kernel version 2.6.27.45(with virtio support). The required option are all

Re: [patch 2/2] virtio-serial-bus: wake up iothread upon guest read notification

2010-03-11 Thread Amit Shah
On (Thu) Mar 11 2010 [23:45:51], Marcelo Tosatti wrote: Wake up iothread when buffers are consumed. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-ioworker/hw/virtio-serial-bus.c === ---

Slowdowns comparing qemu-kvm.git to qemu.git: vcpu/thread scheduling differences

2010-02-08 Thread Amit Shah
Hello, In my testing of virtio-console, I found qemu-kvm.git introduces a lot of overhead in thread scheduling compared to qemu.git. My test sends a 260M file from the host to a guest via a virtio-console port and then computes the sha1sum of the file on the host as well as on the guest,

Re: [PATCH 1/2] virtio: Add detach unused buffer from vring

2009-12-24 Thread Amit Shah
will be the first user. Signed-off-by: Shirley Ma x...@us.ibm.com Acked-By: Amit Shah amit.s...@redhat.com Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path

2009-12-24 Thread Amit Shah
On (Thu) Dec 17 2009 [23:44:49], Shirley Ma wrote: virtio_net receives packets from its pre-allocated vring buffers, then it delivers these packets to upper layer protocols as skb buffs. So it's not necessary to pre-allocate skb for each mergable buffer, then frees extra skbs when buffers

Re: [Alacrityvm-devel] [PATCH v2 2/4] KVM: introduce xinterface API for external interaction with guests

2009-10-06 Thread Amit Shah
On (Tue) Oct 06 2009 [11:18:59], Ira W. Snyder wrote: The limitation I have is that memory made available from the host system (PCI card) as PCI BAR1 must not be migrated around in memory. I can only change the address decoding to hit a specific physical address. AFAIK, this means it cannot

Re: Release plan for 0.12.0

2009-09-30 Thread Amit Shah
On (Wed) Sep 30 2009 [08:04:17], Anthony Liguori wrote: Amit Shah wrote: On (Tue) Sep 29 2009 [18:54:53], Anthony Liguori wrote: o multiport virtio-console support Assuming we can get the kernel drivers straightened out, I think it's certainly reasonable for 0.12. The kernel

Re: Release plan for 0.12.0

2009-09-30 Thread Amit Shah
On (Wed) Sep 30 2009 [09:47:22], Anthony Liguori wrote: Amit Shah wrote: On (Wed) Sep 30 2009 [08:04:17], Anthony Liguori wrote: Amit Shah wrote: On (Tue) Sep 29 2009 [18:54:53], Anthony Liguori wrote: o multiport virtio-console support Assuming we can get the kernel

Re: Release plan for 0.12.0

2009-09-29 Thread Amit Shah
On (Tue) Sep 29 2009 [18:54:53], Anthony Liguori wrote: Hi, Now that 0.11.0 is behind us, it's time to start thinking about 0.12.0. I'd like to do a few things different this time around. I don't think the -rc process went very well as I don't think we got more testing out of it. I'd

Re: eepro100.c

2009-09-22 Thread Amit Shah
On (Tue) Sep 22 2009 [13:31:11], Michal Filka wrote: I don't want to corrupt present kvm installation, or better to say, I want to modify it as small as possible. Could you suggest me what should I replace or how to run new compilation instead of old one without installing? You can

Re: Multiple Port Support for virtio-console

2009-09-10 Thread Amit Shah
On (Wed) Sep 09 2009 [13:41:59], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu new kernel, new qemu old kernel, new qemu new kernel) and it all works fine

Multiple Port Support for virtio-console

2009-09-09 Thread Amit Shah
Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu new kernel, new qemu old kernel, new qemu new kernel) and it all works fine*. Migration works with the patch Juan just posted. There

[PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-09 Thread Amit Shah
http://www.linux-kvm.org/page/VMchannel_Requirements Signed-off-by: Amit Shah amit.s...@redhat.com --- drivers/char/Kconfig |4 +- drivers/char/virtio_console.c | 1069 +++- include/linux/virtio_console.h | 60 +++- 3 files changed, 994

[PATCH 1/5] char: Emit 'OPENED' events on char device open

2009-09-09 Thread Amit Shah
Notify users of the char interface whenever the file / connection is opened. The existing RESET event is triggered when the qemu char state is reset as well; which may not be as interesting as char device open events. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 14

[PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication

2009-09-09 Thread Amit Shah
see http://www.linux-kvm.org/page/VMchannel_Requirements Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/pc.c | 16 +- hw/virtio-console.c | 631 ++ hw/virtio-console.h | 53 + monitor.c |7 + qemu

[PATCH 3/5] virtio-console: in-qemu api for open/read/write/close ports

2009-09-09 Thread Amit Shah
This is a simple-to-use api for opening a port, registering a callback for reading stuff, writing to a port and closing it. Another api for hot-adding a port can be provided. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c | 61

[PATCH 4/5] vnc: add a is_vnc_active() helper

2009-09-09 Thread Amit Shah
This helper is introduced to query the status of vnc. Signed-off-by: Amit Shah amit.s...@redhat.com --- vnc.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/vnc.c b/vnc.c index 5eaef6a..ff2d4a8 100644 --- a/vnc.c +++ b/vnc.c @@ -178,9 +178,17 @@ static void

[PATCH 5/5] vnc: Send / receive guest clipboard if virtio-console connected to clipboard port

2009-09-09 Thread Amit Shah
If a connection to the guest clipboard is open, send the host clipboard to the guest and guest clipboard to the host on any change Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.h |1 + vnc.c | 33 + 2 files changed, 34

Re: Live migration between Intel Q6600 and AMD Phenom II

2009-09-08 Thread Amit Shah
Hello, On (Tue) Sep 08 2009 [13:32:39], Sterling Windmill wrote: I've read that it's possible to live migrate KVM guests between Intel and AMD CPUs, is it also possible to migrate from a CPU without NPT/EPT to the Phenom II that supports NPT? Will I lose out on any of the benefits NPT allows

Re: [PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-04 Thread Amit Shah
On (Thu) Sep 03 2009 [17:20:44], Juan Quintela wrote: Amit Shah amit.s...@redhat.com wrote: Hi +static void virtio_console_set_port_active(uint32_t idx) +{ +int i = 0; + +while (idx / 32) { +i++; +idx -= 32; +} It is just me

Multiple port support for virtio-console

2009-09-03 Thread Amit Shah
Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu new kernel, new qemu old kernel, new qemu new kernel) and it all works fine*. There are a few items on my todo list but this works

[PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Amit Shah
see http://www.linux-kvm.org/page/VMchannel_Requirements Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/pc.c | 16 +- hw/virtio-console.c | 594 ++- hw/virtio-console.h | 52 + monitor.c |7 + qemu

[PATCH 1/2] char: Emit 'OPENED' events on char device open

2009-09-03 Thread Amit Shah
Notify users of the char interface whenever the file / connection is opened. The existing RESET event is triggered when the qemu char state is reset as well; which may not be as interesting as char device open events. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 14

[PATCH 1/1] virtio_console: Add interface for guest and host communication

2009-09-03 Thread Amit Shah
http://www.linux-kvm.org/page/VMchannel_Requirements Signed-off-by: Amit Shah amit.s...@redhat.com --- drivers/char/Kconfig |4 +- drivers/char/virtio_console.c | 980 ++-- include/linux/virtio_console.h | 34 ++ 3 files changed, 889

  1   2   3   4   >