Hello Christoffer,
On Fri, Aug 28, 2015 at 2:30 AM, Christoffer Dall
christoffer.d...@linaro.org wrote:
On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote:
On 07/24/2015 08:00 AM, Matt Ma wrote:
Hi all,
Linaro has developed the foundation for the new Android Emulator
From: Asias He as...@redhat.com
VM sockets vhost transport implementation. This module runs in host
kernel.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vsock.c | 572 ++
drivers/vhost/vsock.h | 4 +
2 files changed, 576 insertions
From: Asias He as...@redhat.com
This module contains the common code and header files for the following
virtio-vsock and virtio-vhost kernel modules.
Signed-off-by: Asias He as...@redhat.com
---
include/linux/virtio_vsock.h | 207
include/uapi/linux/virtio_ids.h
From: Asias He as...@redhat.com
Signed-off-by: Asias He as...@redhat.com
---
include/net/af_vsock.h | 2 ++
net/vmw_vsock/af_vsock.c | 70
2 files changed, 72 insertions(+)
diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index
From: Asias He as...@redhat.com
Signed-off-by: Asias He as...@redhat.com
---
include/net/af_vsock.h | 1 +
net/vmw_vsock/af_vsock.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index 88f559a..ef668a0 100644
--- a/include/net/af_vsock.h
From: Asias He as...@redhat.com
VM sockets virtio transport implementation. This module runs in guest
kernel.
Signed-off-by: Asias He as...@redhat.com
---
net/vmw_vsock/virtio_transport.c | 448 +++
1 file changed, 448 insertions(+)
create mode 100644 net
From: Asias He as...@redhat.com
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/Makefile | 1 -
net/vmw_vsock/Makefile | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/vhost/Makefile b/drivers/vhost/Makefile
index eccff51..6b012b9 100644
--- a/drivers/vhost/Makefile
+++ b
is used to control device. Currently, no control operation is
defined.
Asias He (7):
VSOCK: Introduce vsock_find_unbound_socket and
vsock_bind_dgram_generic
VSOCK: Add dgram_skb to vsock_sock
VSOCK: Introduce virtio-vsock-common.ko
VSOCK: Introduce virtio-vsock.ko
VSOCK: Introduce
From: Asias He as...@redhat.com
Enable virtio-vsock and vhost-vsock.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/Kconfig | 4
drivers/vhost/Kconfig.vsock | 7 +++
drivers/vhost/Makefile | 5 +
net/vmw_vsock/Kconfig | 18 ++
net
vqs are freed in virtscsi_freeze but the hotcpu_notifier is not
unregistered. We will have a use-after-free usage when the notifier
callback is called after virtscsi_freeze.
Signed-off-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 15 ++-
1 file changed, 14
size or send data in dst iovec
to user (but i don't know how, I am not virtio expert :-)).
I'm CC'ing Asias, Sasha and others.
Hello Milan,
Does the attached patch fix your problem?
--
Asias
From b48eaeff7250bf7476c771e82cdbf20c3e85c4c9 Mon Sep 17 00:00:00 2001
From: Asias He asias.he
- WRITE payload case.
This bug would manifest itself as random process segmentation faults on
KVM host after repeated vhost starts + stops and/or with lots of vhost
endpoints + LUNs.
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Asias He
On Mon, Oct 14, 2013 at 7:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Wed, Jul 24, 2013 at 2:50 PM, Anthony Liguori anth...@codemonkey.ws
wrote:
I will be hosting a key signing party at this year's KVM Forum.
http://wiki.qemu.org/KeySigningParty2013
keyserver.cryptnet.net
7dc9579466c55f45648e8c06321c6a21cd19fe8b
Author: Asias He asias.he...@gmail.com
Date: Sat Apr 7 19:51:21 2012 +0800
kvm tools: Introduce trans=mmio parameter for virtio-net
To select virtio-mmio instead of virito-pci transport:
lkvm run --network trans=mmio
Signed-off-by: Asias He asias.he
?
commit 2a9bf9ca069c3476ec3c320ea1276f86158fe3fd
Author: Asias He asias.he...@gmail.com
Date: Fri Apr 8 22:12:52 2011 +0800
kvm tools: Virtio console support
This patch adds simple virtio console support to the hypervisor.
NOTE, NOTE, NOTE: Please add something like this to your
r-buf is hardcoded to 2056 which is (256 + 1) * 8, allowing 256 luns at
most. If more than 256 luns are specified by user, we have buffer
overflow in scsi_target_emulate_report_luns.
To fix, we allocate the buffer dynamically.
Signed-off-by: Asias He as...@redhat.com
Tested-by: Michael Roth mdr
r-buf is hardcoded to 2056 which is (256 + 1) * 8, allowing 256 luns at
most. If more than 256 luns are specified by user, we have buffer
overflow in scsi_target_emulate_report_luns.
To fix, we allocate the buffer dynamically.
Signed-off-by: Asias He as...@redhat.com
---
hw/scsi/scsi-bus.c
to do this fallback only when really needed.
Reported-by: Dan Aloni alo...@stratoscale.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Asias He as...@redhat.com
---
I put this on my vhost fixes branch, intend to merge for 3.12.
Dan, could you please confirm this works
memcpy_fromiovec is moved from net/core/iovec.c to lib/iovec.c.
linux/uio.h provides the declaration for memcpy_fromiovec.
Include linux/uio.h instead of inux/socket.h for it.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Fri, Aug 16, 2013 at 12:31:59AM -0700, David Miller wrote:
From: Asias He as...@redhat.com
Date: Fri, 16 Aug 2013 09:27:43 +0800
On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:
From: Asias He as...@redhat.com
Date: Thu, 15 Aug 2013 11:20:16 +0800
memcpy_fromiovec
On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:
From: Asias He as...@redhat.com
Date: Thu, 15 Aug 2013 11:20:16 +0800
memcpy_fromiovec is moved to lib/iovec.c. No need to include
linux/socket.h for it.
Signed-off-by: Asias He as...@redhat.com
You can't do
up any vhost_work_flush()
waiters before rescheduling instead of after rescheduling.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Asias He as...@redhat.com
Why exactly? It's not like flush needs to be extra fast ...
I'm not worried
memcpy_fromiovec is moved to lib/iovec.c. No need to include
linux/socket.h for it.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index e58cf00..038c242 100644
--- a/drivers
] __virtscsi_set_affinity+0x6f/0x120
RSP 88007bfe5a38
CR2: 0020
---[ end trace 99679331a3775f48 ]---
CC: sta...@vger.kernel.org
Signed-off-by: Asias He as...@redhat.com
---
drivers/scsi/virtio_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/virtio_scsi.c b
On Sun, Jul 07, 2013 at 05:40:51PM +0300, Michael S. Tsirkin wrote:
On Sun, Jul 07, 2013 at 02:37:10PM +0300, Michael S. Tsirkin wrote:
On Mon, May 06, 2013 at 08:10:03PM +0800, Asias He wrote:
On Mon, May 06, 2013 at 01:03:42PM +0300, Michael S. Tsirkin wrote:
On Mon, May 06, 2013 at 04
On Thu, Jun 27, 2013 at 01:23:24PM +0300, Michael S. Tsirkin wrote:
On Thu, Jun 27, 2013 at 03:59:59PM +0800, Asias He wrote:
Hello guys,
In commit d021c344051af91 (VSOCK: Introduce VM Sockets), VMware added VM
Sockets support. VM Sockets allows communication between virtual
machines
On Thu, Jun 27, 2013 at 03:03:01PM -0400, Sasha Levin wrote:
Hi Asias,
Looks nice! Some comments inline below (I've removed anything that mst already
commented on).
Thanks.
On 06/27/2013 03:59 AM, Asias He wrote:
Hello guys,
In commit d021c344051af91 (VSOCK: Introduce VM Sockets
On Thu, Jun 27, 2013 at 01:34:30PM +0300, Michael S. Tsirkin wrote:
On Thu, Jun 27, 2013 at 04:00:01PM +0800, Asias He wrote:
This module contains the common code and header files for the following
virtio-vsock and virtio-vhost kernel modules.
Signed-off-by: Asias He as...@redhat.com
On Thu, Jun 27, 2013 at 01:42:46PM +0300, Michael S. Tsirkin wrote:
On Thu, Jun 27, 2013 at 04:00:03PM +0800, Asias He wrote:
VM sockets vhost transport implementation. This module runs in host
kernel.
Signed-off-by: Asias He as...@redhat.com
Has any thought been given to how
Signed-off-by: Asias He as...@redhat.com
---
net/vmw_vsock/af_vsock.c | 70
net/vmw_vsock/af_vsock.h | 2 ++
2 files changed, 72 insertions(+)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 593071d..bc76ddb 100644
This module contains the common code and header files for the following
virtio-vsock and virtio-vhost kernel modules.
Signed-off-by: Asias He as...@redhat.com
---
include/linux/virtio_vsock.h| 200 +++
include/uapi/linux/virtio_ids.h | 1 +
include/uapi/linux
VM sockets virtio transport implementation. This module runs in guest
kernel.
Signed-off-by: Asias He as...@redhat.com
---
net/vmw_vsock/virtio_transport.c | 424 +++
1 file changed, 424 insertions(+)
create mode 100644 net/vmw_vsock/virtio_transport.c
diff
Enable virtio-vsock and vhost-vsock.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/Kconfig | 4
drivers/vhost/Kconfig.vsock | 7 +++
drivers/vhost/Makefile | 5 +
net/vmw_vsock/Kconfig | 18 ++
net/vmw_vsock/Makefile | 4
5
VM sockets vhost transport implementation. This module runs in host
kernel.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vsock.c | 534 ++
drivers/vhost/vsock.h | 4 +
2 files changed, 538 insertions(+)
create mode 100644 drivers
On Thu, Jun 27, 2013 at 07:25:40PM -0700, Andy King wrote:
Hi Michael,
__u32 guest_cid;
Given that cid is like an IP address, 32 bit seems too
limiting. I would go for a 64 bit one or maybe even 128 bit,
so that e.g. GUIDs can be used there.
That's likely based on what
it
to vhost_net_ubuf_put_and_wait, this results
in use after free.
To fix, don't free the argument in vhost_net_ubuf_put_and_wait,
add an new API for callers that want to free ubufs.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Asias He as...@redhat.com
---
Dave, this is needed for stable
Levin sasha.le...@oracle.com
CC: Asias He as...@redhat.com
Signed-off-by: Cyrill Gorcunov gorcu...@openvz.org
---
tools/kvm/x86/cpuid.c |8
1 file changed, 8 insertions(+)
Index: linux-2.6.git/tools/kvm/x86/cpuid.c
On Fri, Jun 07, 2013 at 02:06:40PM +0300, Pekka Enberg wrote:
On 06/07/2013 11:17 AM, Asias He wrote:
Ping! Is there someone out there who has a AMD box they could test this on?
I tested it on AMD box. Guest boots with this patch, guest does not
boot without it. I am not seeing the msr
On Fri, Jun 07, 2013 at 08:20:33PM +0800, Asias He wrote:
On Fri, Jun 07, 2013 at 02:06:40PM +0300, Pekka Enberg wrote:
On 06/07/2013 11:17 AM, Asias He wrote:
Ping! Is there someone out there who has a AMD box they could test this
on?
I tested it on AMD box. Guest boots
On Fri, Jun 7, 2013 at 9:50 PM, Qin Chuanyu qinchua...@huawei.com wrote:
the wake_up_process func is included by spin_lock/unlock in
vhost_work_queue,
but it could be done outside the spin_lock.
I have test it with kernel 3.0.27 and guest suse11-sp2 using iperf,
the num as below.
Levin sasha.le...@oracle.com
CC: Asias He as...@redhat.com
Signed-off-by: Cyrill Gorcunov gorcu...@openvz.org
---
tools/kvm/x86/cpuid.c |8
1 file changed, 8 insertions(+)
Index: linux-2.6.git/tools/kvm/x86/cpuid.c
'tcm_vhost_done_inflight' was not
declared. Should it be static?
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 4 ++--
drivers/vhost/scsi.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 05bdc3c..f800901 100644
...@gmail.com
Acked-by: Asias He as...@redhat.com
BTW, It would be nice to print more informative info in qemu when wwpn
is not available as well.
---
drivers/vhost/scsi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
-off-by: Marc Zyngier marc.zyng...@arm.com
Acked-by: Asias He asias.he...@gmail.com
---
tools/kvm/virtio/mmio.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/kvm/virtio/mmio.c b/tools/kvm/virtio/mmio.c
index a4e4855..afa2692 100644
--- a/tools/kvm/virtio
On Thu, May 23, 2013 at 10:30:00AM +0300, Pekka Enberg wrote:
Hello,
On 04/15/2013 10:11 AM, Lin Ming wrote:
On Mon, Apr 15, 2013 at 2:48 PM, Pekka Enberg penb...@kernel.org wrote:
Hello,
Hi,
On Mon, Apr 15, 2013 at 5:27 AM, Lin Ming min...@gmail.com wrote:
Will BIOS support be
On Wed, May 15, 2013 at 03:37:30PM -0700, Nicholas A. Bellinger wrote:
On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64:
ERROR: memcpy_fromiovec [drivers/vhost
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote:
Nicholas A. Bellinger n...@linux-iscsi.org writes:
On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build
On Thu, May 16, 2013 at 01:04:58PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure
-by: Randy Dunlap rdun...@infradead.org
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
index 8b9226d..0403323 100644
--- a/drivers/vhost/Kconfig
+++ b/drivers/vhost/Kconfig
On Tue, May 14, 2013 at 08:10:20PM -0700, Nicholas A. Bellinger wrote:
On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64:
ERROR
On Tue, May 07, 2013 at 02:22:32PM +0300, Michael S. Tsirkin wrote:
On Tue, May 07, 2013 at 02:52:45PM +0800, Asias He wrote:
Fix it by:
1) switching to use the new device specific fields per vq
2) not including vhost.c, instead make vhost-test.ko depend on vhost.ko.
Please split this up
Fix it by switching to use the new device specific fields per vq
Signed-off-by: Asias He as...@redhat.com
---
This is for 3.10.
drivers/vhost/test.c | 35 ---
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/drivers/vhost/test.c b/drivers/vhost
On Wed, May 08, 2013 at 10:59:03AM +0300, Michael S. Tsirkin wrote:
On Wed, May 08, 2013 at 03:14:58PM +0800, Asias He wrote:
On Tue, May 07, 2013 at 02:22:32PM +0300, Michael S. Tsirkin wrote:
On Tue, May 07, 2013 at 02:52:45PM +0800, Asias He wrote:
Fix it by:
1) switching to use
On Wed, May 08, 2013 at 10:56:19AM +0300, Michael S. Tsirkin wrote:
On Wed, May 08, 2013 at 03:24:33PM +0800, Asias He wrote:
Fix it by switching to use the new device specific fields per vq
Signed-off-by: Asias He as...@redhat.com
---
This is for 3.10.
drivers/vhost/test.c
It is disabled as a workaround. Now userspace bits works fine with it.
So, let's enable it.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/scsi.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d860b58
Fix it by:
1) switching to use the new device specific fields per vq
2) not including vhost.c, instead make vhost-test.ko depend on vhost.ko.
---
drivers/vhost/test.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/drivers/vhost/test.c
Asias He (4):
vhost-net: Always access vq-private_data under vq mutex
vhost-test: Always access vq-private_data under vq mutex
vhost-scsi: Always access vq-private_data under vq mutex
vhost: Remove custom vhost rcu usage
drivers/vhost/net.c | 37
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 2b51e23..b616d9a 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -349,12
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/test.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
index dc526eb..435b911 100644
--- a/drivers/vhost/test.c
+++ b/drivers/vhost/test.c
@@ -48,11 +48,12 @@ static
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/scsi.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 5531ebc..d78768b 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -896,19 +896,15
Now, vq-private_data is always accessed under vq mutex. No need to play
the vhost rcu trick.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 16 ++--
drivers/vhost/scsi.c | 6 ++
drivers/vhost/test.c | 11 ---
drivers/vhost/vhost.h | 10
On Tue, May 07, 2013 at 10:55:36AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 09:37:30AM +0800, Asias He wrote:
Hi,
I am seeing this with linus/master. Any ideas?
How reproducible it this? What HEAD are you seeing this with?
Almost always. Start a guest with vhost-net
On Tue, May 07, 2013 at 11:18:38AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 04:14:50PM +0800, Asias He wrote:
On Tue, May 07, 2013 at 10:55:36AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 09:37:30AM +0800, Asias He wrote:
Hi,
I am seeing this with linus/master
On Tue, May 07, 2013 at 11:18:38AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 04:14:50PM +0800, Asias He wrote:
On Tue, May 07, 2013 at 10:55:36AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 09:37:30AM +0800, Asias He wrote:
Hi,
I am seeing this with linus/master
On Tue, May 07, 2013 at 11:42:07AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 04:36:50PM +0800, Asias He wrote:
On Tue, May 07, 2013 at 11:18:38AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 04:14:50PM +0800, Asias He wrote:
On Tue, May 07, 2013 at 10:55:36AM +0300, Gleb
:
On Tue, May 07, 2013 at 05:10:41PM +0800, Asias He wrote:
On Tue, May 07, 2013 at 11:42:07AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 04:36:50PM +0800, Asias He wrote:
On Tue, May 07, 2013 at 11:18:38AM +0300, Gleb Natapov wrote:
On Tue, May 07, 2013 at 04:14:50PM
66 90 b8 00 01 00 00 f0 66 0f c1 07 89 c2
66 c1 ea 08 38 c2 74 0c 0f 1f 00 f3 90 0f
RIP [81c0721e] _raw_spin_lock+0xe/0x30
RSP 880221721cc8
CR2:
---[ end trace 13fb1e4b6e5ab21f ]---
Signed-off-by: Asias He as...@redhat.com
---
virt/kvm/kvm_main.c | 11 ++-
1
On Tue, May 07, 2013 at 05:59:38PM +0300, Michael S. Tsirkin wrote:
On Tue, May 07, 2013 at 10:54:16PM +0800, Asias He wrote:
In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when
kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko),
kvm_arch_init() will fail
66 90 b8 00 01 00 00 f0 66 0f c1 07 89 c2
66 c1 ea 08 38 c2 74 0c 0f 1f 00 f3 90 0f
RIP [81c0721e] _raw_spin_lock+0xe/0x30
RSP 880221721cc8
CR2:
---[ end trace 13fb1e4b6e5ab21f ]---
Signed-off-by: Asias He as...@redhat.com
---
virt/kvm/kvm_main.c | 18
Hello Rusty,
On Mon, May 06, 2013 at 03:41:36PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
Asias He (3):
vhost: Remove vhost_enable_zcopy in vhost.h
vhost: Move VHOST_NET_FEATURES to net.c
vhost: Make vhost a separate module
I like these cleanups, MST pleasee
On Mon, May 6, 2013 at 4:17 PM, Michael S. Tsirkin m...@redhat.com wrote:
Typo a/adn/and/
Yes. Catched this up and and fixed already.
On Fri, May 03, 2013 at 02:25:18PM +0800, Asias He wrote:
- Rename vhost_ubuf to vhost_net_ubuf
- Rename vhost_zcopy_mask to vhost_net_zcopy_mask
- Make
MST, This is on top of [PATCH 0/2] vhost-net fix ubuf.
Asias He (11):
vhost: Remove vhost_enable_zcopy in vhost.h
vhost: Move VHOST_NET_FEATURES to net.c
vhost: Make vhost a separate module
vhost: Remove comments for hdr in vhost.h
vhost: Simplify dev-vqs[i] access
vhost-net: Cleanup
It is net.c specific.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index cc23bc4..076c9ac 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
@@ -192,7 +192,4
vhost.h should not depend on device specific marcos like
VHOST_NET_F_VIRTIO_NET_HDR and VIRTIO_NET_F_MRG_RXBUF.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 6 ++
drivers/vhost/vhost.h | 3 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers
Currently, vhost-net and vhost-scsi are sharing the vhost core code.
However, vhost-scsi shares the code by including the vhost.c file
directly.
Making vhost a separate module makes it is easier to share code with
other vhost devices.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost
It is supposed to be removed when hdr is moved into vhost_net_virtqueue.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 94a80eb..51aeb5f 100644
--- a/drivers/vhost
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index e406d5f..74bc779 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost
- Rename vhost_ubuf to vhost_net_ubuf
- Rename vhost_zcopy_mask to vhost_net_zcopy_mask
- Make funcs static
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 58 +++--
1 file changed, 30 insertions(+), 28 deletions(-)
diff --git
It was needed when struct tcm_vhost_tpg is in tcm_vhost.h
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 2dcb94a..02ddedd 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost
vs is used everywhere, make the naming more consistent.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/scsi.c | 56 ++--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/scsi.c | 154 +--
1 file changed, 88 insertions(+), 66 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d4798e1..d9781ed 100644
--- a/drivers/vhost/scsi.c
+++ b
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/scsi.c | 122 +--
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d9781ed..353145f 100644
--- a/drivers/vhost/scsi.c
+++ b
This way, we use cmd for struct tcm_vhost_cmd and evt for struct
tcm_vhost_cmd.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/scsi.c | 142 +--
1 file changed, 71 insertions(+), 71 deletions(-)
diff --git a/drivers/vhost/scsi.c b
On Mon, May 06, 2013 at 01:07:46PM +0300, Michael S. Tsirkin wrote:
On Mon, May 06, 2013 at 04:38:18PM +0800, Asias He wrote:
MST, This is on top of [PATCH 0/2] vhost-net fix ubuf.
Okay, how about making EVENT_IDX work for virtio-scsi?
I'm guessing it's some messup with feature negotiation
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote:
There's no net specific code in vhost.c anymore,
don't include the virtio_net.h header.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Asias He as...@redhat.com
---
This is on top of Asias' patches
On Mon, May 06, 2013 at 01:03:42PM +0300, Michael S. Tsirkin wrote:
On Mon, May 06, 2013 at 04:38:21PM +0800, Asias He wrote:
Currently, vhost-net and vhost-scsi are sharing the vhost core code.
However, vhost-scsi shares the code by including the vhost.c file
directly.
Making vhost
On Mon, May 06, 2013 at 04:15:35PM +0300, Michael S. Tsirkin wrote:
On Mon, May 06, 2013 at 08:05:26PM +0800, Asias He wrote:
On Mon, May 06, 2013 at 01:07:46PM +0300, Michael S. Tsirkin wrote:
On Mon, May 06, 2013 at 04:38:18PM +0800, Asias He wrote:
MST, This is on top of [PATCH 0/2
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote:
There's no net specific code in vhost.c anymore,
don't include the virtio_net.h header.
Did you push the it to your tree. I am not seeing it.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
This is on top of Asias'
Hi,
I am seeing this with linus/master. Any ideas?
[ 34.168356] IPv6: ADDRCONF(NETDEV_UP): virbr0: link is not ready
[ 36.743758] BUG: unable to handle kernel paging request at 00030029
[ 36.745177] IP: [81c08584] __mutex_lock_slowpath+0x34/0x240
[ 36.746576] PGD 0
[
On Fri, May 3, 2013 at 5:19 PM, Pekka Enberg penb...@kernel.org wrote:
On Wed, May 1, 2013 at 6:50 PM, Will Deacon will.dea...@arm.com wrote:
From: Marc Zyngier marc.zyng...@arm.com
Kvmtool suppresses any output to a console that has not been elected
as *the* console.
While this makes sense
Asias He (2):
vhost: Export vhost_dev_set_owner
vhost-net: Free ubuf when vhost_dev_set_owner fails
drivers/vhost/net.c | 38 --
drivers/vhost/vhost.c | 2 +-
drivers/vhost/vhost.h | 1 +
3 files changed, 34 insertions(+), 7 deletions(-)
--
1.8.1.4
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.c | 2 +-
drivers/vhost/vhost.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 749b5ab..de9441a 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 38 --
1 file changed, 32 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index a3645bd..354665a 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
On Sun, May 05, 2013 at 04:50:07PM +0300, Michael S. Tsirkin wrote:
On Fri, May 03, 2013 at 02:25:17PM +0800, Asias He wrote:
Free ubuf when vhost_dev_ioctl for VHOST_SET_OWNER fails.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 20 ++--
1 file
Asias He (4):
vhost: Remove comments for hdr in vhost.h
vhost: Simplify dev-vqs[i] access
vhost-net: Free ubuf when vhost_dev_ioctl fails
vhost-net: Cleanup vhost_ubuf adn vhost_zcopy
drivers/vhost/net.c | 76 +++
drivers/vhost/vhost.c
It is supposed to be removed when hdr is moved into vhost_net_virtqueue.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 6fefebf..f9045b4 100644
--- a/drivers/vhost
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/vhost.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 73100fe..0003bab 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost
Free ubuf when vhost_dev_ioctl for VHOST_SET_OWNER fails.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index b2f6b41..eb73217 100644
- Rename vhost_ubuf to vhost_net_ubuf
- Rename vhost_zcopy_mask to vhost_net_zcopy_mask
- Make funcs static
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/net.c | 58 +++--
1 file changed, 30 insertions(+), 28 deletions(-)
diff --git
1 - 100 of 803 matches
Mail list logo
