Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-11 Thread Bjorn Helgaas
On Wed, Mar 11, 2015 at 3:14 PM, Alex Williamson alex.william...@redhat.com wrote: On Fri, 2015-03-06 at 16:11 -0600, Bjorn Helgaas wrote: On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote: This copies the same support from pci-stub for exactly the same purpose, enabling a set

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-06 Thread Bjorn Helgaas
On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote: This copies the same support from pci-stub for exactly the same purpose, enabling a set of PCI IDs to be automatically added to the driver's dynamic ID table at module load time. The code here is pretty simple and both vfio-pci

Re: [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-02-02 Thread Bjorn Helgaas
. [bhelgaas: changelog] Reported-by: Zhang Jukuo zhangju...@huawei.com Tested-by: Zhang Jukuo zhangju...@huawei.com Signed-off-by: Yijing Wang wangyij...@huawei.com Signed-off-by: Bjorn Helgaas bhelg...@google.com diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index c489ef2c1a39

Re: [Xen-devel] [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-01-29 Thread Bjorn Helgaas
On Thu, Jan 29, 2015 at 7:15 AM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 04:54, wangyij...@huawei.com wrote: --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -694,11 +694,16 @@ static void __iomem *msix_map_region(struct pci_dev *dev, unsigned nr_entries) {

Re: [PATCH v2] PCI: Add guard to avoid mapping a invalid msix base address

2015-01-28 Thread Bjorn Helgaas
[+cc Konrad, Boris, David, xen-devel, Alex, kvm] On Wed, Jan 28, 2015 at 09:52:17AM +0800, Yijing Wang wrote: Sometimes, a pci bridge device BAR was not assigned properly. After we call pci_bus_assign_resources(), the resource of the BAR would be reseted. So if we try to enable msix for this

Re: [Xen-devel] [PATCH v2] PCI: Add guard to avoid mapping a invalid msix base address

2015-01-28 Thread Bjorn Helgaas
On Wed, Jan 28, 2015 at 3:05 PM, Boris Ostrovsky boris.ostrov...@oracle.com wrote: On 01/28/2015 01:13 PM, Bjorn Helgaas wrote: diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index fd60806..c3e7dfc 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -694,11 +694,16 @@ static void

Re: [PATCH v9 14/19] vfio: move eventfd support code for VFIO_PCI to a separate file

2014-10-27 Thread Bjorn Helgaas
Hi Antonios, On Mon, Oct 27, 2014 at 12:07 PM, Antonios Motakis a.mota...@virtualopensystems.com wrote: The virqfd functionality that is used by VFIO_PCI to implement interrupt masking and unmasking via an eventfd, is generic enough and can be reused by another driver. Move it to a separate

Re: [PATCH v9 17/19] vfio: virqfd: add vfio_ prefix to virqfd_enable and virqfd_disable

2014-10-27 Thread Bjorn Helgaas
On Mon, Oct 27, 2014 at 12:08 PM, Antonios Motakis a.mota...@virtualopensystems.com wrote: The virqfd_enable and virqfd_disable functions are now global. Add the vfio_ prefix to those functions. Wouldn't it be better to change the name *before* making them global? Bjorn -- To unsubscribe from

Re: [Bug 85441] New: [vfio] [lockdep] Deadlock when attempting to unbind device from a running VM

2014-10-02 Thread Bjorn Helgaas
[+ Alex, linux-pci, kvm] On Thu, Oct 2, 2014 at 4:11 AM, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=85441 Bug ID: 85441 Summary: [vfio] [lockdep] Deadlock when attempting to unbind device from a running

Re: [PATCH v4 0/4 resend] Introduce device assignment flag operation helper function

2014-09-16 Thread Bjorn Helgaas
On Tue, Sep 09, 2014 at 10:21:24AM +0800, Ethan Zhao wrote: This patch set introduces three PCI device flag operation helper functions when set pci device PF/VF to assigned or deassigned status also check it. and patch 2,3,4 apply these helper functions to KVM,XEN and PCI. v2: simplify

Re: [PATCH v3 0/4 resend] Introduce device assignment flag operation helper function

2014-09-08 Thread Bjorn Helgaas
On Fri, Sep 05, 2014 at 11:15:22AM -0600, Bjorn Helgaas wrote: On Fri, Aug 08, 2014 at 01:36:03PM +0800, Ethan Zhao wrote: This patch set introduces three PCI device flag operation helper functions when set pci device PF/VF to assigned or deassigned status also check it. and patch 2,3,4

Re: [PATCH v3 0/4 resend] Introduce device assignment flag operation helper function

2014-09-05 Thread Bjorn Helgaas
On Fri, Aug 08, 2014 at 01:36:03PM +0800, Ethan Zhao wrote: This patch set introduces three PCI device flag operation helper functions when set pci device PF/VF to assigned or deassigned status also check it. and patch 2,3,4 apply these helper functions to KVM,XEN and PCI. v2: simplify

Re: [PATCH 1/4] PCI: Export MSI message relevant functions

2014-09-04 Thread Bjorn Helgaas
On Mon, May 19, 2014 at 01:01:07PM +1000, Gavin Shan wrote: The patch exports 2 MSI message relevant functions, which will be used by VFIO PCI driver. The VFIO PCI driver would be built as a module. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com Acked-by: Bjorn Helgaas bhelg

Re: [PATCH 4/4] vfio/pci: Restore MSIx message prior to enabling

2014-06-02 Thread Bjorn Helgaas
On Sat, May 31, 2014 at 5:42 AM, Gavin Shan gws...@linux.vnet.ibm.com wrote: On Fri, May 30, 2014 at 04:12:32PM -0600, Bjorn Helgaas wrote: On Mon, May 19, 2014 at 01:01:10PM +1000, Gavin Shan wrote: The MSIx vector table lives in device memory, which may be cleared as part of a backdoor device

Re: [PATCH 4/4] vfio/pci: Restore MSIx message prior to enabling

2014-05-30 Thread Bjorn Helgaas
On Mon, May 19, 2014 at 01:01:10PM +1000, Gavin Shan wrote: The MSIx vector table lives in device memory, which may be cleared as part of a backdoor device reset. This is the case on the IBM IPR HBA when the BIST is run on the device. When assigned to a QEMU guest, the guest driver does a

Re: [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-28 Thread Bjorn Helgaas
On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote: The driver_override field allows us to specify the driver for a device rather than relying on the driver to provide a positive match of the device. This shortcuts the existing process of looking up the vendor and device ID,

Re: [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-27 Thread Bjorn Helgaas
On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote: The driver_override field allows us to specify the driver for a device rather than relying on the driver to provide a positive match of the device. This shortcuts the existing process of looking up the vendor and device ID,

Coverity CID 714665: vfio_ext_cap_len() use of uninitialized variable

2014-04-03 Thread Bjorn Helgaas
Coverity complains that byte is used uninitialized in drivers/vfio/pci/vfio_pci_config.c in vfio_ext_cap_len(): 1139sts = byte PCI_TPH_CAP_ST_MASK; 1140sts = PCI_TPH_CAP_ST_SHIFT; 1141return PCI_TPH_BASE_SIZEOF +

Re: Coverity CID 714665: vfio_ext_cap_len() use of uninitialized variable

2014-04-03 Thread Bjorn Helgaas
On Thu, Apr 3, 2014 at 9:53 AM, Bjorn Helgaas bhelg...@google.com wrote: Coverity complains that byte is used uninitialized in drivers/vfio/pci/vfio_pci_config.c in vfio_ext_cap_len(): 1139sts = byte PCI_TPH_CAP_ST_MASK; 1140sts

Re: [PATCH 8/9] PCI: Ignore BAR contents when firmware left decoding disabled

2014-03-21 Thread Bjorn Helgaas
[+cc kvm list] On Wed, Mar 19, 2014 at 7:32 PM, Ming Lei tom.leim...@gmail.com wrote: On Thu, Mar 20, 2014 at 12:45 AM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Mar 18, 2014 at 10:52 PM, Ming Lei tom.leim...@gmail.com wrote: Hi, Looks Sasha fixed the problem in lkvm tool[1]. Sasha

Re: [PATCH 8/9] PCI: Ignore BAR contents when firmware left decoding disabled

2014-03-21 Thread Bjorn Helgaas
On Fri, Mar 21, 2014 at 2:25 PM, Sasha Levin sasha.le...@oracle.com wrote: On 03/21/2014 04:07 PM, Bjorn Helgaas wrote: I think I figured out what the problem is. In virtio_pci__init(), we allocate some address space with pci_get_io_space_block(), save its address in vpci-mmio_addr, and hook

Re: [PATCH v2 7/9] vfio: Use pci_enable_msi_range() and pci_enable_msix_range()

2014-01-29 Thread Bjorn Helgaas
On Fri, Jan 17, 2014 at 05:02:21PM +0100, Alexander Gordeev wrote: As result deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range()

Re: [PATCH v2 0/9] Phase out pci_enable_msi_block()

2014-01-29 Thread Bjorn Helgaas
On Sat, Jan 18, 2014 at 09:59:40AM -0500, Tejun Heo wrote: On Sat, Jan 18, 2014 at 07:38:55AM -0700, Bjorn Helgaas wrote: On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev agord...@redhat.com wrote: On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: As the release

Re: [PATCH v2 0/9] Phase out pci_enable_msi_block()

2014-01-18 Thread Bjorn Helgaas
On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev agord...@redhat.com wrote: On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: As the release is supposedly this weekend, do you prefer the patches to go to your tree or to individual trees after the release? I'd be happy

Re: [PATCH v2 0/9] Phase out pci_enable_msi_block()

2014-01-17 Thread Bjorn Helgaas
On Fri, Jan 17, 2014 at 9:02 AM, Alexander Gordeev agord...@redhat.com wrote: This series is against next branch in Bjorn's repo: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git Changes from v1 to v2: - added a regression fix ahci: Fix broken fallback to single MSI mode

Re: [PATCH v2] vfio-pci: Use pci try reset interface

2014-01-15 Thread Bjorn Helgaas
On Tue, Jan 14, 2014 at 8:45 PM, Alex Williamson alex.william...@redhat.com wrote: PCI resets will attempt to take the device_lock for any device to be reset. This is a problem if that lock is already held, for instance in the device remove path. It's not sufficient to simply kill the user

Re: [PATCH] vfio-pci: Use pci try reset interface

2014-01-14 Thread Bjorn Helgaas
On Mon, Dec 16, 2013 at 3:16 PM, Alex Williamson alex.william...@redhat.com wrote: PCI resets will attempt to take the device_lock for any device to be reset. This is a problem if that lock is already held, for instance in the device remove path. It's not sufficient to simply kill the user

Re: [PATCH] vfio-pci: PCI hot reset interface

2013-08-19 Thread Bjorn Helgaas
On Mon, Aug 19, 2013 at 12:41 PM, Alex Williamson alex.william...@redhat.com wrote: On Wed, 2013-08-14 at 17:06 -0600, Alex Williamson wrote: On Wed, 2013-08-14 at 16:42 -0600, Bjorn Helgaas wrote: On Wed, Aug 14, 2013 at 2:10 PM, Alex Williamson alex.william...@redhat.com wrote: +static

Re: [PATCH] vfio-pci: PCI hot reset interface

2013-08-14 Thread Bjorn Helgaas
[+cc Al, linux-fsdevel for fdget/fdput usage] On Wed, Aug 14, 2013 at 2:10 PM, Alex Williamson alex.william...@redhat.com wrote: The current VFIO_DEVICE_RESET interface only maps to PCI use cases where we can isolate the reset to the individual PCI function. This means the device must support

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Bjorn Helgaas
[+cc linux-pci] On Fri, Aug 2, 2013 at 3:28 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Right. Another use case is, I know of devices that need a fundamental reset (PERST) after applying a FW update. This is a tangent from the real discussion here, but the question of resetting

Re: Linux Plumbers ACPI/PM, PCI Microconference

2013-07-23 Thread Bjorn Helgaas
On Tue, Jul 16, 2013 at 8:21 PM, Myron Stowe myron.st...@gmail.com wrote: Linux Plumbers has approved an ACPI/PM, PCI microconference. The overview page is here: http://wiki.linuxplumbersconf.org/2013:pci_subsystem We would like to start receiving volunteers for presenting topics of

Re: [PATCH RFC] pci: ACS quirk for AMD southbridge

2013-06-25 Thread Bjorn Helgaas
On Wed, Jul 11, 2012 at 11:18 PM, Alex Williamson alex.william...@redhat.com wrote: We've confirmed that peer-to-peer between these devices is not possible. We can therefore claim that they support a subset of ACS. Signed-off-by: Alex Williamson alex.william...@redhat.com Cc: Joerg Roedel

Re: [PATCH RFC] pci: ACS quirk for AMD southbridge

2013-06-25 Thread Bjorn Helgaas
[fix Joerg's email address] On Tue, Jun 25, 2013 at 10:15 PM, Bjorn Helgaas bhelg...@google.com wrote: On Wed, Jul 11, 2012 at 11:18 PM, Alex Williamson alex.william...@redhat.com wrote: We've confirmed that peer-to-peer between these devices is not possible. We can therefore claim

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-24 Thread Bjorn Helgaas
On Wed, Jun 19, 2013 at 6:43 AM, Don Dutile ddut...@redhat.com wrote: On 06/18/2013 10:52 PM, Bjorn Helgaas wrote: On Tue, Jun 18, 2013 at 5:03 PM, Don Dutileddut...@redhat.com wrote: On 06/18/2013 06:22 PM, Alex Williamson wrote: On Tue, 2013-06-18 at 15:31 -0600, Bjorn Helgaas wrote

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-18 Thread Bjorn Helgaas
On Thu, May 30, 2013 at 12:40:19PM -0600, Alex Williamson wrote: PCIe ACS (Access Control Services) is the PCIe 2.0+ feature that allows us to control whether transactions are allowed to be redirected in various subnodes of a PCIe topology. For instance, if two endpoints are below a root port

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-18 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 12:20 PM, Alex Williamson alex.william...@redhat.com wrote: On Tue, 2013-06-18 at 11:28 -0600, Bjorn Helgaas wrote: On Thu, May 30, 2013 at 12:40:19PM -0600, Alex Williamson wrote: PCIe ACS (Access Control Services) is the PCIe 2.0+ feature that allows us to control

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-18 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 5:03 PM, Don Dutile ddut...@redhat.com wrote: On 06/18/2013 06:22 PM, Alex Williamson wrote: On Tue, 2013-06-18 at 15:31 -0600, Bjorn Helgaas wrote: On Tue, Jun 18, 2013 at 12:20 PM, Alex Williamson alex.william...@redhat.com wrote: On Tue, 2013-06-18 at 11:28

Re: [Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-12-26 Thread Bjorn Helgaas
On Mon, Nov 26, 2012 at 11:46 PM, Gleb Natapov g...@redhat.com wrote: On Mon, Nov 26, 2012 at 09:46:12PM -0200, Marcelo Tosatti wrote: On Tue, Nov 20, 2012 at 02:09:46PM +, Pandarathil, Vijaymohan R wrote: -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com]

Re: SR-IOV problem with Intel 82599EB (not enough MMIO resources for SR-IOV)

2012-11-09 Thread Bjorn Helgaas
[+ linux-pci, Yinghai] On Thu, Nov 8, 2012 at 8:59 PM, Jason Gao pkill.2...@gmail.com wrote: The BIOS in your machine doesn't support SR-IOV. You'll need to ask the manufacturer for a BIOS upgrade, if in fact one is available. Sometimes they're not. very thanks Greg,my server Dell R710

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Bjorn Helgaas
. Do the same change for the pci_get_class() as suggested by Bjorn Helgaas [bhelgaas: changelog, clear pci_device_id on stack with memset()] Bisected-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Feng Tang feng.t...@intel.com Signed-off-by: Bjorn Helgaas bhelg

Re: pci_get_subsys: GFP_KERNEL allocations with IRQs disabled

2012-08-22 Thread Bjorn Helgaas
On Wed, Aug 22, 2012 at 12:49 AM, Feng Tang feng.t...@intel.com wrote: Hi Fengguang, On Wed, 22 Aug 2012 10:50:08 +0800 Fengguang Wu fengguang...@intel.com wrote: Feng, I think it's pci_get_subsys() triggered this assert: /* * Oi! Can't be having __GFP_FS

Re: [PATCH v2] PCI: Mark INTx masking support of Chelsio T310 10GbE NIC as broken

2012-06-18 Thread Bjorn Helgaas
On Thu, Jun 7, 2012 at 2:30 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com According to http://thread.gmane.org/gmane.comp.emulators.kvm.devel/91388 the T310 does not properly support INTx masking as it fails to keep the PCI_STATUS_INTERRUPT bit updated

Re: [PATCH v2] PCI: Add Ralink RT2800 broken INTx masking quirk

2012-06-18 Thread Bjorn Helgaas
On Thu, Jun 7, 2012 at 11:01 AM, Alex Williamson alex.william...@redhat.com wrote: Passes pci_intx_mask_supported test but continues to send interrupts as discovered through VFIO-based device assignment. http://www.spinics.net/lists/kvm/msg73738.html Signed-off-by: Alex Williamson

Re: [PATCH 4/4] PCI: save/restore max Latency Value for device LTR

2012-06-12 Thread Bjorn Helgaas
On Fri, Jun 8, 2012 at 2:01 AM, Xudong Hao xudong@intel.com wrote: LTR: Save Max snoop/no-snoop Latency Value in pci_save_pcie_state, and restore them in pci_restore_pcie_state. Signed-off-by: Xudong Hao xudong@intel.com ---  drivers/pci/pci.c   |   71

Re: [PATCH 0/4] PCI: Enable LTR/OBFF before device is used by driver

2012-06-08 Thread Bjorn Helgaas
On Fri, Jun 8, 2012 at 1:01 AM, Xudong Hao xudong@intel.com wrote: The series of patches enable LTR and OBFF before device is used by driver, and introduce a couple of functions to save/restore LTR latency value. Patch 1/4 introduce new function pci_obff_supported() as pci_ltr_support().

Re: [PATCH] PCI: save/restore max Latency Value for device LTR

2012-05-18 Thread Bjorn Helgaas
On Tue, May 8, 2012 at 3:09 AM, Hao, Xudong xudong@intel.com wrote: -Original Message- From: Bjorn Helgaas [mailto:bhelg...@google.com]  } This doesn't make any sense to me.  pos is the offset of the PCI Express Capability (identifier 10h).  LTR is a separate extended

Re: [PATCH 1/1] Enable LTR/OBFF before device is used by driver

2012-05-18 Thread Bjorn Helgaas
On Sun, May 13, 2012 at 8:48 PM, Xudong Hao xudong@linux.intel.com wrote: Enable LTR(Latency tolerance reporting) and OBFF(optimized buffer flush/fill) in  pci_enable_device(), so that they are enabled before the device is used by driver. Please split this into two patches (one for LTR

Re: [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-15 Thread Bjorn Helgaas
On Mon, May 14, 2012 at 4:49 PM, Alex Williamson alex.william...@redhat.com wrote: On Mon, 2012-05-14 at 16:02 -0600, Bjorn Helgaas wrote: On Fri, May 11, 2012 at 4:56 PM, Alex Williamson alex.william...@redhat.com wrote: In a PCIe environment, transactions aren't always required to reach

Re: [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-15 Thread Bjorn Helgaas
I tried to work through some examples to develop some intuition about this: Sorry, gmail inserted line breaks that ruined this picture. Here's a URL for it: http://www.asciiflow.com/#3736558963405980039 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH 10/13] pci: export pci_user functions for use by other drivers

2012-05-14 Thread Bjorn Helgaas
remove the externs when you move these declarations? I know the file's currently a random mix, but we might as well make a tiny improvement. Looks fine to me otherwise, and if you don't have any other reason to update this series, don't worry about it. Acked-by: Bjorn Helgaas bhelg...@google.com

Re: [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-14 Thread Bjorn Helgaas
On Fri, May 11, 2012 at 4:56 PM, Alex Williamson alex.william...@redhat.com wrote: In a PCIe environment, transactions aren't always required to reach the root bus before being re-routed.  Peer-to-peer DMA may actually not be seen by the IOMMU in these cases.  For IOMMU groups, we want to

Re: [PATCH] PCI: save/restore max Latency Value for device LTR

2012-05-07 Thread Bjorn Helgaas
On Sun, May 6, 2012 at 8:11 AM, Xudong Hao xudong@linux.intel.com wrote: LTR: Save Max snoop/no-snoop Latency Value in pci_save_pcie_state, and restore them in pci_restore_pcie_state. Signed-off-by: Xudong Hao xudong@intel.com ---  drivers/pci/pci.c |   12  1 files

Re: [PATCH] Fix warning

2012-04-04 Thread Bjorn Helgaas
On Wed, Apr 4, 2012 at 9:30 AM, Tadeusz Struk tadeusz.st...@intel.com wrote: Hi Bjorn, Did you have chance to look at this one? Yep. It needs a changelog. Fixed warning is inadequate. It needs an explanation of what the VF connection is. It would also be nice if you fixed the function

Re: [PATCH 1/1 v3] PCI: Device specific reset function

2012-03-05 Thread Bjorn Helgaas
On Mon, Mar 5, 2012 at 3:00 AM, Tadeusz Struk tadeusz.st...@intel.com wrote: ---  drivers/pci/pci.h    |    1 +  drivers/pci/quirks.c |   33 +++--  include/linux/pci.h  |    1 +  3 files changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/pci/pci.h

Re: [PATCH v2] Dynamically add and remove device specific reset functions

2012-03-02 Thread Bjorn Helgaas
Thanks! You didn't fix the subject line :) It should contain PCI: . Thanks for including the v2 inside [PATCH]. That helps keep things straight. On Fri, Mar 2, 2012 at 4:55 AM, tadeusz.st...@intel.com wrote: Hi, Reworked according to comments. All the text here becomes part of the

Re: [PATCH v2] Dynamically add and remove device specific reset functions

2012-03-02 Thread Bjorn Helgaas
On Fri, Mar 2, 2012 at 10:06 AM, Tadeusz Struk tadeusz.st...@intel.com wrote: On 02/03/12 16:29, Bjorn Helgaas wrote: Where do you plan to add calls to pci_dev_specific_reset_add()?  In drivers? Yes, I'm working on a driver for a device with SRIOV capability. I'll call it from there. Did

Re: [PATCH] Added functionality that allows dynamically add and remove device specific reset functions

2012-03-01 Thread Bjorn Helgaas
On Thu, Mar 1, 2012 at 10:18 AM, tadeusz.st...@intel.com wrote: From b4cf24d5987475862de799c78773f13f25ed2af8 Mon Sep 17 00:00:00 2001 From: Tadeusz Struk tadeusz.st...@intel.com Date: Tue, 17 Jan 2012 16:45:46 + Subject: [PATCH] Added functionality that allows dynamically add and remove

Re: [PATCH] pci: clean all funcs when hot-removing multifunc device

2011-09-15 Thread Bjorn Helgaas
On Tue, Sep 13, 2011 at 10:55 PM, Amos Kong ak...@redhat.com wrote: 'slot-funcs' is initialized in acpiphp_glue.c:register_slot() before hotpluging device, and only one entry(func 0) is added to it, no new entry will be added to the list when hotpluging devices to the slot. When we release the

Re: [PATCH 2/16 v6] PCI: define PCI resource names in an 'enum'

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:40:41 am Yu Zhao wrote: This patch moves all definitions of the PCI resource names to an 'enum', and also replaces some hard-coded resource variables with symbol names. This change eases introduction of device specific resources. Thanks for removing a bunch of

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:45:31 am Yu Zhao wrote: Document the new PCI[x86] boot parameters. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox

Re: [PATCH 9/16 v6] PCI: add boot option to align MMIO resources

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:43:24 am Yu Zhao wrote: This patch adds boot option to align MMIO resource for a device. The alignment is a bigger value between the PAGE_SIZE and the resource size. It looks like this forces alignment on PAGE_SIZE, not a bigger value between the PAGE_SIZE and