Some of the alpha pci noop dma ops are identical to the common ones.
Use them.
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
arch/alpha/kernel/pci-noop.c | 46
1 file changed, 4 insertions(+), 42 deletions(-)
diff --git
As virtio-ccw now has dma ops, we can no longer default to the PCI ones.
Make use of dev_archdata to keep the dma_ops per device.
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
arch/s390/include/asm/device.h | 6 +-
arch/s390/include/asm/dma-mapping.h | 2 +-
with the dummy ones
- patch3: allow per device dma ops for s390
- patch4: wire up virtio dma ops
TODOs
- test (s390 virtio-ccw with Andis changes, s390 pci) and review
- check i386 nommu dma ops for potential improvements in the noop
handlers
- make dma-noop only compile when necessary
Christian
With all infrastructure in place, lets provide dma_ops for virtio
devices on s390.
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
drivers/s390/virtio/kvm_virtio.c | 2 ++
drivers/s390/virtio/virtio_ccw.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/driver
Am 28.10.2015 um 10:17 schrieb Andy Lutomirski:
@@ -423,27 +522,42 @@ EXPORT_SYMBOL_GPL(virtqueue_kick);
>
> static void detach_buf(struct vring_virtqueue *vq, unsigned int head)
> {
> - unsigned int i;
> + unsigned int i, j;
> + u16 nextflag = cpu_to_virtio16(vq->vq.vdev,
Am 28.10.2015 um 14:30 schrieb Andy Lutomirski:
> +static void vring_unmap_one(const struct vring_virtqueue *vq,
> + struct vring_desc *desc)
> +{
> + u16 flags = virtio16_to_cpu(vq->vq.vdev, desc->flags);
> +
> + if (flags & VRING_DESC_F_INDIRECT) {
> +
From: David Hildenbrand <d...@linux.vnet.ibm.com>
No need to separate pending and floating irqs when setting interception
requests. Let's do it for all equally.
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.
the float int structure is no longer used in __inject_vm.
Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
arch/s390/kvm/interrupt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/s390/kvm/interrupt.c b/a
fering VCPUs with different TODs.
Acked-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
arch/s390/kvm/kvm-s390.c | 28 +---
arch/
From: David Hildenbrand <d...@linux.vnet.ibm.com>
Let's get rid of the local variable and exit directly if we found
any pending interrupt. This is not only faster, but also better
readable.
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hi
is important enough to qualify for 4.3 or
stable.
Christian Borntraeger (1):
KVM: s390: remove unused variable in __inject_vm
David Hildenbrand (9):
KVM: s390: disabled wait cares about machine checks, not PER
KVM: s390
From: David Hildenbrand <d...@linux.vnet.ibm.com>
We can remove that double check.
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
a
P sync (using preempt_disable() logic).
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
arch/s390/kvm/interrupt.c | 15 +++
arch/s
esting once again for magic bits.
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
arch/s390/kvm/interrupt.c | 8 +++-
1 file changed, 3 in
an now also easily move the get_tod_clock() call into the
preempt_disable() section. This is in fact necessary to make the
STP sync work as expected. Otherwise the host TOD could change
and we would end up with a wrong epoch calculation.
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
viewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
---
arch/s390/kvm/interrupt.c | 21 -
1 file changed, 20 insertions(+), 1 deleti
e dropped as they are implicitely given by
kvm_s390_inject_vcpu(), to avoid ugly long function prototypes.
Reviewed-by: Jens Freimann <jf...@linux.vnet.ibm.com>
Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com>
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-o
Am 18.09.2015 um 13:29 schrieb Paolo Bonzini:
>
>
> On 18/09/2015 12:54, Christian Borntraeger wrote:
>>> -/* halt polling only reduces halt latency by 5-7 us, 500us is enough */
>>> -static unsigned int halt_poll_ns = 50;
>>> +/* Architectures shou
than
sorry as we dont want to rely on the implementation of
macros. Opinions?
Christian Borntraeger (1):
macvtap: Fix regression for macvtap ioctls
drivers/net/macvtap.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
--
2.3.0
--
To unsubscribe from this list: send the line "
net>
Reported-by: Mark A. Peloquin
Bisected-by: Matthew Rosato <mjros...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
Fixes: 39ec7de7092b ("macvtap: fix uninitialized access on TUNSETIFF")
Cc: sta...@vger.kernel.org
---
drivers/net/macvtap.c
> latency */
> +static unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
Yes, I prefer this over disabling it via Kconfig. There are benchmarks which
benefit from polling on s390. Furthermore it seems that the latency
strongly depends on timing of the architecture so making it per arch
Am 18.09.2015 um 13:29 schrieb Paolo Bonzini:
>
>
> On 18/09/2015 12:54, Christian Borntraeger wrote:
>>> -/* halt polling only reduces halt latency by 5-7 us, 500us is enough */
>>> -static unsigned int halt_poll_ns = 50;
>>> +/* Architectures shou
Am 16.09.2015 um 10:32 schrieb Paolo Bonzini:
>
>
> On 15/09/2015 19:38, Paul E. McKenney wrote:
>> Excellent points!
>>
>> Other options in such situations include the following:
>>
>> oRework so that the code uses call_rcu*() instead of *_expedited().
>>
>> oMaintain a per-task or
Am 16.09.2015 um 03:24 schrieb Tejun Heo:
> Hello, Paul.
>
> On Tue, Sep 15, 2015 at 04:38:18PM -0700, Paul E. McKenney wrote:
>> Well, the decision as to what is too big for -stable is owned by the
>> -stable maintainers, not by me.
>
> Is it tho? Usually the subsystem maintainer knows the
Am 16.09.2015 um 13:03 schrieb Tejun Heo:
> Hello,
>
> On Wed, Sep 16, 2015 at 12:58:00PM +0200, Christian Borntraeger wrote:
>> FWIW, I added a printk to percpu_down_write. With KVM and uprobes disabled,
>> just booting up a fedora20 gives me __6749__ percpu_down_write cal
gt; attempted polling compared to the successful polls.
>
> Cc: Christian Borntraeger <borntrae...@de.ibm.com<
> Cc: David Matlack <dmatl...@google.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Acked-by: Christian Borntraeger <borntrae...@de.ibm.com&g
Am 16.09.2015 um 09:44 schrieb Christian Borntraeger:
> Am 16.09.2015 um 03:24 schrieb Tejun Heo:
>> Hello, Paul.
>>
>> On Tue, Sep 15, 2015 at 04:38:18PM -0700, Paul E. McKenney wrote:
>>> Well, the decision as to what is too big for -stable is owned by the
>
Am 16.09.2015 um 14:22 schrieb Oleg Nesterov:
>> The issue is that rcu_sync doesn't eliminate synchronize_sched,
>
> Yes, but it eliminates _expedited(). This is good, but otoh this means
> that (say) individual __cgroup_procs_write() can take much more time.
> However, it won't block the
he incorrect atomic_or with atomic_andnot
>
> Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntrae...@de.ibm.com>
Paolo,
can you take this via kvm tree for 4.3?
Maybe move the subject line into the mail body an rephrase the subject li
Both patches in combination
Tested-by: Christian Borntraeger <borntrae...@de.ibm.com> # on top of 4.3-rc1
As a side note, patch 2 does not apply cleanly on 4.2, so we probably need to
provide a separate backport.
Christian
--
To unsubscribe from this list: send the line "unsu
This patch fix it by reset vcpu->halt_poll_ns in order to stop polling
> when polling is disabled.
>
> Reported-by: Christian Borntraeger <borntrae...@de.ibm.com>
> Signed-off-by: Wanpeng Li <wanpeng...@hotmail.com>
> ---
> virt/kvm/kvm_main.c | 3 ++-
> 1 file chan
Tejun,
commit d59cfc09c32a2ae31f1c3bc2983a0cd79afb3f14 (sched, cgroup: replace
signal_struct->group_rwsem with a global percpu_rwsem) causes some noticably
hickups when starting several kvm guests (which libvirt will move into cgroups
- each vcpu thread and each i/o thread)
When you now start
Am 15.09.2015 um 18:42 schrieb Paolo Bonzini:
>
>
> On 15/09/2015 15:36, Christian Borntraeger wrote:
>> I am wondering why the old code behaved in such fatal ways. Is there
>> some interaction between waiting for a reschedule in the
>> synchronize_sched writer
Am 15.09.2015 um 15:05 schrieb Peter Zijlstra:
> On Tue, Sep 15, 2015 at 02:05:14PM +0200, Christian Borntraeger wrote:
>> Tejun,
>>
>>
>> commit d59cfc09c32a2ae31f1c3bc2983a0cd79afb3f14 (sched, cgroup: replace
>> signal_struct->group_rwsem with a global
Am 10.09.2015 um 03:55 schrieb Wanpeng Li:
> On 9/9/15 9:39 PM, Christian Borntraeger wrote:
>> Am 03.09.2015 um 16:07 schrieb Wanpeng Li:
>>> v6 -> v7:
>>> * explicit signal (set a bool)
>>> * fix the tracepoint
>>>
>>> v5 -> v6:
&
Am 10.09.2015 um 06:02 schrieb Stephen Rothwell:
> Hi all,
>
> Please do not add material for v4.4 until after v4.3-rc1 is out.
>
[...]
> The kvm tree still had its build failure for which I reverted a commit.
[..]
> Merging kvm/linux-next (2cbd78244fb2 KVM: trace kvm_halt_poll_ns grow/shrink)
>
Am 03.09.2015 um 16:07 schrieb Wanpeng Li:
> v6 -> v7:
> * explicit signal (set a bool)
> * fix the tracepoint
>
> v5 -> v6:
> * fix wait_ns and poll_ns
>
> v4 -> v5:
> * set base case 10us and max poll time 500us
> * handle short/long halt, idea from David, many thanks David
>
> v3 ->
Am 08.09.2015 um 08:05 schrieb Thomas Huth:
> On 07/09/15 16:31, Igor Mammedov wrote:
>> On Fri, 4 Sep 2015 12:04:41 +0200
>> Alexander Graf <ag...@suse.de> wrote:
>>
>>>
>>>
>>> On 04.09.15 11:59, Christian Borntraeger wrote:
>>>&g
Am 04.09.2015 um 11:35 schrieb Thomas Huth:
>
> Hi all,
>
> now that we get memory hotplugging for the spapr machine on qemu-ppc,
> too, it seems like we easily can hit the amount of KVM-internal memory
> slots now ("#define KVM_USER_MEM_SLOTS 32" in
> arch/powerpc/include/asm/kvm_host.h). For
Am 04.09.2015 um 11:35 schrieb Thomas Huth:
>
> Hi all,
>
> now that we get memory hotplugging for the spapr machine on qemu-ppc,
> too, it seems like we easily can hit the amount of KVM-internal memory
> slots now ("#define KVM_USER_MEM_SLOTS 32" in
> arch/powerpc/include/asm/kvm_host.h). For
Am 04.09.2015 um 12:04 schrieb Alexander Graf:
>
>
> On 04.09.15 11:59, Christian Borntraeger wrote:
>> Am 04.09.2015 um 11:35 schrieb Thomas Huth:
>>>
>>> Hi all,
>>>
>>> now that we get memory hotplugging for the spapr machine on qemu-ppc,
Am 04.09.2015 um 12:04 schrieb Alexander Graf:
>
>
> On 04.09.15 11:59, Christian Borntraeger wrote:
>> Am 04.09.2015 um 11:35 schrieb Thomas Huth:
>>>
>>> Hi all,
>>>
>>> now that we get memory hotplugging for the spapr machine on qemu-ppc,
Am 14.08.2015 um 12:08 schrieb Radim Krčmář:
> v3:
> * acked by Christian [1/5]
> * use ioctl argument directly (unsigned long as flags) [4/5]
> * precisely #ifdef arch-specific ioctls [5/5]
> v2:
> * move request_exits debug counter patch right after introduction of
>KVM_REQ_EXIT [3/5]
>
Am 13.08.2015 um 11:29 schrieb Paolo Bonzini:
On 13/08/2015 11:11, Radim Krčmář wrote:
for the new interface. maybe we can rename kvm_check_request in a separate
patch somewhen.
I wonder why haven't we copied the naming convention from bit operations
(or if programming would be better if
Paolo,
the following changes since commit c92ea7b9f7d256cabf7ee08a7627a5227e356dec:
KVM: s390: log capability enablement and vm attribute changes (2015-07-29
11:02:36 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
preemption).
Signed-off-by: Fan Zhang zhang...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com
Acked-by: Martin Schwidefsky schwidef...@de.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch
and incorrectly making the caller of kvm_arch_vm_ioctl think
the function has run successfully.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
Message-Id: 1438880754-27149-1-git-send-email-xerofo...@gmail.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/kvm
Am 05.08.2015 um 18:32 schrieb Radim Krčmář:
We want to have requests abstracted from bit operations.
Signed-off-by: Radim Krčmář rkrc...@redhat.com
---
kvm_check_request is now somewhat a misnomer (what is the difference between
test and check?)
but still
Acked-by: Christian Borntraeger
Am 05.08.2015 um 18:33 schrieb Radim Krčmář:
I find the switch easier to read and modify.
yes.
Signed-off-by: Radim Krčmář rkrc...@redhat.com
---
v2: new
virt/kvm/kvm_main.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/virt/kvm/kvm_main.c
Am 06.08.2015 um 19:05 schrieb Nicholas Krause:
This fixes the assumption that kvm_set_irq_routing is always run
successfully by instead making it equal to the variable r which
we use for returning in the function kvm_arch_vm_ioctl instead
of making r equal to zero when calling this particular
Am 30.07.2015 um 13:38 schrieb Paolo Bonzini:
On 30/07/2015 13:22, Christian Borntraeger wrote:
static int kvm_s390_handle_requests(struct kvm_vcpu *vcpu)
{
-if (!vcpu-requests)
-return 0;
retry:
kvm_s390_vcpu_request_handled(vcpu);
+if (!vcpu-requests
Am 30.07.2015 um 16:02 schrieb Paolo Bonzini:
On 30/07/2015 15:57, Christian Borntraeger wrote:
+/* Pairs with smp_wmb() in kvm_vm_ioctl_create_vcpu, in case
+ * the caller has read kvm-online_vcpus before (as is the case
+ * for kvm_for_each_vcpu, for example
Am 29.07.2015 um 15:28 schrieb Paolo Bonzini:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/linux/kvm_host.h | 4
virt/kvm/kvm_main.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index
Am 30.07.2015 um 14:46 schrieb Paolo Bonzini:
On 30/07/2015 13:40, Christian Borntraeger wrote:
+ /* Pairs with smp_wmb() in kvm_vm_ioctl_create_vcpu, in case
+ * the caller has read kvm-online_vcpus before (as is the case
+ * for kvm_for_each_vcpu, for example).
+ */
smp_rmb
.
Christian Borntraeger (1):
KVM: s390: Fix hang VCPU hang/loop regression
arch/s390/kvm/kvm-s390.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord
to
unblock itself (although no bit is set). When the requester wakes up,
it blocks the VCPU and we have a blocked VCPU without requests.
Solution is to always unset the block bit.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Depending on user space, some capabilities and vm attributes are
enabled at runtime. Let's log those events and while we're at it,
log querying the vm attributes as well.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/kvm-s390.c | 19 +++
1 file
.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
---
arch/s390/kvm/interrupt.c | 1 -
arch/s390/kvm/kvm-s390.h | 2 ++
arch/s390/kvm/priv.c | 2 --
arch/s390/kvm/sigp.c
into the real
injection function, as already done for the other injection functions.
Reviewed-by: Jens Freimann jf...@linux.vnet.ibm.com
Acked-by: Cornelia Huck cornelia.h...@de.ibm.com
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
is called inject
- use log level 3 for state changing and/or seldom events (like machine
checks, restart..)
- use log level 4 for frequent events
- use 0x prefix for hex numbers
- add pfault done logging
- move some tracing outside spinlock
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
From: Dominik Dingel din...@linux.vnet.ibm.com
As enabling storage keys might fail, we should forward the error.
Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/kvm-s390.c | 4 +++-
1 file changed, 3
Sometimes kvm stat counters are the only performance metric to check
after something went wrong. Let's add additional counters for some
diagnoses.
In addition do the count for diag 10 all the time, even if we inject
a program interrupt.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
We're not only interested in the address of the control block, but
also in the requested subcommand and for the token subcommand, in the
specified token address and masks.
Suggested-by: Cornelia Huck cornelia.h...@de.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed
Use the default log level 3 for state changing and/or seldom events,
use 4 for others. Also change some numbers from %x to %d and vice versa
to match documentation. If hex, let's prepend the numbers with 0x.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Acked-by: Cornelia Huck
The old Documentation/s390/kvm.txt file is either
outdated or described in Documentation/virtual/kvm/api.txt.
Let's get rid of it.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
---
Documentation/s390/00-INDEX | 2
-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/interrupt.c | 3 +--
arch/s390/kvm/trace-s390.h | 22 --
include/uapi/linux/kvm.h | 1 +
3 files changed, 18 insertions(+), 8 deletions(-)
diff
. Fix gdb debugging and single stepping on some instructions
4. Error handling for storage key setup
Christian Borntraeger (10):
KVM: s390: add kvm stat counter for all diagnoses
KVM: s390: Improve vcpu event debugging
In addition to the per VM debug logs, let's provide a global
one for KVM-wide events, like new guests or fatal errors.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
---
arch/s390/include/asm/kvm_host.h | 1 -
arch/s390/kvm/kvm
-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/guestdbg.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c
index e97b345..47518a3
Let's add a vcpu event for the page reference handling and change
the default debugging level for the ipl diagnose. Both are not
frequent AND change the global state, so lets log them always.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/diag.c | 4 +++-
1 file
...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/kvm-s390.c | 21 +++--
arch/s390/kvm/kvm-s390.h | 2 --
arch/s390/kvm/priv.c | 2 +-
3 files changed, 8 insertions(+), 17
From: Dominik Dingel din...@linux.vnet.ibm.com
There is no point in resetting the CMMA state if it was never enabled.
Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
We do not use the exception logger, so the 2nd area is unused.
Just have one area that is bigger (32 pages).
At the same time we can limit the debug feature size to 7
longs, as the largest user has 3 parameters + string + boiler
plate (vCPU, PSW mask, PSW addr)
Signed-off-by: Christian
Am 16.07.2015 um 23:26 schrieb Alex Williamson:
When a physical I/O device is assigned to a virtual machine through
facilities like VFIO and KVM, the interrupt for the device generally
bounces through the host system before being injected into the VM.
However, hardware technologies exist that
Am 01.07.2015 um 17:15 schrieb Cornelia Huck:
The s390-specific virtio drivers have probably more to do with virtio
than with kvm today; let's move them out into a separate section to
reflect this and to be able to add relevant mailing lists.
CC: Christian Borntraeger borntrae...@de.ibm.com
...@linux.vnet.ibm.com
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com
Reviewed-by: Eric Farman far...@linux.vnet.ibm.com
Tested-by: Eric Farman far...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Cc: sta...@vger.kernel.org
---
drivers/s390/kvm/virtio_ccw.c | 11
Paolo,
here is fix targetted for kvm/master (4.2) that fixes an issue with
virtio config space on s390. It mostly manifests in vhost-scsi
not working properly on s390. The problem itself might affect other
things as well so cc stable/target 4.2.
@Michael FYI, sending this via Paolo as most
even after a reset. Let's fix this by clearing the pending bitmap
and the parameters for service and machine check interrupts.
Cc: sta...@vger.kernel.org # 4.1
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm
Paolo,
here is a small fixup for KVM on s390. It is also necessary for
4.1 which I am a bit late for - so cc stable.
No pull request as it is only one patch.
Jens Freimann (1):
KVM: s390: clear floating interrupt bitmap and parameters
arch/s390/kvm/interrupt.c | 3 +++
1 file changed, 3
Paolo,
one fix and one cleanup for 4.2.
The following changes since commit 06b36753a6466239fc945b6756e12d635621ae5f:
KVM: s390: drop handling of interception code 12 (2015-05-08 15:51:17 +0200)
are available in the git repository at:
directly when setting
the other magic block bits in the SIE.
Otherwise e.g. kvm_s390_set_tod_low() still has other VCPUs running
after that call, working with a wrong epoch.
Fixes: 27406cd50c (KVM: s390: provide functions for blocking all CPUs)
Acked-by: Christian Borntraeger borntrae
From: David Hildenbrand d...@linux.vnet.ibm.com
Let's remove kvm-s390 from our printk messages and make use
of pr_fmt instead.
Also replace one printk() occurrence by a equivalent pr_warn
on the way.
Suggested-by: Christian Borntraeger borntrae...@de.ibm.com
Signed-off-by: David Hildenbrand d
Am 01.06.2015 um 13:34 schrieb Paolo Bonzini:
On 01/06/2015 09:47, Christian Borntraeger wrote:
1: disable, guest, disable again and save, restore to disable,
enable
and now it is
2: disable, guest, enable
and with your patch it is
3: disable, guest, enable, disable, enable
I assume
that with interrupts
disabled.
Signed-off-by: Christoffer Dall christoffer.d...@linaro.org
---
This patch is based on kvm/queue, because it has the kvm_guest_enter/exit
rework recently posted by Christian Borntraeger. I hope I got the logic
of this right, there were 2 slightly worrying facts about
Am 01.06.2015 um 11:08 schrieb Christoffer Dall:
Second, looking at the ppc and mips code, they seem to also call
kvm_guest_exit() before enabling interrupts, so I don't understand how
guest CPU time accounting works on those architectures.
Not an expert here, but I assume mips has the same
Am 01.06.2015 um 15:35 schrieb Christoffer Dall:
On Mon, Jun 01, 2015 at 11:21:19AM +0200, Christian Borntraeger wrote:
Am 01.06.2015 um 11:08 schrieb Christoffer Dall:
Second, looking at the ppc and mips code, they seem to also call
kvm_guest_exit() before enabling interrupts, so I don't
instruction.
- If an external call is already pending, -EBUSY will not be reported.
Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: Jens Freimann jf...@linux.vnet.ibm.com
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: sta...@vger.kernel.org # v4.0
Signed-off
Am 11.05.2015 um 13:45 schrieb Paolo Bonzini:
On 11/05/2015 13:25, Joerg Roedel wrote:
It probably doesn't matter much indeed, but can you time the difference?
kvm_set_irq_routing is not too frequent, but happens enough often that
we had to use a separate SRCU instance just to speed it up
This rework allows to avoid some cycles by not disabling interrupts
twice.
Christian Borntraeger (2):
KVM: provide irq_unsafe kvm_guest_{enter|exit}
KVM: arm/mips/x86/power use __kvm_guest_{enter|exit}
arch/arm/kvm/arm.c | 4 ++--
arch/mips/kvm/mips.c | 4 ++--
arch/powerpc
Am 30.04.2015 um 14:02 schrieb Christian Borntraeger:
Am 30.04.2015 um 14:01 schrieb Christian Borntraeger:
Am 30.04.2015 um 13:50 schrieb Paolo Bonzini:
On 30/04/2015 13:43, Christian Borntraeger wrote:
+/* must be called with irqs disabled */
+static inline void __kvm_guest_enter(void
Am 30.04.2015 um 13:50 schrieb Paolo Bonzini:
On 30/04/2015 13:43, Christian Borntraeger wrote:
+/* must be called with irqs disabled */
+static inline void __kvm_guest_enter(void)
{
-unsigned long flags;
-
-BUG_ON(preemptible());
Please keep the BUG_ON() in kvm_guest_enter
Am 30.04.2015 um 13:50 schrieb Paolo Bonzini:
On 30/04/2015 13:43, Christian Borntraeger wrote:
+/* must be called with irqs disabled */
+static inline void __kvm_guest_enter(void)
{
-unsigned long flags;
-
-BUG_ON(preemptible());
Please keep the BUG_ON() in kvm_guest_enter
Am 30.04.2015 um 14:01 schrieb Christian Borntraeger:
Am 30.04.2015 um 13:50 schrieb Paolo Bonzini:
On 30/04/2015 13:43, Christian Borntraeger wrote:
+/* must be called with irqs disabled */
+static inline void __kvm_guest_enter(void)
{
- unsigned long flags;
-
- BUG_ON(preemptible
Am 30.04.2015 um 14:40 schrieb Paolo Bonzini:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com
but no way to test it
---
arch/powerpc/kvm/booke.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch
Am 30.04.2015 um 14:40 schrieb Paolo Bonzini:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com
but no way to test it
---
arch/powerpc/kvm/booke.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch
Am 28.04.2015 um 13:37 schrieb Paolo Bonzini:
--- a/arch/powerpc/kvm/book3s_pr.c
+++ b/arch/powerpc/kvm/book3s_pr.c
@@ -891,7 +891,9 @@ int kvmppc_handle_exit_pr(struct kvm_run *run, struct
kvm_vcpu *vcpu,
/* We get here with MSR.EE=1 */
+local_irq_disable();
Am 28.04.2015 um 13:37 schrieb Paolo Bonzini:
--- a/arch/powerpc/kvm/book3s_pr.c
+++ b/arch/powerpc/kvm/book3s_pr.c
@@ -891,7 +891,9 @@ int kvmppc_handle_exit_pr(struct kvm_run *run, struct
kvm_vcpu *vcpu,
/* We get here with MSR.EE=1 */
+local_irq_disable();
do
the right thing in the callers.
Is that approach acceptible? Does anybody else see some measurable
difference for guest exits?
Christian Borntraeger (2):
KVM: Push down irq_save to architectures before kvm_guest_enter
KVM: push down irq_save from kvm_guest_exit
arch/powerpc/kvm
do
the right thing in the callers.
Is that approach acceptible? Does anybody else see some measurable
difference for guest exits?
Christian Borntraeger (2):
KVM: Push down irq_save to architectures before kvm_guest_enter
KVM: push down irq_save from kvm_guest_exit
arch/powerpc/kvm
adoptions.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/powerpc/kvm/book3s_hv.c | 2 ++
arch/powerpc/kvm/book3s_pr.c | 2 ++
arch/powerpc/kvm/booke.c | 4 ++--
arch/s390/kvm/kvm-s390.c | 2 ++
arch/x86/kvm/x86.c | 2 ++
include/linux/kvm_host.h | 4
6
101 - 200 of 1075 matches
Mail list logo
