[PATCH 8/8] KVM: s390: Intercept SCK instruction

2013-09-12 Thread Christian Borntraeger
...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/priv.c | 33 + 1 file changed, 33 insertions(+) diff --git a/arch/s390/kvm/priv.c b/arch/s390/kvm/priv.c index 6f95994..2440602 100644 --- a/arch/s390/kvm/priv.c +++ b/arch

[PATCH 6/8] KVM: s390: Helper for converting real addresses to absolute

2013-09-12 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com Added a separate helper function that translates guest real addresses to guest absolute addresses by applying the prefix of the guest CPU. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com

[PATCH 2/8] KVM: s390: Split up __vcpu_run into three parts

2013-09-12 Thread Christian Borntraeger
and the other one handles the code that runs afterwards. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 54 +--- 1 file changed, 37 insertions(+), 17 deletions

[PATCH 4/8] KVM: s390: Lock kvm-srcu at the appropriate places

2013-09-12 Thread Christian Borntraeger
ioctl, which can be called out-of-band and needs a separate lock). Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/diag.c | 4 +--- arch/s390/kvm/interrupt.c | 3 +++ arch/s390/kvm/kvm-s390.c | 12 3

Re: [PATCH 2/8] KVM: s390: Split up __vcpu_run into three parts

2013-09-12 Thread Christian Borntraeger
On 12/09/13 10:59, Paolo Bonzini wrote: Il 12/09/2013 10:33, Christian Borntraeger ha scritto: vcpu-arch.sie_block-icptcode = 0; -VCPU_EVENT(vcpu, 6, entering sie flags %x, - atomic_read(vcpu-arch.sie_block-cpuflags)); -trace_kvm_s390_sie_enter(vcpu

Re: [PATCH 1/2] linux-headers: update for s390 floating interrupt controller

2013-09-06 Thread Christian Borntraeger
On 06/09/13 14:19, Jens Freimann wrote: Add symbols required for the s390 floating interrupt controller (flic) Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com As Peter said, this should come via a sync, but you already mentioned that in your cover-letter. I will Ack the kernel patch and

Re: [PATCH v2 1/2] KVM: s390: add and extend interrupt information data structs

2013-09-06 Thread Christian Borntraeger
...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/include/asm/kvm_host.h | 34 +- include/uapi/linux/kvm.h | 63 2 files changed

Re: [PATCH v2 2/2] KVM: s390: add floating irq controller

2013-09-06 Thread Christian Borntraeger
-by: Jens Freimann jf...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com --- Documentation/virtual/kvm/devices/s390_flic.txt | 36 +++ arch/s390/include/asm/kvm_host.h| 1 + arch/s390/include/uapi/asm

Re: [PATCH 2/2] s390x/kvm: implement floating-interrupt controller device

2013-09-06 Thread Christian Borntraeger
into the kernel (used for migration) Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com --- default-configs/s390x-softmmu.mak | 1 + hw/intc/Makefile.objs | 1

Re: [PATCH v2 0/2] KVM: s390: add floating irq controller

2013-09-06 Thread Christian Borntraeger
On 06/09/13 14:19, Jens Freimann wrote: This series adds a kvm_device that acts as a irq controller for floating interrupts. As a first step it implements functionality to retrieve and inject interrupts for the purpose of migration and for hardening the reset code by allowing user space to

[PATCH 3/8] KVM: s390: allow sie enablement for multi-threaded programs

2013-07-26 Thread Christian Borntraeger
From: Martin Schwidefsky schwidef...@de.ibm.com Improve the code to upgrade the standard 2K page tables to 4K page tables with PGSTEs to allow the operation to happen when the program is already multi-threaded. Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian

[PATCH 1/8] KVM: s390: move kvm_guest_enter,exit closer to sie

2013-07-26 Thread Christian Borntraeger
-by: Christian Borntraeger borntrae...@de.ibm.com CC: sta...@vger.kernel.org --- arch/s390/kvm/kvm-s390.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index a3d797b..39894aa 100644 --- a/arch/s390/kvm/kvm

[PATCH 0/8] KVM: s390: fixes and cleanup

2013-07-26 Thread Christian Borntraeger
Gleb, Paolo, here are some fixes and cleanups for KVM/s390. The first two patches KVM: s390: move kvm_guest_enter,exit closer to sie and KVM: s390: fix pfmf non-quiescing control handling should go into 3.11. Everything else looks more like 3.12. Please apply. Christian Dominik Dingel (2):

[PATCH 2/8] KVM: s390: fix pfmf non-quiescing control handling

2013-07-26 Thread Christian Borntraeger
-setting facility installed. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/priv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/kvm

[PATCH 4/8] KVM: s390: fix task size check

2013-07-26 Thread Christian Borntraeger
values (4TB vs 8PB) dependent on the existance of the fourth page table level, create a new define 'TASK_MAX_SIZE' for (1UL 53). Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/include/asm/processor.h | 2 ++ arch

[PATCH 8/8] KVM: s390: Make KVM_HVA_ERR_BAD usable on s390

2013-07-26 Thread Christian Borntraeger
KVM_HVA_ERR_BAD defines. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/include/asm/kvm_host.h | 8 include/linux/kvm_host.h | 8 2 files changed, 16 insertions(+) diff --git a/arch/s390/include

[PATCH 6/8] KVM: s390: Fix sparse warnings in priv.c

2013-07-26 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com sparse complained about the missing UL postfix for long constants. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Acked-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/priv.c

[PATCH 5/8] KVM: s390: declare virtual HW facilities

2013-07-26 Thread Christian Borntraeger
test for virtual facilites has been added as well. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 23 +++ arch/s390/kvm/kvm-s390.h | 3 +++ arch/s390/kvm/priv.c | 11

[PATCH 7/8] KVM: s390: Add helper function for setting condition code

2013-07-26 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com Introduced a helper function for setting the CC in the guest PSW to improve the readability of the code. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.h | 7

Re: [RFC][PATCH 0/2] s390/kvm: add kvm support for guest page hinting v2

2013-07-25 Thread Christian Borntraeger
On 25/07/13 10:54, Martin Schwidefsky wrote: v1-v2: - found a way to simplify the common code patch Linux on s390 as a guest under z/VM has been using the guest page hinting interface (alias collaborative memory management) for a long time. The full version with volatile states has been

Re: [PATCH 1/2] mm: add support for discard of unused ptes

2013-07-25 Thread Christian Borntraeger
one for swap in. [ Martin Schwidefsky: patch reordering and simplification ] Signed-off-by: Konstantin Weitz konstantin.we...@gmail.com Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com --- include/asm-generic/pgtable.h

Re: [PATCH 2/2] s390/kvm: support collaborative memory management

2013-07-25 Thread Christian Borntraeger
Borntraeger borntrae...@de.ibm.com Tested-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/include/asm/kvm_host.h |5 ++- arch/s390/include/asm/pgtable.h | 24 arch/s390/kvm/kvm-s390.c | 25 + arch/s390/kvm/kvm-s390.h |2

Re: KVM call agenda for 2013-07-30

2013-07-23 Thread Christian Borntraeger
On 23/07/13 08:33, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. - soft reset and other reset variants. What is the right way to go? (e.g. on s390 there are several reset variants that reset a defined subset of the system. This can be triggered by

Re: [PATCH 4/4] PF: Async page fault support on s390

2013-07-18 Thread Christian Borntraeger
On 18/07/13 15:57, Paolo Bonzini wrote: Il 11/07/2013 12:41, Christian Borntraeger ha scritto: On 11/07/13 11:04, Gleb Natapov wrote: On Wed, Jul 10, 2013 at 02:59:55PM +0200, Dominik Dingel wrote: This patch enables async page faults for s390 kvm guests. It provides the userspace API

Re: [PATCH 4/4] PF: Async page fault support on s390

2013-07-11 Thread Christian Borntraeger
On 11/07/13 11:04, Gleb Natapov wrote: On Wed, Jul 10, 2013 at 02:59:55PM +0200, Dominik Dingel wrote: This patch enables async page faults for s390 kvm guests. It provides the userspace API to enable, disable or get the status of this feature. Also it includes the diagnose code, called by the

Re: [PATCH 4/4] PF: Async page fault support on s390

2013-07-10 Thread Christian Borntraeger
On 09/07/13 15:56, Dominik Dingel wrote: This patch enables async page faults for s390 kvm guests. It provides the userspace API to enable, disable or get the status of this feature. Also it includes the diagnose code, called by the guest to enable async page faults. The async page faults

Re: [RFC PATCH v2 1/2] KVM: s390: virtio-ccw: Handle command rejects.

2013-07-10 Thread Christian Borntraeger
cornelia.h...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com --- drivers/s390/kvm/virtio_ccw.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c index 779dc51..d6c7aba 100644

Re: [PATCH 3/4] PF: Provide additional direct page notification

2013-07-10 Thread Christian Borntraeger
On 10/07/13 12:39, Alexander Graf wrote: On 09.07.2013, at 18:01, Christian Borntraeger wrote: On 09/07/13 15:56, Dominik Dingel wrote: By setting a Kconfig option, the architecture can control when guest notifications will be presented by the apf backend. So there is the default batch

Re: [RFC PATCH v2] s390/virtio-ccw: Adapter interrupt support.

2013-07-09 Thread Christian Borntraeger
the interface. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/4] PF: Add FAULT_FLAG_RETRY_NOWAIT for guest fault

2013-07-09 Thread Christian Borntraeger
on a patch from Martin Schwidefsky. For that we will obviously need Christian and Cornelia ACKs. Or it can go in via S390 tree. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com Do you want me or Conny to apply these patches add

Re: [PATCH 3/4] PF: Provide additional direct page notification

2013-07-09 Thread Christian Borntraeger
hand there is now the direct mechanism, this will directly push the information to the guest. Still the vcpu thread should call check_completion to cleanup leftovers, that leaves most of the common code untouched. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com Acked-by: Christian

Re: [PATCH] KVM: s390: Add devname:kvm alias.

2013-05-28 Thread Christian Borntraeger
On 28/05/13 11:00, Paolo Bonzini wrote: Looks good for 3.10. Should I take this since Alex is on holiday, or should I wait for him to come back? let me refer to http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/104230 ;-) Christian -- To unsubscribe from this list: send the line

[PATCH 5/8] s390/kvm: Provide a way to prevent reentering SIE

2013-05-17 Thread Christian Borntraeger
. So lets provide a bit in a private field of the sie control block that acts as a gate keeper, after we claimed we are in SIE. Please note that we do not reuse prog0c, since we want to access that bit without atomic ops. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Acked-by: Martin

[PATCH 1/8] s390/pgtable: fix ipte notify bit

2013-05-17 Thread Christian Borntraeger
Dont use the same bit as user referenced. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/include/asm/pgtable.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index 4105b82

[PATCH 3/8] s390/kvm: rename RCP_xxx defines to PGSTE_xxx

2013-05-17 Thread Christian Borntraeger
better names as well. Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/include/asm/pgtable.h | 82 - arch/s390/mm/pgtable.c | 2 +- 2 files changed, 40 insertions

[PATCH 6/8] s390/kvm: Kick guests out of sie if prefix page host pte is touched

2013-05-17 Thread Christian Borntraeger
to kick guest cpus out of SIE. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Acked-by: Martin Schwidefsky schwidef...@de.ibm.com --- arch/s390/include/asm/pgtable.h | 1 + arch/s390/kvm/intercept.c | 39 ++-- arch/s390/kvm/kvm-s390.c| 49

[PATCH 8/8] s390: fix gmap_ipte_notifier vs. software dirty pages

2013-05-17 Thread Christian Borntraeger
become read-only (and only software writable) if the page is clean. Since we loop in this code, the page would stay clean and, therefore, be never writable again. Let us just use fixup_user_fault, that guarantees to call handle_mm_fault. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com

[PATCH 4/8] s390/kvm: Mark if a cpu is in SIE

2013-05-17 Thread Christian Borntraeger
Lets track in a private bit if the sie control block is active. We want to track this as closely as possible, so we also have to instrument the interrupt and program check handler. Lets use the existing HANDLE_SIE_INTERCEPT macro. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Acked

[PATCH 2/8] s390/kvm: fix psw rewinding in handle_skey

2013-05-17 Thread Christian Borntraeger
From: Martin Schwidefsky schwidef...@de.ibm.com The PSW can wrap if the guest has been running in the 24 bit or 31 bit addressing mode. Use __rewind_psw to find the correct address. Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae

[PATCH 0/8] s390/kvm fixes

2013-05-17 Thread Christian Borntraeger
on s390 we have seen very long RCU stalls due to SIE not exiting on interrupts. Instead of returning to SIE, we now force an exit into the kvm module, which then does the guest exit/enter magic, fixing rcu. The whole bunch is probably too complex for 3.10, so please queue for 3.11 Christian

[PATCH 7/8] s390/kvm: avoid automatic sie reentry

2013-05-17 Thread Christian Borntraeger
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kernel/entry64.S | 76 -- arch/s390/kvm/kvm-s390.c | 4 ++- 2 files changed, 36 insertions(+), 44 deletions(-) diff --git a/arch/s390/kernel/entry64.S b/arch/s390/kernel

Re: [PATCH v3 2/2] KVM: get rid of $(addprefix ../../../virt/kvm/, ...) in Makefiles

2013-05-16 Thread Christian Borntraeger
: Christoffer Dall cd...@cs.columbia.edu Acked-by: Xiantao Zhang xiantao.zh...@intel.com Cc: Tony Luck tony.l...@intel.com Cc: Fenghua Yu fenghua...@intel.com Cc: Alexander Graf ag...@suse.de Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Christian Borntraeger borntrae...@de.ibm.com s390

[PATCH] [RFC] s390/kvm: note a quiescing state if we interupt guest mode

2013-05-02 Thread Christian Borntraeger
state similar to user space as an extended grace period, but this is not ready yet. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Dipankar Sarma dipan...@in.ibm.com Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Martin Schwidefsky

Re: [PATCH] [RFC] s390/kvm: note a quiescing state if we interupt guest mode

2013-05-02 Thread Christian Borntraeger
On 02/05/13 17:09, Paul E. McKenney wrote: On Thu, May 02, 2013 at 10:09:52AM +0200, Christian Borntraeger wrote: The SIE instruction is interruptible, so instead of having a guest exit on a host interrupt we basically return to guest mode. We have some logic in the interrupt handler to check

[PATCH 1/8] s390/kvm,gaccess: fix guest access return code handling

2013-03-05 Thread Christian Borntraeger
to -EFAULT. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/gaccess.h | 7 +-- 1 file

[PATCH 3/8] s390/kvm,tprot: use new gmap_translate() function

2013-03-05 Thread Christian Borntraeger
address whithout the chance of running into an out-of-memory situation. Also make it more explicit that for -EFAULT we won't find a vma. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Martin Schwidefsky schwidef

[PATCH 8/8] s390/kvm,gaccess: add address space annotations

2013-03-05 Thread Christian Borntraeger
From: Heiko Carstens heiko.carst...@de.ibm.com Add missing address space annotations to all put_guest()/get_guest() callers. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com Acked-by: Martin Schwidefsky schwidef...@de.ibm.com Signed

[PATCH 4/8] s390/kvm: remove explicit -EFAULT return code checking on guest access

2013-03-05 Thread Christian Borntraeger
. In addition this is closer to the handling of copy_to/from_user functions, which imho is in general a good idea. Also shorten the return code handling in interrupt.c a bit. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off

[PATCH 5/8] s390/kvm,gaccess: shorten put/get_guest code

2013-03-05 Thread Christian Borntraeger
/get_user except that accesses must be aligned. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm

[PATCH 2/8] s390/mm,gmap: implement gmap_translate()

2013-03-05 Thread Christian Borntraeger
to happen soon (e.g. tprot exception handler). Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/include

[PATCH 7/8] s390/kvm: cleanup/fix handle_tpi()

2013-03-05 Thread Christian Borntraeger
Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/priv.c | 54 +--- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/arch/s390/kvm/priv.c b/arch/s390/kvm/priv.c index cb07147

Re: [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-27 Thread Christian Borntraeger
more efficiently. Signed-off-by: Michael S. Tsirkin m...@redhat.com Seems to work fine. (as expected). Tested-by: Christian Borntraeger borntrae...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com --- diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm

Re: [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-26 Thread Christian Borntraeger
On 26/02/13 12:04, Michael S. Tsirkin wrote: On Mon, Feb 25, 2013 at 04:27:45PM +0100, Cornelia Huck wrote: Here's the latest version of my patch series enabling ioeventfds on s390, again against kvm-next. Patches 1 and 2 (cleaning up initialization and exporting the virtio-ccw api) would

Re: [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-26 Thread Christian Borntraeger
On 26/02/13 12:18, Michael S. Tsirkin wrote: On Tue, Feb 26, 2013 at 01:04:21PM +0200, Michael S. Tsirkin wrote: On Mon, Feb 25, 2013 at 04:27:45PM +0100, Cornelia Huck wrote: Here's the latest version of my patch series enabling ioeventfds on s390, again against kvm-next. Patches 1 and 2

Re: [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-26 Thread Christian Borntraeger
-by: Christian Borntraeger borntrae...@de.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-26 Thread Christian Borntraeger
On 26/02/13 14:41, Michael S. Tsirkin wrote: So... Acked-by: Christian Borntraeger borntrae...@de.ibm.com So let's apply the patch for 3.9 and Give us 1 or 2 days testing for regression and then this can go for 3.9. The host changes can then be deferred to a later point in time. avoid

Re: kvm.git:next branch is going to be frozen shortly for 3.9 merge

2013-02-11 Thread Christian Borntraeger
On 10/02/13 14:50, Gleb Natapov wrote: As 3.8 release is inevitably going closer next branch is going to be frozen this week. All new patches will be applied to queue only awaiting for the 3.9-rc1. If you have something for 3.8 please send it asap. Please consider s390: Fix handling of iscs

Re: [PATCH] kvm-s390: Bugfix for handling of iscs.

2013-02-08 Thread Christian Borntraeger
On 07/02/13 13:20, Cornelia Huck wrote: Hi, here's another kvm-s390 bugfix for kvm-next, this time fixing a thinko in the I/O interrupt injection. Please apply. Cornelia Huck (1): KVM: s390: Fix handling of iscs. arch/s390/kvm/interrupt.c | 18 +++--- 1 file changed,

Re: [PATCH 0/3] s390/kvm fixes

2013-01-30 Thread Christian Borntraeger
On 29/01/13 22:03, Gleb Natapov wrote: The question about 1/1. It is CCed to stable, does this mean you want it to go to 3.8? kvm-next is for 3.9. On the second thought, if it is not a regression 3.9 is the right place. The store status part is broken, but it only has a severe impact in case

Re: [PATCH 0/3] s390/kvm fixes

2013-01-29 Thread Christian Borntraeger
On 29/01/13 14:12, Gleb Natapov wrote: On Fri, Jan 25, 2013 at 03:34:14PM +0100, Christian Borntraeger wrote: Gleb, Marcelo, Alex, can you review? Last time I checked, Cornelia and myself were s390/kvm/kernel maintainers ;-) Alex is maintainer for s390/kvm/qemu. If the patch introduces

[PATCH 2/3] s390/virtio-ccw: Fix setup_vq error handling.

2013-01-25 Thread Christian Borntraeger
in virtio_ccw_setup_vq(), using a single path for all errors. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- drivers/s390/kvm/virtio_ccw.c | 20 +++- 1 file changed

[PATCH 0/3] s390/kvm fixes

2013-01-25 Thread Christian Borntraeger
Gleb, Marcelo, here are 3 kvm fixes for kvm-next. Christian Borntraeger (3): s390/kvm: Fix store status for ACRS/FPRS s390/virtio-ccw: Fix setup_vq error handling. s390/kvm: Fix instruction decoding arch/s390/kvm/kvm-s390.c | 8 arch/s390/kvm/kvm-s390.h | 25

[PATCH 1/3] s390/kvm: Fix store status for ACRS/FPRS

2013-01-25 Thread Christian Borntraeger
a machine check will happen) will revalidate all registers with the content of the save area. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com CC: sta...@vger.kernel.org --- arch/s390/kvm/kvm-s390.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/s390/kvm/kvm-s390.c b/arch

[PATCH 3/3] s390/kvm: Fix instruction decoding

2013-01-25 Thread Christian Borntraeger
where appropriate to avoid problems if the code is changed or copy/pasted later on. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- arch/s390/kvm/kvm-s390.h | 25 ++--- 1 file changed, 14 insertions(+), 11

Re: [PATCH 2/3] s390/virtio-ccw: Fix setup_vq error handling.

2013-01-25 Thread Christian Borntraeger
On 25/01/13 15:34, Christian Borntraeger wrote: Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Sorry, I messed up the From. Should I resend or can you change the author to Cornelia Huck cornelia.h...@de.ibm.com Christian -- To unsubscribe from this list: send the line unsubscribe kvm

[PATCH 0/1] s390 bug in 3.8-rc

2013-01-08 Thread Christian Borntraeger
Marcelo, Gleb, Frederic, sorry for spotting this so late. Here is a fix for a bug in kvm on s390 with 3.8-rc. Due to all the subtle considerations regarding RCU, this is an RFC. Christian Borntraeger (1): s390/kvm: Fix BUG in include/linux/kvm_host.h:745 arch/s390/kvm/kvm-s390.c | 2 ++ 1

[RFC/PATCH 1/1] s390/kvm: Fix BUG in include/linux/kvm_host.h:745

2013-01-08 Thread Christian Borntraeger
to rcu_virt_note_context_switch returns. Please note that we continue to run s390 guests with interrupts enabled. CC: Frederic Weisbecker fweis...@gmail.com CC: Gleb Natapov g...@redhat.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 2 ++ 1 file

Re: [PATCH 2/5] KVM: s390: Add support for machine checks.

2012-12-19 Thread Christian Borntraeger
need to do exactly the same for the kvm gaccess functions. So __guestaddr_to_user() should just map all error codes to -EFAULT. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/gaccess.h | 7 +-- 1 file

Re: [PATCH v5 0/3] s390: Guest support for virtio-ccw.

2012-12-18 Thread Christian Borntraeger
On 17/12/12 16:00, Alexander Graf wrote: On 14.12.2012, at 17:02, Cornelia Huck wrote: Hi, here's the virtio-ccw guest support for kvm/next again. The not-kvm specific patches have made their way upstream via the s390 tree in the meantime. Patch 2 fixes an inconsistency there. Patch 3

Re: [PATCH 4/4] KVM: s390: Add a channel I/O based virtio transport driver.

2012-12-13 Thread Christian Borntraeger
On 13/12/12 12:06, Alexander Graf wrote: On 12.12.2012, at 21:12, Christian Borntraeger wrote: On 12/12/12 19:31, Alexander Graf wrote: +static inline long do_kvm_notify(struct subchannel_id schid, + unsigned long queue_index) +{ +register unsigned long __nr asm(1

Re: [PATCH 4/4] KVM: s390: Add a channel I/O based virtio transport driver.

2012-12-13 Thread Christian Borntraeger
On 13/12/12 12:19, Alexander Graf wrote: On 13.12.2012, at 12:13, Christian Borntraeger wrote: On 13/12/12 12:06, Alexander Graf wrote: On 12.12.2012, at 21:12, Christian Borntraeger wrote: On 12/12/12 19:31, Alexander Graf wrote: +static inline long do_kvm_notify(struct subchannel_id

Re: [PATCH 4/4] KVM: s390: Add a channel I/O based virtio transport driver.

2012-12-12 Thread Christian Borntraeger
On 12/12/12 19:31, Alexander Graf wrote: +static inline long do_kvm_notify(struct subchannel_id schid, + unsigned long queue_index) +{ +register unsigned long __nr asm(1) = KVM_S390_VIRTIO_CCW_NOTIFY; +register struct subchannel_id __schid asm(2) = schid; How does

Re: [PATCH 8/8] s390: Add new channel I/O based virtio transport.

2012-12-11 Thread Christian Borntraeger
On 11/12/12 11:53, Alexander Graf wrote: On 07.12.2012, at 13:50, Cornelia Huck wrote: Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it the default machine for s390.

[PATCH 0/1] s390 fix

2012-11-22 Thread Christian Borntraeger
Marcelo, here is a kvm related fix for s390. Please consider for the next merge window. Since it is s390 core kernel, I will also push it into Martins s390 tree. Christian Borntraeger (1): Subject: [PATCH] s390/kvm: Fix address space mixup arch/s390/kernel/entry64.S | 25

[PATCH 1/1] Subject: [PATCH] s390/kvm: Fix address space mixup

2012-11-22 Thread Christian Borntraeger
. (Otherwise we have a kernel bug anyway). We also have to compensate the rewinding, since the C-level handlers will do that. Therefore we need to add a nop with the same length as SIE before the sie_loop. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com CC: sta...@vger.kernel.org CC: Martin

Re: 3.7-rc2 build failure on s390x

2012-11-05 Thread Christian Borntraeger
On 31/10/12 11:32, Alexander Graf wrote: On 23.10.2012, at 08:20, Christian Borntraeger borntrae...@de.ibm.com wrote: On 22/10/12 23:14, Alexander Graf wrote: Hi Christian, During our normal Factory kernel builds, s390x seems to choke: /home/abuild/rpmbuild/BUILD/kernel-default-3.7

Re: 3.7-rc2 build failure on s390x

2012-10-23 Thread Christian Borntraeger
On 22/10/12 23:14, Alexander Graf wrote: Hi Christian, During our normal Factory kernel builds, s390x seems to choke: /home/abuild/rpmbuild/BUILD/kernel-default-3.7.rc2/linux-3.7-rc2/arch/s390/include/asm/kvm_para.h:147:99: error: redefinition of 'kvm_arch_para_features'

[PATCH 0/3] s390/kvm: misc fixes

2012-10-02 Thread Christian Borntraeger
Avi, Marcelo, here are some fixes for kvm on s390. Would be good if we could add s390/kvm: dont announce RRBM support for 3.7 since the current kvm claims a feature that we currently dont support. Everything else can be queued for the next merge window. Thanks Christian Borntraeger (1

[PATCH 3/3] s390/kvm: dont announce RRBM support

2012-10-02 Thread Christian Borntraeger
+0x6c/0x27c) [ 2150.713749] [00233812] page_referenced+0x32a/0x410 [...] CC: sta...@vger.kernel.org CC: Alex Graf ag...@suse.de Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 2 +- 1 file

[PATCH 1/3] s390/kvm: Interrupt injection bugfix

2012-10-02 Thread Christian Borntraeger
Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/interrupt.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 7556231..744ac1b 100644

[PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.

2012-10-02 Thread Christian Borntraeger
From: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- Documentation/virtual/kvm/api.txt | 33 + 1

Re: [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load', declared with attribute warn_unused_result

2012-09-27 Thread Christian Borntraeger
On 20/09/12 07:22, Michael S. Tsirkin wrote: On Thu, Sep 20, 2012 at 08:16:08AM +0800, Fengguang Wu wrote: Hi Michael, FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/virt/kvm/kvm.git queue head: 879238fecc051d95037ae76332916209a7770709 commit:

[PATCH] s390/kvm: Fix vcpu_load handling in interrupt code

2012-09-27 Thread Christian Borntraeger
. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/interrupt.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 7556231..ff1e2f8 100644

Re: [PATCH v2 7/7] s390/kvm: In-kernel channel subsystem support.

2012-09-20 Thread Christian Borntraeger
On 19/09/12 16:47, Alexander Graf wrote: On 04.09.2012, at 17:13, Cornelia Huck wrote: Handle most support for channel I/O instructions in the kernel itself. Only asynchronous functions (such as the start function) need to be handled by userspace. Phew. This is a lot of code for

Re: [PATCH 3/4] s390/kvm: Add a channel I/O based virtio transport driver.

2012-08-15 Thread Christian Borntraeger
Have you written an appendix for the virtio specification for virtio-ccw? I think it would be good to include in this series for the purposes of review. Might be nice, but don't get fancy about it. Text will be fine and I can cut paste it in once it's finalized. There was a patch

Re: [PATCH RFC V5 0/3] kvm: Improving directed yield in PLE handler

2012-07-23 Thread Christian Borntraeger
On 22/07/12 14:43, Avi Kivity wrote: On 07/22/2012 03:34 PM, Raghavendra K T wrote: Thanks Marcelo for the review. Avi, Rik, Christian, please let me know if this series looks good now. It looks fine to me. Christian, is this okay for s390? Tested-by: Christian Borntraeger borntrae

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-13 Thread Christian Borntraeger
On 13/07/12 05:35, Raghavendra K T wrote: Yes! I forgot about archs in init function. How about having #ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT vcpu-ple.cpu_relax_intercepted = false; vcpu-ple.dy_eligible = false; #endif This would solve all the problem. No, you need to mask all

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-12 Thread Christian Borntraeger
On 12/07/12 21:18, Raghavendra K T wrote: +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] + struct { + bool cpu_relax_intercepted; + bool dy_eligible; + } ple; +#endif [...] } vcpu-run = page_address(page); + vcpu-ple.cpu_relax_intercepted

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-11 Thread Christian Borntraeger
On 11/07/12 11:06, Avi Kivity wrote: [...] Almost all s390 kernels use diag9c (directed yield to a given guest cpu) for spinlocks, though. Perhaps x86 should copy this. See arch/s390/lib/spinlock.c The basic idea is using several heuristics: - loop for a given amount of loops - check if the

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-11 Thread Christian Borntraeger
On 11/07/12 13:04, Avi Kivity wrote: On 07/11/2012 01:17 PM, Christian Borntraeger wrote: On 11/07/12 11:06, Avi Kivity wrote: [...] Almost all s390 kernels use diag9c (directed yield to a given guest cpu) for spinlocks, though. Perhaps x86 should copy this. See arch/s390/lib/spinlock.c

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-11 Thread Christian Borntraeger
On 11/07/12 13:51, Raghavendra K T wrote: Almost all s390 kernels use diag9c (directed yield to a given guest cpu) for spinlocks, though. Perhaps x86 should copy this. See arch/s390/lib/spinlock.c The basic idea is using several heuristics: - loop for a given amount of loops - check if

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-09 Thread Christian Borntraeger
On 09/07/12 08:20, Raghavendra K T wrote: Currently Pause Looop Exit (PLE) handler is doing directed yield to a random VCPU on PL exit. Though we already have filtering while choosing the candidate to yield_to, we can do better. Problem is, for large vcpu guests, we have more probability of

[PATCH 0/1] vhost, use_mm and KERNEL_DS

2012-06-26 Thread Christian Borntraeger
Folks, here is a patch that fixes vhost to use USER_DS before doing a use_mm/usercopy operation. This was found during vhost prototyping on s390 were we have a separate user/kernel address space. Jens Freimann (1): use USER_DS in vhost_worker thread drivers/vhost/vhost.c |3 +++ 1 files

Re: [PATCH] kvm: notify host when guest panicked

2012-06-12 Thread Christian Borntraeger
We have three solutions to implement this feature: 1. use vmcall 2. use I/O port 3. use virtio-serial. We have decided to avoid touching hypervisor. The reason why I choose choose the I/O port is: 1. it is easier to implememt 2. it does not depend any virtual device 3. it can work when

Re: [PATCH 3/3] s390/kvm: Perform early event mask processing during boot.

2012-06-11 Thread Christian Borntraeger
On 11/06/12 18:46, Alexander Graf wrote: On 06/11/2012 04:06 PM, Cornelia Huck wrote: From: Heinz Graalfsgraa...@linux.vnet.ibm.com For processing under KVM it is required to detect the actual SCLP console type in order to set it as preferred console. Signed-off-by: Heinz

Re: [PATCH 1/3] s390/kvm: Set CPU in stopped state on initial cpu reset

2012-06-11 Thread Christian Borntraeger
On 11/06/12 18:46, Alexander Graf wrote: On 06/11/2012 04:06 PM, Cornelia Huck wrote: From: Christian Borntraegerborntrae...@de.ibm.com The initial cpu reset sets the cpu in the stopped state. Several places check for the cpu state (e.g. sigp set prefix) and not setting the STOPPED state

Fwd: [PATCH] s390/kvm: Change maintainer

2012-06-06 Thread Christian Borntraeger
FYI, Carsten pointed out that I forgot to CC the kvm mailing list. Right he is. On 05/06/12 13:05, Christian Borntraeger wrote: Since Carsten is now working on a different project, Cornelia will work as the 2nd s390/kvm maintainer. Signed-off-by: Christian Borntraeger borntrae

trace points and ABI

2012-06-06 Thread Christian Borntraeger
On 24/04/12 14:04, Avi Kivity wrote: @@ -74,6 +74,7 @@ struct kvm_stats_debugfs_item debugfs_entries[] = { { instruction_sigp_restart, VCPU_STAT(instruction_sigp_restart) }, { diagnose_10, VCPU_STAT(diagnose_10) }, { diagnose_44, VCPU_STAT(diagnose_44) }, +{ diagnose_9c,

Re: [PATCH 4/4] kvm-s390: onereg for timer related registers

2012-06-05 Thread Christian Borntraeger
On 05/06/12 14:42, Alexander Graf wrote: On 15.05.2012, at 14:15, Christian Borntraeger wrote: From: Jason J. herne jjhe...@us.ibm.com Enhance the KVM ONE_REG capability within S390 to allow getting/setting the following special cpu registers: clock comparator and the cpu timer

Re: [PATCH v2] virtio_blk: unlock vblk-lock during kick

2012-06-04 Thread Christian Borntraeger
On 04/06/12 03:57, Rusty Russell wrote: Unfortunately, this conflicts with Asias He's deadlock fix, which has us just using the block-layer-supplied spinlock. If we drop the lock around the kick as you suggest, we're playing with fire. All the virtio backends have an atomic notify, so

<    4   5   6   7   8   9   10   11   >