Re: [PATCH 0/6] VSOCK: revert virtio-vsock until device spec is finalized

From: Stefan Hajnoczi Date: Tue, 8 Dec 2015 19:57:30 +0800 > Please revert for now. Please don't revert it piece by piece like this. Instead, send me one big revert commit that undoes the whole thing. There is even a merge commit that you can use to create that revert

Re: [PATCH] vhost: vsock: select CONFIG_VHOST

From: "Michael S. Tsirkin" Date: Tue, 8 Dec 2015 18:09:44 +0200 > On Tue, Dec 08, 2015 at 04:46:08PM +0100, Arnd Bergmann wrote: >> When building the new vsock code without vhost, we get a build error: >> >> drivers/built-in.o: In function `vhost_vsock_flush': >>

Re: [PATCH v2] Revert "Merge branch 'vsock-virtio'"

From: Stefan Hajnoczi Date: Wed, 9 Dec 2015 10:51:12 +0800 > This reverts commit 0d76d6e8b2507983a2cae4c09880798079007421 and merge > commit c402293bd76fbc93e52ef8c0947ab81eea3ae019, reversing changes made > to c89359a42e2a49656451569c382eed63e781153c. > > The virtio-vsock

Re: [PATCH] VSOCK: fix returnvar.cocci warnings

From: Julia Lawall Date: Sun, 6 Dec 2015 06:56:23 +0100 (CET) > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > CC: Asias He > Signed-off-by: Fengguang Wu >

Re: [PATCH v2 0/5] Add virtio transport for AF_VSOCK

From: Stefan Hajnoczi Date: Wed, 2 Dec 2015 14:43:58 +0800 > This patch series adds a virtio transport for AF_VSOCK (net/vmw_vsock/). Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to

Re: [PATCH v2] vhost: replace % with & on data path

From: "Michael S. Tsirkin" Date: Mon, 30 Nov 2015 11:15:23 +0200 > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin Acked-by: David S. Miller -- To unsubscribe from this list:

Re: [PATCH] vhost: replace % with & on data path

From: "Michael S. Tsirkin" Date: Mon, 30 Nov 2015 10:34:07 +0200 > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c | 8 +--- > 1 file changed, 5 insertions(+), 3

Re: [PATCH net-next 0/3] basic busy polling support for vhost_net

From: Jason Wang Date: Wed, 25 Nov 2015 15:11:26 +0800 > This series tries to add basic busy polling for vhost net. The idea is > simple: at the end of tx/rx processing, busy polling for new tx added > descriptor and rx receive socket for a while. The maximum number of >

Re: [PATCH v1 2/2] dma-mapping-common: add DMA attribute - DMA_ATTR_IOMMU_BYPASS

From: Joerg Roedel Date: Thu, 5 Nov 2015 14:42:06 +0100 > Contended IOMMU locks are not only a problem on SPARC, but on x86 and > various other IOMMU drivers too. But I have some ideas on how to improve > the situation there. And for the record Sowmini fixed a lot of the lock

Re: [PATCH v1 2/2] dma-mapping-common: add DMA attribute - DMA_ATTR_IOMMU_BYPASS

From: David Woodhouse Date: Thu, 29 Oct 2015 22:35:25 + > For the receive side, it shouldn't be beyond the wit of man to > introduce an API which allocates *and* DMA-maps a skb. Pass it to > netif_rx() still mapped, with a destructor that just shoves it back in > a pool

Re: [PATCH] vhost: move is_le setup to the backend

From: Greg Kurz Date: Fri, 30 Oct 2015 12:42:35 +0100 > The vq->is_le field is used to fix endianness when accessing the vring via > the cpu_to_vhost16() and vhost16_to_cpu() helpers in the following cases: > > 1) host is big endian and device is modern virtio > > 2)

Re: [PATCH v1 2/2] dma-mapping-common: add DMA attribute - DMA_ATTR_IOMMU_BYPASS

From: David Woodhouse Date: Wed, 28 Oct 2015 22:31:50 +0900 > On Wed, 2015-10-28 at 13:10 +0200, Shamir Rabinovitch wrote: >> On Wed, Oct 28, 2015 at 03:30:01PM +0900, David Woodhouse wrote: >> > > > +For systems with IOMMU it is assumed all DMA translations use the >> > >

Re: [PATCH v1 2/2] dma-mapping-common: add DMA attribute - DMA_ATTR_IOMMU_BYPASS

From: David Woodhouse <dw...@infradead.org> Date: Wed, 28 Oct 2015 22:57:12 +0900 > On Wed, 2015-10-28 at 07:07 -0700, David Miller wrote: >> In the sparc64 case, the 64-bit DMA address space is divided into >> IOMMU translated and non-IOMMU translated. >> &g

Re: [PATCH] vhost: fix performance on LE hosts

From: "Michael S. Tsirkin" Date: Tue, 27 Oct 2015 11:37:39 +0200 > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian

Re: [PATCH] vhost: fix performance on LE hosts

From: "Michael S. Tsirkin" Date: Tue, 27 Oct 2015 11:37:39 +0200 > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian

Re: [PATCH] Fix AF_PACKET ABI breakage in 4.2

From: David Woodhouse Date: Wed, 23 Sep 2015 15:44:30 +0100 > +#define VIO_LE virtio_legacy_is_little_endian() When you define a shorthand macro, the defines to a function call, make the macro have parenthesis too. -- To unsubscribe from this list: send the line

Re: [PATCH v6 3/8] macvtap: introduce macvtap_is_little_endian() helper

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 1 Jun 2015 12:30:16 +0200 On Fri, Apr 24, 2015 at 02:24:48PM +0200, Greg Kurz wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Dave, could you pls ack merging this through the virtio tree? Acked-by: David S. Miller

Re: [PATCH v6 2/8] tun: add tun_is_little_endian() helper

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 1 Jun 2015 12:29:43 +0200 On Fri, Apr 24, 2015 at 02:24:38PM +0200, Greg Kurz wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Dave, could you please ack merging this through the virtio tree? Acked-by: David S. Miller

Re: [PATCH] treewide: Fix typo compatability - compatibility

From: Laurent Pinchart laurent.pinch...@ideasonboard.com Date: Wed, 27 May 2015 15:05:42 +0300 Even though 'compatability' has a dedicated entry in the Wiktionary, it's listed as 'Mispelling of compatibility'. Fix it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Re: [PATCH] vhost: drop hard-coded num_buffers size

From: Michael S. Tsirkin m...@redhat.com Date: Tue, 24 Feb 2015 17:31:10 +0100 The 2 that we use for copy_to_iter comes from sizeof(u16), it used to be that way before the iov iter update. Fix it up, making it obvious the size of stack access is right. Signed-off-by: Michael S. Tsirkin

Re: [PATCH] vhost: cleanup iterator update logic

From: Michael S. Tsirkin m...@redhat.com Date: Tue, 24 Feb 2015 17:31:31 +0100 Recent iterator-related changes in vhost made it harder to follow the logic fixing up the header. In fact, the fixup always happens at the same offset: sizeof(virtio_net_hdr): sometimes the fixup iterator is

Re: [PATCH] vhost: drop hard-coded num_buffers size

From: Michael S. Tsirkin m...@redhat.com Date: Tue, 24 Feb 2015 17:31:10 +0100 The 2 that we use for copy_to_iter comes from sizeof(u16), it used to be that way before the iov iter update. Fix it up, making it obvious the size of stack access is right. Signed-off-by: Michael S. Tsirkin

Re: [PATCH net] vhost_net: fix wrong iter offset when setting number of buffers

From: Jason Wang jasow...@redhat.com Date: Sun, 15 Feb 2015 16:35:17 +0800 In commit ba7438aed924 (vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()), we advance iov iter fixup sizeof(struct virtio_net_hdr) bytes and fill the number of buffers after doing the socket

Re: [PATCH for-3.19] vhost/net: fix up num_buffers endian-ness

From: Michael S. Tsirkin m...@redhat.com Date: Tue, 3 Feb 2015 11:07:06 +0200 In virtio 1.0 mode, when mergeable buffers are enabled on a big-endian host, num_buffers wasn't byte-swapped correctly, so large incoming packets got corrupted. To fix, fill it in within hdr - this also makes sure

Re: [PATCH net-next] vhost: remove unnecessary forward declarations in vhost.h

From: Jason Wang jasow...@redhat.com Date: Thu, 27 Nov 2014 14:41:21 +0800 Signed-off-by: Jason Wang jasow...@redhat.com I don't think generic vhost patches should go via my tree. If you disagree, let me know why, thanks :) -- To unsubscribe from this list: send the line unsubscribe kvm in the

Re: TUN_F_UFO change breaks live migration

From: Michael S. Tsirkin m...@redhat.com Date: Tue, 11 Nov 2014 17:57:50 +0200 Basically userspace assumed that features will only ever be added, never removed, so this change is breaking it. I essentially agree. We can't just toss feature bits like this which have been present for so long.

Re: [PATCH net] Revert drivers/net: Disable UFO through virtio in macvtap and tun

From: Ben Hutchings b...@decadent.org.uk Date: Tue, 11 Nov 2014 17:12:58 + This reverts commit 88e0e0e5aa722b193c8758c8b45d041de5316924 for the tap drivers, but leaves UFO disabled in virtio_net. libvirt at least assumes that tap features will never be dropped in new kernel versions,

Re: [PATCH net-next RFC 0/3] virtio-net: Conditionally enable tx interrupt

From: Jason Wang jasow...@redhat.com Date: Sat, 11 Oct 2014 15:16:43 +0800 We free old transmitted packets in ndo_start_xmit() currently, so any packet must be orphaned also there. This was used to reduce the overhead of tx interrupt to achieve better performance. But this may not work for

Re: [PATCH] vhost: Add polling mode

From: Michael S. Tsirkin m...@redhat.com Date: Sun, 10 Aug 2014 21:45:59 +0200 On Sun, Aug 10, 2014 at 11:30:35AM +0300, Razya Ladelsky wrote: ... And, did your tests actually produce 100% load on both host CPUs? ... Michael, please do not quote an entire patch just to ask a one line

Re: [PULL net-next] vhost enhancements for 3.16

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 2 Jun 2014 23:55:15 +0300 The following changes since commit 96b2e73c5471542cb9c622c4360716684f8797ed: Revert net/mlx4_en: Use affinity hint (2014-06-02 00:18:48 -0700) are available in the git repository at:

Re: Moving frags and SKBTX_DEV_ZEROCOPY skbs

From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 14 May 2014 07:23:52 -0700 On Wed, 2014-05-14 at 14:40 +0100, Zoltan Kiss wrote: Hi, Recently I've investigated issues around SKBTX_DEV_ZEROCOPY skbs where the frags list were modified. I came across this function skb_shift(), which

Re: [PATCHv2 net] vhost: fix total length when packets are too short

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 27 Mar 2014 12:00:26 +0200 When mergeable buffers are disabled, and the incoming packet is too large for the rx buffer, get_rx_bufs returns success. This was intentional in order for make recvmsg truncate the packet and then handle_rx

Re: [PATCH net] vhost: validate vhost_get_vq_desc return value

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 27 Mar 2014 12:53:37 +0200 vhost fails to validate negative error code from vhost_get_vq_desc causing a crash: we are using -EFAULT which is 0xfff2 as vector size, which exceeds the allocated size. The code in question was introduced

Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

From: Zoltan Kiss zoltan.k...@citrix.com Date: Wed, 26 Mar 2014 22:37:45 + skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so this patch takes care of that as well, and modify the callers accordingly.

Re: [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

From: Zoltan Kiss zoltan.k...@citrix.com Date: Fri, 21 Mar 2014 10:31:34 + skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so this patch takes care of that as well, and modify the callers accordingly.

Re: [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

From: David Miller da...@davemloft.net Date: Wed, 26 Mar 2014 15:59:58 -0400 (EDT) From: Zoltan Kiss zoltan.k...@citrix.com Date: Fri, 21 Mar 2014 10:31:34 + skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so

Re: [PATCH v3] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

From: Zoltan Kiss zoltan.k...@citrix.com Date: Thu, 20 Mar 2014 16:02:34 + skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so this patch takes care of that as well, and modify the callers accordingly.

Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

From: Zoltan Kiss zoltan.k...@citrix.com Date: Tue, 18 Mar 2014 21:17:35 + skb_zerocopy can copy elements of the frags array between skbs, but it doesn't orphan them. Also, it doesn't handle errors, so this patch takes care of that as well. Signed-off-by: Zoltan Kiss

Re: [PATCH net V2] vhost: net: switch to use data copy if pending DMAs exceed the limit

From: Jason Wang jasow...@redhat.com Date: Fri, 7 Mar 2014 13:28:27 +0800 This is because the delay added by htb may lead the delay the finish of DMAs and cause the pending DMAs for tap0 exceeds the limit (VHOST_MAX_PEND). In this case vhost stop handling tx request until htb send some

Re: [RFC v2 2/4] net: enables interface option to skip IP

From: Dan Williams d...@redhat.com Date: Tue, 25 Feb 2014 15:07:00 -0600 Also, disable_ipv4 signals *intent*, which is distinct from current state. Does an interface without an IPv4 address mean that the user wished it not to have one? Or does it mean that DHCP hasn't started yet (but is

Re: [RFC v2 2/4] net: enables interface option to skip IP

From: Dan Williams d...@redhat.com Date: Mon, 24 Feb 2014 12:22:00 -0600 In the future I expect more people will want to disable IPv4 as they move to IPv6. I definitely don't. I've been lightly following this conversation and I have to say a few things. disable_ipv6 was added because people

Re: [RFC v2 2/4] net: enables interface option to skip IP

From: Ben Hutchings b...@decadent.org.uk Date: Tue, 25 Feb 2014 00:02:00 + You can run an internal network, or access network, as v6-only with NAT64 and DNS64 at the border. I believe some mobile networks are doing this; it was also done on the main FOSDEM wireless network this year.

Re: [PATCH net v2] vhost: fix ref cnt checking deadlock

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 13 Feb 2014 11:42:05 +0200 vhost checked the counter within the refcnt before decrementing. It really wanted to know that it is the one that has the last reference, as a way to batch freeing resources a bit more efficiently. Note: we only

Re: [PATCH net v2] vhost: fix a theoretical race in device cleanup

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 13 Feb 2014 11:45:11 +0200 vhost_zerocopy_callback accesses VQ right after it drops a ubuf reference. In theory, this could race with device removal which waits on the ubuf kref, and crash on use after free. Do all accesses within rcu

Re: [PATCH V3 0/6] vhost code cleanup and minor enhancement

From: Jason Wang jasow...@redhat.com Date: Mon, 2 Sep 2013 16:40:55 +0800 This series tries to unify and simplify vhost codes especially for zerocopy. With this series, 5% - 10% improvement for per cpu throughput were seen during netperf guest sending test. Plase review. Applied and patch

Re: [PATCH v2] vhost: Include linux/uio.h instead of linux/socket.h

From: Asias He as...@redhat.com Date: Mon, 19 Aug 2013 09:23:19 +0800 memcpy_fromiovec is moved from net/core/iovec.c to lib/iovec.c. linux/uio.h provides the declaration for memcpy_fromiovec. Include linux/uio.h instead of inux/socket.h for it. Signed-off-by: Asias He as...@redhat.com

Re: [PATCH] vhost: Drop linux/socket.h

From: Asias He as...@redhat.com Date: Fri, 16 Aug 2013 09:27:43 +0800 On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote: From: Asias He as...@redhat.com Date: Thu, 15 Aug 2013 11:20:16 +0800 memcpy_fromiovec is moved to lib/iovec.c. No need to include linux/socket.h

Re: [PATCH] vhost: Drop linux/socket.h

From: Asias He as...@redhat.com Date: Fri, 16 Aug 2013 17:27:43 +0800 On Fri, Aug 16, 2013 at 12:31:59AM -0700, David Miller wrote: From: Asias He as...@redhat.com Date: Fri, 16 Aug 2013 09:27:43 +0800 On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote: From: Asias He

Re: [PATCH] vhost: Drop linux/socket.h

From: Asias He as...@redhat.com Date: Thu, 15 Aug 2013 11:20:16 +0800 memcpy_fromiovec is moved to lib/iovec.c. No need to include linux/socket.h for it. Signed-off-by: Asias He as...@redhat.com You can't do this. Because this file doesn't include the header file that provides the

Re: [PATCHv3] vhost-net: fix use-after-free in vhost_net_flush

From: Michael S. Tsirkin m...@redhat.com Date: Sun, 7 Jul 2013 14:26:53 +0300 vhost_net_ubuf_put_and_wait has a confusing name: it will actually also free it's argument. Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01 vhost-net: flush outstanding DMAs on memory change

Re: [RFC 2/5] VSOCK: Introduce virtio-vsock-common.ko

From: Asias He as...@redhat.com Date: Thu, 27 Jun 2013 16:00:01 +0800 +static void +virtio_transport_recv_dgram(struct sock *sk, + struct virtio_vsock_pkt *pkt) ... + memcpy(skb-data, pkt, sizeof(*pkt)); + memcpy(skb-data + sizeof(*pkt), pkt-buf, pkt-len);

Re: [PATCHv2] vhost-net: fix use-after-free in vhost_net_flush

From: Michael S. Tsirkin m...@redhat.com Date: Tue, 25 Jun 2013 17:29:46 +0300 vhost_net_ubuf_put_and_wait has a confusing name: it will actually also free it's argument. Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01 vhost-net: flush outstanding DMAs on memory change

Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 20 Jun 2013 14:48:13 +0300 vhost_net_ubuf_put_and_wait has a confusing name: it will actually also free it's argument. Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01 Never reference commits only by SHA1 ID, it is never

Re: [PATCH net 1/2] vhost: check owner before we overwrite ubuf_info

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 6 Jun 2013 15:20:39 +0300 If device has an owner, we shouldn't touch ubuf_info since it might be in use. Signed-off-by: Michael S. Tsirkin m...@redhat.com Applied. -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH net 2/2] vhost: fix ubuf_info cleanup

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 6 Jun 2013 15:20:46 +0300 vhost_net_clear_ubuf_info didn't clear ubuf_info after kfree, this could trigger double free. Fix this and simplify this code to make it more robust: make sure ubuf info is always freed through

Re: [PATCH] vhost_net: clear msg.control for non-zerocopy case during tx

From: Michael S. Tsirkin m...@redhat.com Date: Wed, 5 Jun 2013 12:02:52 +0300 On Wed, Jun 05, 2013 at 03:40:46PM +0800, Jason Wang wrote: When we decide not use zero-copy, msg.control should be set to NULL otherwise macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 16 May 2013 09:46:21 +0300 On Wed, May 15, 2013 at 08:10:55PM -0700, David Miller wrote: From: Rusty Russell ru...@rustcorp.com.au Date: Thu, 16 May 2013 09:05:38 +0930 memcpy_fromiovec() has nothing to do with networking: that was just

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

From: Rusty Russell ru...@rustcorp.com.au Date: Thu, 16 May 2013 09:05:38 +0930 memcpy_fromiovec() has nothing to do with networking: that was just the first user. Note that crypto/algif_skcipher.c also uses it. The obvious answer is to move it into lib/. +1 -- To unsubscribe from this

Re: [PULL] vhost: cleanups and fixes for 3.10

From: Michael S. Tsirkin m...@redhat.com Date: Wed, 1 May 2013 18:01:31 +0300 Please pull the following vhost core updates for 3.10 - they affect both vhost-net and vhost-scsi devices. They also *depend* on both net-next and target-pending. Since Linus merged target-pending but not net-next

Re: [PATCH] vhost_net: remove tx polling state

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 11 Apr 2013 10:24:30 +0300 On Thu, Apr 11, 2013 at 02:50:48PM +0800, Jason Wang wrote: After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle polling errors when setting backend), we in fact track the polling state through

Re: [PULL] vhost: tcm_vhost fixes for 3.9

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 18 Mar 2013 13:20:03 +0200 The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca: Revert ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally (2013-03-16 23:00:41 -0400) are available

Re: [PATCH net] vhost/net: fix heads usage of ubuf_info

From: Michael S. Tsirkin m...@redhat.com Date: Sun, 17 Mar 2013 14:46:09 +0200 ubuf info allocator uses guest controlled head as an index, so a malicious guest could put the same head entry in the ring twice, and we will get two callbacks on the same value. To fix use upend_idx which is

Re: [PATCH] vhost_net: remove tx polling state

From: Jason Wang jasow...@redhat.com Date: Thu, 7 Mar 2013 12:31:56 +0800 After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle polling errors when setting backend), we in fact track the polling state through poll-wqh, so there's no need to duplicate the work with an

Re: [PATCH] vhost-net: fall back to vmalloc if high-order allocation fails

From: Michael S. Tsirkin m...@redhat.com Date: Wed, 23 Jan 2013 23:04:11 +0200 Maybe we should try and reduce our memory usage, I will look into this. As has been pointed out, 32K of the size is from those iovecs in the queues. The size of this structure is frankly offensive, and even if you

Re: [PATCH v5 0/3] make mac programming for virtio net more robust

From: Amos Kong ak...@redhat.com Date: Mon, 21 Jan 2013 19:17:20 +0800 Currenly mac is programmed byte by byte. This means that we have an intermediate step where mac is wrong. Third patch introduced a new vq control command to set mac address, it's atomic. V2: check return of sending

Re: [PATCH v4 2/3] net: split eth_mac_addr for better error handling

From: ak...@redhat.com Date: Sun, 20 Jan 2013 10:43:08 +0800 From: Stefan Hajnoczi stefa...@gmail.com When we set mac address, software mac address in system and hardware mac address all need to be updated. Current eth_mac_addr() doesn't allow callers to implement error handling nicely.

Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

From: Jason Wang jasow...@redhat.com Date: Sat, 8 Dec 2012 01:04:54 +0800 This series is an update version (hope the final version) of multiqueue (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were addressed, the work were based on Krishna Kumar's work to let virtio-net

Re: [PULL net-next] vhost: changes for 3.8

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 6 Dec 2012 17:18:00 +0200 The following changes since commit b93196dc5af7729ff7cc50d3d322ab1a364aa14f: net: fix some compiler warning in net/core/neighbour.c (2012-12-05 21:50:37 -0500) are available in the git repository at:

Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

From: Jason Wang jasow...@redhat.com Date: Sat, 8 Dec 2012 01:04:54 +0800 This series is an update version (hope the final version) of multiqueue (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were addressed, the work were based on Krishna Kumar's work to let virtio-net

Re: [PATCH] vhost-net: initialize zcopy packet counters

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 3 Dec 2012 19:31:51 +0200 These packet counters are used to drive the zercopy selection heuristic so nothing too bad happens if they are off a bit - and they are also reset once in a while. But it's cleaner to clear them when backend is set

Re: [PATCH] vhost-blk: Add vhost-blk support v5

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 26 Nov 2012 17:14:16 +0200 On Mon, Nov 19, 2012 at 10:26:41PM +0200, Michael S. Tsirkin wrote: Userspace bits: - 1) LKVM The latest vhost-blk userspace bits for kvm tool can be found here:

Re: [PATCH 1/1] vhost: Remove duplicate inclusion of linux/vhost.h

From: Sachin Kamat sachin.ka...@linaro.org Date: Mon, 19 Nov 2012 16:58:28 +0530 linux/vhost.h was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Michael, are you gonna take this? Thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH 1/1] vhost: Remove duplicate inclusion of linux/vhost.h

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 19 Nov 2012 21:49:55 +0200 On Mon, Nov 19, 2012 at 02:18:13PM -0500, David Miller wrote: From: Sachin Kamat sachin.ka...@linaro.org Date: Mon, 19 Nov 2012 16:58:28 +0530 linux/vhost.h was included twice. Signed-off-by: Sachin Kamat

Re: [PATCHv3 net-next 0/8] enable/disable zero copy tx dynamically

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 1 Nov 2012 21:16:17 +0200 tun supports zero copy transmit since 0690899b4d4501b3505be069b9a687e68ccbe15b, however you can only enable this mode if you know your workload does not trigger heavy guest to host/host to guest traffic -

Re: [PATCHv2 net-next 1/8] skb: report completion status for zero copy skbs

From: Michael S. Tsirkin m...@redhat.com Date: Wed, 31 Oct 2012 12:31:06 +0200 -void vhost_zerocopy_callback(struct ubuf_info *ubuf) +void vhost_zerocopy_callback(struct ubuf_info *ubuf, int zerocopy_status) If you're only reporting true/false values, even just for now, please use 'bool' for

Re: [PATCHv2 net-next 1/8] skb: report completion status for zero copy skbs

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 1 Nov 2012 18:16:11 +0200 Do you think it's over-engineering, or a good idea? Engineer what you need, not what you might need. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts

From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Oct 2012 18:24:38 +0200 Would you like me to repost the patch? This question is almost retorical. I said I don't reliably read things I'm not explicitly CC:'d on, therefore it's possible (and in fact, likely) I don't have the patch in my

Re: [PATCH repost for-3.7] vhost: fix mergeable bufs on BE hosts

From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Oct 2012 20:37:51 +0200 We copy head count to a 16 bit field, this works by chance on LE but on BE guest gets 0. Fix it up. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Alexander Graf ag...@suse.de Cc:

Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts

From: Michael S. Tsirkin m...@redhat.com Date: Sun, 21 Oct 2012 14:49:01 +0200 On Mon, Oct 15, 2012 at 07:55:34PM +0200, Michael S. Tsirkin wrote: We copy head count to a 16 bit field, this works by chance on LE but on BE guest gets 0. Fix it up. Signed-off-by: Michael S. Tsirkin

Re: [PATCH] skbuff: struct ubuf_info callback type safety

From: Michael S. Tsirkin m...@redhat.com Date: Mon, 9 Apr 2012 13:24:02 +0300 The skb struct ubuf_info callback gets passed struct ubuf_info itself, not the arg value as the field name and the function signature seem to imply. Rename the arg field to ctx to match usage, add documentation and

Re: [PULL net] vhost-net/virtio: fixes for 3.4

From: Michael S. Tsirkin m...@redhat.com Date: Fri, 23 Mar 2012 17:28:07 +0200 The following changes since commit 5ffca28a4ac7abb8a254fafe6bd03b2f83667df7: Merge git://git.kernel.org/pub/scm/linux/kernel/git/aia21/ntfs (2012-02-27 07:59:33 -0800) are available in the git repository at:

Re: [PULL] vhost-net/virtio: fixes for 3.4

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 22 Mar 2012 10:27:19 +0200 Dave, just checking - not sure I made it clear that this pull request is intended to go in through your tree. If you see any issues pls let me know so I can fix them. I missed it, sorry. For some reason patchwork

Re: [PULL] vhost-net/virtio: fixes for 3.4

From: Michael S. Tsirkin m...@redhat.com Date: Thu, 22 Mar 2012 10:27:19 +0200 On Tue, Mar 20, 2012 at 04:50:41PM +0200, Michael S. Tsirkin wrote: The following changes since commit 5ffca28a4ac7abb8a254fafe6bd03b2f83667df7: Merge git://git.kernel.org/pub/scm/linux/kernel/git/aia21/ntfs

Re: [PULL] vhost-net/virtio: fixes for 3.4

From: Michael S. Tsirkin m...@redhat.com Date: Fri, 23 Mar 2012 00:12:28 +0200 OK, sorry about that. Can't fix right now as I'm not at the box that has the key but this works for me with an old git: Please fix it up so I can pull properly. -- To unsubscribe from this list: send the line

Re: [net-next PATCH v0 0/5] Series short description

From: John Fastabend john.r.fastab...@intel.com Date: Sun, 18 Mar 2012 23:51:45 -0700 This series is a follow up to this thread: http://www.spinics.net/lists/netdev/msg191360.html Can the interested parties please review this series? I'm willing to apply this right now if it looks OK, but

Re: [net-next PATCH v0 0/5] Series short description

From: John Fastabend john.r.fastab...@intel.com Date: Mon, 19 Mar 2012 17:27:00 -0700 Dave, its probably fine to push this to 3.5 then. Fair enough. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] vhost-net: add module alias (v2.1)

From: Stephen Hemminger shemmin...@vyatta.com Date: Mon, 16 Jan 2012 07:52:36 -0800 On Mon, 16 Jan 2012 12:26:45 + Alan Cox a...@linux.intel.com wrote: ACKs, NACKs? What is happening here? I would like an Ack from Alan Cox who switched vhost-net to a dynamic minor in the first

Re: [PATCH] vhost-net: add module alias (v2.1)

From: Kay Sievers kay.siev...@vrfy.org Date: Fri, 13 Jan 2012 05:19:05 +0100 On Fri, Jan 13, 2012 at 05:07, David Miller da...@davemloft.net wrote: From: Stephen Hemminger shemmin...@vyatta.com Date: Wed, 11 Jan 2012 21:30:38 -0800 Subject: vhost-net: add module alias (v2.1) By adding some

Re: [PATCH] vhost-net: add module alias (v2.1)

From: Stephen Hemminger shemmin...@vyatta.com Date: Wed, 11 Jan 2012 21:30:38 -0800 Subject: vhost-net: add module alias (v2.1) By adding some module aliases, programs (or users) won't have to explicitly call modprobe. Vhost-net will always be available if built into the kernel. It does

Re: [PATCH 1/3] net: use this_cpu_xxx replace percpu_xxx funcs

From: Alex,Shi alex@intel.com Date: Wed, 11 Jan 2012 16:45:33 +0800 percpu_xxx funcs are duplicated with this_cpu_xxx funcs, so replace them for further code clean up. And in preempt safe scenario, __this_cpu_xxx funcs has a bit better performance since __this_cpu_xxx has no

Re: [PATCH] vhost-net: Acquire device lock when releasing device

From: Sasha Levin levinsasha...@gmail.com Date: Fri, 18 Nov 2011 11:19:42 +0200 Device lock should be held when releasing a device, and specifically when calling vhost_dev_cleanup(). Otherwise, RCU complains about it: ... Cc: Michael S. Tsirkin m...@redhat.com Cc: kvm@vger.kernel.org Cc:

Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb

From: Sasha Levin levinsasha...@gmail.com Date: Wed, 28 Sep 2011 17:40:54 +0300 This patch verifies that the length of a buffer stored in a linked list of pages is small enough to fit into a skb. If the size is larger than a max size of a skb, it means that we shouldn't go ahead building

Re: [PATCH v2 2/2] virtio-net: Prevent NULL dereference

From: Sasha Levin levinsasha...@gmail.com Date: Wed, 28 Sep 2011 17:40:55 +0300 This patch prevents a NULL dereference when the user has passed a length longer than an actual buffer to virtio-net. Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc:

Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb

From: Sasha Levin levinsasha...@gmail.com Date: Wed, 28 Sep 2011 17:40:54 +0300 This patch verifies that the length of a buffer stored in a linked list of pages is small enough to fit into a skb. If the size is larger than a max size of a skb, it means that we shouldn't go ahead building

Re: [PATCH net-next] skbuff: clear tx zero-copy flag

From: Herbert Xu herb...@gondor.hengli.com.au Date: Mon, 25 Jul 2011 17:57:11 +0800 However, I think we should add a WARN_ON to the splice skb path so that should a packet find its way through a path that we haven't thought of then at least we'll know about it. Good idea. -- To unsubscribe

Re: [PULL net] vhost-net: zercopy mode fixes

From: Michael S. Tsirkin m...@redhat.com Date: Fri, 22 Jul 2011 09:00:46 +0300 The following includes vhost-net fixes - both in the experimental zero copy mode. Please pull for 3.1. Thanks! Where is this the following? I don't see any GIT url to pull from or anything :-) -- To unsubscribe

Re: [PULL net (try 2)] vhost-net: zercopy mode fixes

From: Michael S. Tsirkin m...@redhat.com Date: Fri, 22 Jul 2011 09:32:38 +0300 Fixing a corrupted pull request sent earlier. Sorry about the noise! The following includes vhost-net fixes - both in the experimental zero copy mode. Please pull for 3.1. Pulled, thanks! -- To unsubscribe from

Re: [PATCHv9] vhost: experimental tx zero-copy support

From: Michael S. Tsirkin m...@redhat.com Date: Sun, 17 Jul 2011 22:36:14 +0300 The below is what I came up with. We add the feature enabled by default ... s/enabled/disabled/ Well, at least you got it right in the commit message where it counts :-) -- To unsubscribe from this list: send the

Re: [PATCH net-next] skbuff: clear tx zero-copy flag

From: Shirley Ma mashi...@us.ibm.com Date: Sat, 09 Jul 2011 00:12:46 -0700 This patch clears tx zero-copy flag as needed. Signed-off-by: Shirley Ma x...@us.ibm.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [heads-up] bridge in kernel 3.0~ and dhcp from kvm guest on tap device

From: Michael Tokarev m...@tls.msk.ru Date: Thu, 07 Jul 2011 13:44:57 +0400 The combination in $subject apparently stopped working -- I'm running 3.0-rc6 kernel on host where it doesn't work. Already fixed in net-2.6: From 44661462ee1ee3c922754fc1f246867f0d01e7ea Mon Sep 17 00:00:00 2001

  1   2   >