Re: [PATCH] iommu/s390: add iommu api for s390 pci devices

2015-10-01 Thread Gerald Schaefer
rtant for DMA API device recovery and map/unmap on s390. > > My other question is inline: > > On Thu, Aug 27, 2015 at 03:33:03PM +0200, Gerald Schaefer wrote: > > +struct s390_domain_device { > > + struct list_headlist; > > + struct zpci_dev *zdev; &g

[PATCH] iommu/s390: add iommu api for s390 pci devices

2015-08-27 Thread Gerald Schaefer
This adds an IOMMU API implementation for s390 PCI devices. Reviewed-by: Sebastian Ott seb...@linux.vnet.ibm.com Signed-off-by: Gerald Schaefer gerald.schae...@de.ibm.com --- MAINTAINERS | 7 + arch/s390/Kconfig | 1 + arch/s390/include/asm/pci.h | 4

Re: [RFC PATCH 0/1] iommu: Detach device from domain when removed from group

2015-08-03 Thread Gerald Schaefer
On Mon, 3 Aug 2015 17:48:55 +0200 Joerg Roedel j...@8bytes.org wrote: On Tue, Jul 28, 2015 at 07:55:55PM +0200, Gerald Schaefer wrote: On s390, this eventually leads to a kernel panic when binding the device again to its non-vfio PCI driver, because of the missing arch-specific cleanup

Re: [RFC PATCH 0/1] iommu: Detach device from domain when removed from group

2015-08-03 Thread Gerald Schaefer
On Tue, 28 Jul 2015 19:55:55 +0200 Gerald Schaefer gerald.schae...@de.ibm.com wrote: Hi, during IOMMU API function testing on s390 I hit the following scenario: After binding a device to vfio-pci, the user completes the VFIO_SET_IOMMU ioctl and stops, see the sample C program below. Now

[RFC PATCH 1/1] iommu: Detach device from domain when removed from group

2015-07-28 Thread Gerald Schaefer
. Signed-off-by: Gerald Schaefer gerald.schae...@de.ibm.com --- drivers/iommu/iommu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index f286090..82ac8b3 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -447,6 +447,9 @@ rename

[RFC PATCH 0/1] iommu: Detach device from domain when removed from group

2015-07-28 Thread Gerald Schaefer
) { perror(ioctl VFIO_SET_IOMMU\n); return -1; } printf(Try device remove...\n); getchar(); close(group); close(container); return 0; } Gerald Schaefer (1): iommu: Detach device from domain when removed from group drivers

Re: [RFC PATCH 1/1] vfio-pci/iommu: Detach iommu group on remove path

2015-07-23 Thread Gerald Schaefer
On Wed, 22 Jul 2015 11:10:57 -0600 Alex Williamson alex.william...@redhat.com wrote: On Wed, 2015-07-22 at 10:54 -0600, Alex Williamson wrote: On Tue, 2015-07-21 at 19:44 +0200, Gerald Schaefer wrote: When a user completes the VFIO_SET_IOMMU ioctl and the vfio-pci device is removed

Re: [RFC PATCH 1/1] vfio-pci/iommu: Detach iommu group on remove path

2015-07-23 Thread Gerald Schaefer
On Wed, 22 Jul 2015 10:54:35 -0600 Alex Williamson alex.william...@redhat.com wrote: On Tue, 2015-07-21 at 19:44 +0200, Gerald Schaefer wrote: When a user completes the VFIO_SET_IOMMU ioctl and the vfio-pci device is removed thereafter (before any other ioctl like VFIO_GROUP_GET_DEVICE_FD

[RFC PATCH 0/1] vfio-pci/iommu: Detach iommu group on remove path

2015-07-21 Thread Gerald Schaefer
); if (rc) { perror(ioctl VFIO_SET_IOMMU\n); return -1; } printf(Try device remove...\n); getchar(); close(group); close(container); return 0; } Gerald Schaefer (1): vfio-pci/iommu: Detach iommu group on remove

[RFC PATCH 1/1] vfio-pci/iommu: Detach iommu group on remove path

2015-07-21 Thread Gerald Schaefer
() to the remove path, which will trigger the missing detach_dev callback in this scenario. Signed-off-by: Gerald Schaefer gerald.schae...@de.ibm.com --- drivers/vfio/vfio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 2fb29df..9c5c784 100644