[PATCH 1/2] provide a kvm_qemu_memory_alias() function

2008-10-02 Thread Glauber Costa
es it directly. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm-x86.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/qemu/qemu-kvm-x86.c b/qemu/qemu-kvm-x86.c index 5daedd1..9390a40 100644 --- a/qemu/qemu-kvm-x86.c +++ b/qemu/qemu-kvm-x86

[PATCH 2/2] fix compilation with --disable-kvm

2008-10-02 Thread Glauber Costa
Currently, kvm is failing to build with --disable-kvm. this patch fixes the issue. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/gdbstub.c | 15 ++- qemu/hw/acpi.c |6 +- qemu/hw/cirrus_vga.c |7 +++ qemu/monitor.c |6 +++

[PATCH 0/2] KVM failing to compile with --disable-kvm

2008-10-02 Thread Glauber Costa
Father Avi, is it better now? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] provide a kvm_qemu_memory_alias() function

2008-10-01 Thread Glauber Costa
On Wed, Oct 1, 2008 at 4:38 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: > Glauber Costa wrote: >> >> Following the pattern we already do, provide a qemu_kvm wrapper to >> the memory aliases x86 functions. Reason is that we don't want to have >> references to t

Re: [PATCH 0/2] --disable-kvm currently not working

2008-09-30 Thread Glauber Costa
On Tue, Sep 30, 2008 at 6:47 PM, Glauber Costa <[EMAIL PROTECTED]> wrote: > Current compilations with --disable-kvm are broken. > I'm spliting the fix in two patches for clearity. The first one > does some code movement in qemu-kvm-x86.c, while the other just > do fixes t

[PATCH 0/2] --disable-kvm currently not working

2008-09-30 Thread Glauber Costa
Current compilations with --disable-kvm are broken. I'm spliting the fix in two patches for clearity. The first one does some code movement in qemu-kvm-x86.c, while the other just do fixes to the current code base. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a

[PATCH] provide a kvm_qemu_memory_alias() function

2008-09-30 Thread Glauber Costa
es it directly. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm-x86.c |5 - qemu/qemu-kvm-x86.c | 12 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/libkvm/libkvm-x86.c b/libkvm/libkvm-x86.c index a8cca15..f33038d 100644 --- a/libkvm/l

[PATCH] fix compilation with --disable-kvm

2008-09-30 Thread Glauber Costa
Currently, kvm is failing to build with --disable-kvm. this patch fixes the issue. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/gdbstub.c | 15 ++- qemu/hw/acpi.c |6 +- qemu/hw/cirrus_vga.c |7 +++ qemu/monitor.c |6 +++

Re: kvm-76 --std-vga problem

2008-09-29 Thread Glauber Costa
On Mon, Sep 29, 2008 at 2:29 PM, Glauber Costa <[EMAIL PROTECTED]> wrote: > On Sun, Sep 28, 2008 at 6:44 PM, Michael Malone > <[EMAIL PROTECTED]> wrote: >> 2) (this has been around for quite some time, I just haven't done anything >> about it) >> Even th

Re: kvm-76 --std-vga problem

2008-09-29 Thread Glauber Costa
ked as already existant. There are some quick hacks, but I'll be trying to work on a proper fix in the following days. -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act." -- To unsubscribe from thi

Re: change in 'smp_cpus' at runtime vs vcpu_info?

2008-09-26 Thread Glauber Costa
On Fri, Sep 26, 2008 at 11:31 AM, Jes Sorensen <[EMAIL PROTECTED]> wrote: > Glauber Costa wrote: >> >> On Fri, Sep 26, 2008 at 11:17 AM, Jes Sorensen <[EMAIL PROTECTED]> wrote: >>> >>> Hi, >>> >>> Looking through the KVM qemu code,

Re: change in 'smp_cpus' at runtime vs vcpu_info?

2008-09-26 Thread Glauber Costa
sed on the smp_cpus value, and now are populated based on MAX_CPUS. -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act." -- To unsubscribe from this list: send the line "unsubscribe kvm" in the

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-25 Thread Glauber Costa
On Thu, Sep 25, 2008 at 10:08:53AM +0300, Avi Kivity wrote: > Glauber Costa wrote: > > > > Any ideas about what's up for the other hypervisors that may (we hope) be > > integrated > > in the future? Xen? > > > > Xen should benefit even more (much m

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-24 Thread Glauber Costa
On Wed, Sep 24, 2008 at 02:10:26PM +0300, Avi Kivity wrote: > Glauber Costa wrote: >>> You can't coalesce the registers which trigger device action. You'll >>> destroy latency and/or functionality. >>> >> >> which kills the goal of gettin

[PATCH] remove kvm_init_ap from qemu code.

2008-09-23 Thread Glauber Costa
Call it as a special case for cpu 0 creation. This removes a piece of kvm code from raw qemu. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c | 21 - qemu/qemu-kvm.h |1 - qemu/vl.c |3 --- 3 files changed, 12 insertions(+), 13 del

Re: Guest crash with 2.6.27-rc6 (a different one)

2008-09-23 Thread Glauber Costa
hardirqs_on_caller+0xf8/0x12d > [] shrink_inactive_list+0xdd/0x299 > [] shrink_zone+0xe7/0x106 > [] do_try_to_free_pages+0x17b/0x2b9 > [] try_to_free_pages+0x6c/0x74 > [] ? isolate_pages_global+0x0/0x43 > [] __alloc_pages_internal+0x22e/0x38a > [] __do_page_cache_readahead+0xd5/0x19e &

[PATCH 3/7] substitute is_allocated_mem with more general is_containing_region

2008-09-23 Thread Glauber Costa
is_allocated_mem is a function that checks if every relevant aspect of the memory slot match (start and size). Replace it with a more generic function that checks if a memory region is totally contained into another. The former case is also covered. Signed-off-by: Glauber Costa <[EM

[PATCH 4/7] add debuging facilities to memory registration at libkvm

2008-09-23 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index 11a9529..f7a7fdd 100644 --- a/libkvm/libkvm.c +++ b/libkvm/libkvm.c @@ -52,6 +52,15 @@ #includ

[PATCH 7/7] move kvm memory registration inside qemu's

2008-09-23 Thread Glauber Costa
Remove explicit calls to kvm_cpu_register_physical_memory, and bundle it together with qemu's memory registration function. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/exec.c |5 + qemu/hw/ipf.c |8 qemu/hw/pc.c

[PATCH 5/7] unregister memory area depending on their flags

2008-09-23 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 12 libkvm/libkvm.h |3 +++ qemu/qemu-kvm.c |7 +++ 3 files changed, 22 insertions(+), 0 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index f7a7fdd..88d3f5d 100644 --- a/

[PATCH 1/7] Don't separate registrations with IO_MEM_ROM set

2008-09-23 Thread Glauber Costa
Actually, all registrations are the same. If IO_MEM_ROM is set, we only need to take care of not passing its value as the phys_offset. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c | 31 +++ 1 files changed, 11 insertions(+), 20 del

[PATCH 0/7] Userspace memory registration

2008-09-23 Thread Glauber Costa
Hey folks, Userspace memory registration is back, now simpler due to some comments being addressed. we don't keep track of mmio regions at all now, which makes the code base even simpler. OTOH, mmio coalescing is left to a later work, since it now seems completely orthogonal to what I aim at this

[PATCH 6/7] register mmio slots

2008-09-23 Thread Glauber Costa
By analysing phys_offset, we know whether a region is an mmio region or not. If it is, we don't want to have kvm caring about it, so just return. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff -

[PATCH 2/7] do not use mem_hole anymore.

2008-09-23 Thread Glauber Costa
badly if the piece to be removed lies in the boundaries of the current slot. Luckily, we don't really need it. Remove it, and make sure we never hit it. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 69 +- libk

Re: [PATCH 7/9] register mmio slots

2008-09-23 Thread Glauber Costa
On Tue, Sep 23, 2008 at 10:31:30AM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> On Sat, Sep 20, 2008 at 11:38:22AM -0700, Avi Kivity wrote: >> >>> Glauber Costa wrote: >>> >>>> By analysing phys_offset, we know whether a region is an mmio

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-23 Thread Glauber Costa
On Tue, Sep 23, 2008 at 10:29:48AM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> On Sat, Sep 20, 2008 at 11:39:44AM -0700, Avi Kivity wrote: >> >>> Glauber Costa wrote: >>> >>>> Remove explicit calls to mmio coalescing. Rather,

Re: [PATCH 3/9] allow intersecting region to be on the boundary.

2008-09-23 Thread Glauber Costa
On Tue, Sep 23, 2008 at 01:30:41PM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> On Sat, Sep 20, 2008 at 11:32:48AM -0700, Avi Kivity wrote: >> >>> Glauber Costa wrote: >>> >>>> Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> >&

Re: [PATCH 4/9] substitute is_allocated_mem with more general is_containing_region

2008-09-23 Thread Glauber Costa
On Tue, Sep 23, 2008 at 10:35:24AM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> On Sat, Sep 20, 2008 at 11:33:56AM -0700, Avi Kivity wrote: >> >>> Glauber Costa wrote: >>> >>>> is_allocated_mem is a function that checks if every releva

Re: [PATCH 3/9] allow intersecting region to be on the boundary.

2008-09-22 Thread Glauber Costa
On Sat, Sep 20, 2008 at 11:32:48AM -0700, Avi Kivity wrote: > Glauber Costa wrote: >> Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> >> --- >> libkvm/libkvm.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libkv

Re: [PATCH 4/9] substitute is_allocated_mem with more general is_containing_region

2008-09-22 Thread Glauber Costa
On Sat, Sep 20, 2008 at 11:33:56AM -0700, Avi Kivity wrote: > Glauber Costa wrote: >> is_allocated_mem is a function that checks if every relevant aspect of the >> memory slot >> match (start and size). Replace it with a more generic function that checks >> if a

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-22 Thread Glauber Costa
On Sat, Sep 20, 2008 at 11:39:44AM -0700, Avi Kivity wrote: > Glauber Costa wrote: >> Remove explicit calls to mmio coalescing. Rather, >> include it in the registration functions. >> >> index 5ae3960..2d97b34 100644 >> --- a/qemu/hw/e1000.c >> +++

Re: [PATCH 7/9] register mmio slots

2008-09-22 Thread Glauber Costa
On Sat, Sep 20, 2008 at 11:38:22AM -0700, Avi Kivity wrote: > Glauber Costa wrote: >> By analysing phys_offset, we know whether a region is an mmio region >> or not. If it is, register it as so. We don't reuse the same slot >> infrastructure already existant, becau

Re: [PATCH 5/9] add debuging facilities to memory registration at libkvm

2008-09-22 Thread Glauber Costa
On Sat, Sep 20, 2008 at 11:34:55AM -0700, Avi Kivity wrote: > Glauber Costa wrote: >> +#ifdef DEBUG_MEMREG >> +fprintf(stderr, "%s, memory: gpa: %llx, size: %llx, uaddr: %llx, slot: >> %x, flags: %lx\n", >> +__func__, memor

[PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-19 Thread Glauber Costa
Remove explicit calls to mmio coalescing. Rather, include it in the registration functions. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/cirrus_vga.c |2 -- qemu/hw/e1000.c | 12 qemu/hw/pci.c|3 --- qemu/hw/vga.c|4 qem

[PATCH 9/9] move kvm memory registration inside qemu's

2008-09-19 Thread Glauber Costa
Remove explicit calls to kvm_cpu_register_physical_memory, and bundle it together with qemu's memory registration function. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/exec.c |5 + qemu/hw/ipf.c |8 qemu/hw/pc.c

[PATCH 1/9] Don't separate registrations with IO_MEM_ROM set

2008-09-19 Thread Glauber Costa
Actually, all registrations are the same. If IO_MEM_ROM is set, we only need to take care of not passing its value as the phys_offset. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c | 31 +++ 1 files changed, 11 insertions(+), 20 del

[PATCHEY 0/9] Rrrreplace the ol' scurvy memory registration

2008-09-19 Thread Glauber Costa
Yahoy mateys! I be now presentin'ya the last scurvy version of the ol'memory registration patches! He pilleage the ol'infrastructure and make me ship more consistent. All'of the ol'references to kvm_cpu_register_physical_memory() be trow to the salty sea, to the sharks! I be putin' all those scur

[PATCH 7/9] register mmio slots

2008-09-19 Thread Glauber Costa
ibkvm. However, we can do best in the future and use only a single data structure for both. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 70 +++--- qemu/qemu-kvm.c | 12 - 2 files changed, 76 insertions(+),

[PATCH 6/9] unregister memory area depending on their flags

2008-09-19 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 14 ++ libkvm/libkvm.h |3 +++ qemu/qemu-kvm.c |7 +++ 3 files changed, 24 insertions(+), 0 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index 222c858..6ebdc52 100644 --- a/

[PATCH 4/9] substitute is_allocated_mem with more general is_containing_region

2008-09-19 Thread Glauber Costa
is_allocated_mem is a function that checks if every relevant aspect of the memory slot match (start and size). Replace it with a more generic function that checks if a memory region is totally contained into another. The former case is also covered. Signed-off-by: Glauber Costa <[EM

[PATCH 5/9] add debuging facilities to memory registration at libkvm

2008-09-19 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index a5e20bb..222c858 100644 --- a/libkvm/libkvm.c +++ b/libkvm/libkvm.c @@ -52,6 +52,8 @@ #include &qu

[PATCH 2/9] do not use mem_hole anymore.

2008-09-19 Thread Glauber Costa
badly if the piece to be removed lies in the boundaries of the current slot. Luckily, we don't really need it. Remove it, and make sure we never hit it. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 69 +- qemu

[PATCH 3/9] allow intersecting region to be on the boundary.

2008-09-19 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index e768e44..fa65c30 100644 --- a/libkvm/libkvm.c +++ b/libkvm/libkvm.c @@ -130,8 +130,8

[PATCH] Don't destroy vcpu in case vcpu_setup fails

2008-09-17 Thread Glauber Costa
things. Rather, we just make return, making sure any needed uninitialization is done before we return, in case we fail. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- virt/kvm/kvm_main.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/virt/kvm/kvm_main.c

Re: [PATCH 1/9] Don't separate registrations with IO_MEM_ROM set

2008-09-15 Thread Glauber Costa
On Mon, Sep 15, 2008 at 03:08:01PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > On Sat, Sep 13, 2008 at 08:26:06AM +0200, Jan Kiszka wrote: > >> Glauber Costa wrote: > >>> On Fri, Sep 12, 2008 at 06:26:37PM +0200, Jan Kiszka wrote: > >>>> Glauber

Re: [Qemu-devel] Re: [PATCH] Make page_find() return 0 for too-large addresses

2008-09-15 Thread Glauber Costa
On Fri, Sep 12, 2008 at 04:27:30PM -0500, Anthony Liguori wrote: > Eduardo Habkost wrote: >> On Fri, Sep 12, 2008 at 05:14:06PM -0300, Eduardo Habkost wrote: >> >>> On Fri, Sep 12, 2008 at 02:50:33PM -0500, Anthony Liguori wrote: >>> Eduardo Habkost wrote: > On some cas

Re: [PATCH 1/9] Don't separate registrations with IO_MEM_ROM set

2008-09-15 Thread Glauber Costa
On Sat, Sep 13, 2008 at 08:26:06AM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > On Fri, Sep 12, 2008 at 06:26:37PM +0200, Jan Kiszka wrote: > >> Glauber Costa wrote: > >>> On Fri, Sep 12, 2008 at 05:47:40PM +0200, Jan Kiszka wrote: > >>>&g

Re: [PATCH 1/9] Don't separate registrations with IO_MEM_ROM set

2008-09-12 Thread Glauber Costa
On Fri, Sep 12, 2008 at 06:26:37PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > On Fri, Sep 12, 2008 at 05:47:40PM +0200, Jan Kiszka wrote: > >> Glauber Costa wrote: > >>> Actually, all registrations are the same. If IO_MEM_ROM is set, we only > >>

Re: [PATCH 1/9] Don't separate registrations with IO_MEM_ROM set

2008-09-12 Thread Glauber Costa
On Fri, Sep 12, 2008 at 05:47:40PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > Actually, all registrations are the same. If IO_MEM_ROM is set, we only > > need to take care of not passing its value as the phys_offset. > > As you are turning things upside down alrea

[PATCH 5/9] move kvm_cpu_register_memory_area into qemu's

2008-09-12 Thread Glauber Costa
mmio regions too. This is to be bisection friendly. Direct calls are to be removed in a later commit. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 84 -- libkvm/libkvm.h |6 qemu/exec.c |3 ++ qem

[PATCH 8/9] coalesce mmio regions without an explicit call

2008-09-12 Thread Glauber Costa
commit. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index 949a35b..106a3ee 100644 --- a/qemu/qemu-kvm.c +++ b/qemu/qemu-kvm.c @@ -795,6 +795,7 @

[PATCH 7/9] add debuging facilities to memory registration at libkvm

2008-09-12 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index 5df201e..8764982 100644 --- a/libkvm/libkvm.c +++ b/libkvm/libkvm.c @@ -52,6 +52,8 @@ #i

[PATCH 1/9] Don't separate registrations with IO_MEM_ROM set

2008-09-12 Thread Glauber Costa
Actually, all registrations are the same. If IO_MEM_ROM is set, we only need to take care of not passing its value as the phys_offset. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c | 31 +++ 1 files changed, 11 insertions(+), 20 del

[PATCH 9/9] remove explicit calls to kvm_qemu_register_coalesced_mmio

2008-09-12 Thread Glauber Costa
It is now done automatically for IO regions inside kvm_cpu_register_physical_memory(). --- qemu/hw/cirrus_vga.c |2 -- qemu/hw/e1000.c | 12 qemu/hw/pci.c|3 --- qemu/hw/vga.c|4 4 files changed, 0 insertions(+), 21 deletions(-) diff --git a/qe

[PATCH 3/9] allow intersecting region to be on the boundary.

2008-09-12 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index e768e44..fa65c30 100644 --- a/libkvm/libkvm.c +++ b/libkvm/libkvm.c @@ -130,8 +130,8

[PATCH 6/9] cleanup kvm memory registration

2008-09-12 Thread Glauber Costa
Remove all references to kvm_cpu_register_physical_memory(), since it is called from within cpu_register_physical_memory(). Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/exec.c |2 +- qemu/hw/ipf.c |8 qemu/hw/pc.c

[PATCH 2/9] do not use mem_hole anymore.

2008-09-12 Thread Glauber Costa
badly if the piece to be removed lies in the boundaries of the current slot. Luckily, we don't really need it. Remove it, and make sure we never hit it. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 69 +-

[PATCH 4/9] substitute is_allocated_mem with more general is_containing_region

2008-09-12 Thread Glauber Costa
is_allocated_mem is a function that checks if every relevant aspect of the memory slot match (start and size). Replace it with a more generic function that checks if a memory region is totally contained into another. The former case is also covered. Signed-off-by: Glauber Costa <[EM

[PATCH 0/9] Simplify memory registration

2008-09-12 Thread Glauber Costa
Hi guys This patchset simplifies memory registration even further. It's a respin of the one I've already sent, but now, without the kernel memory case, it's in definitive form. There are still some issues to be solved regarding the whole kvm memory thing (as aliases and logging, for example), bu

Re: RFC: VMX: initialize TSC offset relative to vm creation time

2008-09-10 Thread Glauber Costa
On Wed, Sep 10, 2008 at 05:58:42PM -0300, Marcelo Tosatti wrote: > > VMX initializes the TSC offset for each vcpu at different times, and > also reinitializes it for vcpus other than 0 on APIC SIPI message. > > This bug causes the TSC's to appear unsynchronized in the guest, even if > the host is

Re: [PATCH] remove KVM_CAP_USER_MEMORY reference from qemu-kvm.c

2008-09-10 Thread Glauber Costa
On Wed, Sep 10, 2008 at 09:23:18PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > From: Glauber Costa <[EMAIL PROTECTED]> > > > > kvm_cpu_register_physical_memory() is its only user. Remove it. > > > > Signed-off-by: Glauber Costa <[EMAIL PROTE

[PATCH 03/12] coalesce memory allocation

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Put all memory allocation under qemu_alloc_physram(). Protect the mem_area code with #ifdef USE_KVM. Although it is not really needed, it help us keep track of the fact that this is a kvm-only feature to the moment. Signed-off-by: Glauber Costa &

[PATCH 01/12] start removing kernel memory functions

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_arch_create_default_phys_mem and kvm_alloc_kernel_memory are legacy. Remove them, and their callers. The whole removal will be split for bisectability. These ones goes first because they are only called at initialization Signed-off-by: Glauber

[PATCH 04/12] remove KVM_CAP_USER_MEMORY reference from qemu-kvm.c

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_cpu_register_physical_memory() is its only user. Remove it. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c | 52 +--- 1 files changed, 21 insertions(+), 31 deleti

[PATCH 02/12] remove tests of user memory from vl.c

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_qemu_create_context() will fail if we don't have userspace memory capability, so no need to check it here. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/vl.c | 19 +-- 1 files changed, 5 insertions

[PATCH 06/12] remove create_kernel_phys_mem

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Wipe out create_kernel_phys_mem(), and all of its users. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/kvm-common.h |3 --- libkvm/libkvm-ia64.c|6 -- libkvm/libkvm-powerpc.c |7 --- libkvm/libkvm-s390

[PATCH 07/12] get rid of kvm_create_userspace_phys_mem

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> It is just kvm_create_phys_mem() right now. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c i

[PATCH 08/12] remove user_alloc field from slot representation

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> All allocations are "user" now. So we don't need this field anymore. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/kvm-common.h |2 +- libkvm/libkvm.c | 39 +++ 2 f

[PATCH 10/12] rename kvm_register_userspace_phys_mem

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Change its name to kvm_register_phys_mem(). Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c |2 +- libkvm/libkvm.h |2 +- qemu/qemu-kvm.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --

[PATCH 09/12] merge destroy phys mem functions

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_destroy_userspace_phys_mem() and kvm_destroy_phys_mem() can be merged into a single function, now that kernel allocation is no more. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/lib

[PATCH 12/12] remove kernel memory allocation code from ipf.c

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/ipf.c | 27 ++- 1 files changed, 6 insertions(+), 21 deletions(-) diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c index 2f7054c..d70af90 100644 --- a/qemu/hw

[PATCH 05/12] remove KVM_CAP_USER_MEMORY from libkvm.c.

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> One of them is left, which is the initial check. Code that does ioctl checking is left to be removed in a future commit. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 18 -- 1 files changed, 0 inser

[PATCH 11/12] remove kernel memory code from hw/pc.c

2008-09-10 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/pc.c | 19 ++- 1 files changed, 2 insertions(+), 17 deletions(-) diff --git a/qemu/hw/pc.c b/qemu/hw/pc.c index 026e96d..8a50096 100644 --- a/qemu/hw/pc.c +++ b/

[PATCH 0/12] get rid of kernel memory registration

2008-09-10 Thread Glauber Costa
Avi, I hope it is better now. For libkvm code, I'm still using tabs. For qemu, spaces. However, I'm not fixing places that were already using it. There are a lot of patches in flight right now, anthony's integration effort being the most significant ones, and simple whitespace fixes could break t

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Glauber Costa
On Wed, Sep 10, 2008 at 12:19 PM, Anthony Liguori <[EMAIL PROTECTED]> wrote: > Glauber Costa wrote: >> >> On Wed, Sep 10, 2008 at 10:26 AM, Chris Lalancette <[EMAIL PROTECTED]> >> wrote: >> >>> >>> Anthony Liguori wrote: >>> >>

Re: [Qemu-devel] [PATCH 4/10] Add dirty tracking for live migration

2008-09-10 Thread Glauber Costa
On Wed, Sep 10, 2008 at 11:56 AM, Anthony Liguori <[EMAIL PROTECTED]> wrote: > Glauber Costa wrote: >> >> On Tue, Sep 9, 2008 at 4:49 PM, Anthony Liguori <[EMAIL PROTECTED]> >> wrote: >> >>> >>> This patch adds a dirty tracking bit for liv

Re: [Qemu-devel] [PATCH 4/10] Add dirty tracking for live migration

2008-09-10 Thread Glauber Costa
ddr1)) { > +/* invalidate code */ > +tb_invalidate_phys_page_range(addr1, addr1 + 4, 0); > +/* set dirty bit */ > +phys_ram_dirty[addr1 >> TARGET_PAGE_BITS] |= > +(0xff & ~CODE_DIRTY_F

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Glauber Costa
on. >> >> N.B. we don't actually use this now. We really should flush the block >> drivers >> using an live savevm callback to avoid unnecessary guest down time. > > Simple enough, and follows the pattern in the KVM migration. > > Chris Lalancette > sound

Re: [PATCH 1/10] Refactor QEMUFile for live migration

2008-09-10 Thread Glauber Costa
> + > f->buf_index = 0; > f->buf_size = len; > f->buf_offset += len; > } > > -void qemu_fclose(QEMUFile *f) > +int qemu_fclose(QEMUFile *f) > { > -if (f->is_writable) > -qemu_fflush(f); > -if (f->is_file) { > -

Re: [PATCH 0/12] Get rid of kernel memory allocation

2008-09-09 Thread Glauber Costa
On Tue, Sep 09, 2008 at 05:25:09PM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> Hey guys, >> >> Some eons before the dinosaurs went extinct, we used to support >> a method of memory allocation different than the one advertised by >> KVM_CAP_USER_MEMORY. >

[PATCH] remove kernel memory code from hw/pc.c

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/pc.c | 19 ++- 1 files changed, 2 insertions(+), 17 deletions(-) diff --git a/qemu/hw/pc.c b/qemu/hw/pc.c index 026e96d..8a50096 100644 --- a/qemu/hw/pc.c +++ b/

[PATCH] remove KVM_CAP_USER_MEMORY reference from qemu-kvm.c

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_cpu_register_physical_memory() is its only user. Remove it. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c | 52 +--- 1 files changed, 21 insertions(+), 31 deleti

[PATCH] coalesce memory allocation

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Put all memory allocation under qemu_alloc_physram(). Protect the mem_area code with #ifdef USE_KVM. Although it is not really needed, it help us keep track of the fact that this is a kvm-only feature to the moment. Signed-off-by: Glauber Costa &

[PATCH] remove tests of user memory from vl.c

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_qemu_create_context() will fail if we don't have userspace memory capability, so no need to check it here. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/vl.c | 18 +- 1 files changed, 5 insertions

[PATCH 0/12] Get rid of kernel memory allocation

2008-09-08 Thread Glauber Costa
ugh an ABI check. But for now, I think this is enough. series stat: Glauber Costa (12): start removing kernel memory functions remove tests of user memory from vl.c coalesce memory allocation remove KVM_CAP_USER_MEMORY reference from qemu-kvm.c remove KVM_CAP_USER_M

[PATCH] get rid of kvm_create_userspace_phys_mem

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> It is just kvm_create_phys_mem() right now. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c i

[PATCH] start removing kernel memory functions

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_arch_create_default_phys_mem and kvm_alloc_kernel_memory are legacy. Remove them, and their callers. The whole removal will be split for bisectability. These ones goes first because they are only called at initialization Signed-off-by: Glauber

[PATCH] remove create_kernel_phys_mem

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Wipe out create_kernel_phys_mem(), and all of its users. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/kvm-common.h |3 --- libkvm/libkvm-ia64.c|6 -- libkvm/libkvm-powerpc.c |7 --- libkvm/libkvm-s390

[PATCH] rename kvm_register_userspace_phys_mem

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Change its name to kvm_register_phys_mem(). Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c |2 +- libkvm/libkvm.h |2 +- qemu/qemu-kvm.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --

[PATCH] remove KVM_CAP_USER_MEMORY from libkvm.c.

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> One of them is left, which is the initial check. Code that does ioctl checking is left to be removed in a future commit. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/libkvm.c | 18 -- 1 files changed, 0 inser

[PATCH] remove user_alloc field from slot representation

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> All allocations are "user" now. So we don't need this field anymore. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/kvm-common.h |2 +- libkvm/libkvm.c | 39 +++ 2 f

[PATCH] remove kernel memory allocation code from ipf.c

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/ipf.c | 25 + 1 files changed, 5 insertions(+), 20 deletions(-) diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c index 2f7054c..d979d4d 100644 --- a/qemu/hw/ipf.

[PATCH] merge destroy phys mem functions

2008-09-08 Thread Glauber Costa
From: Glauber Costa <[EMAIL PROTECTED]> kvm_destroy_userspace_phys_mem() and kvm_destroy_phys_mem() can be merged into a single function, now that kernel allocation is no more. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- libkvm/lib

Re: [PATCH] Fix up pxe boot

2008-09-08 Thread Glauber Costa
On Sun, Sep 07, 2008 at 09:42:07AM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> After a second look, here's what it seems to me: >> >> It's not in a generic place, such as ldl, because in general, we may want to >> grab >> a 32-bit value fro

Re: [PATCH] Fix up pxe boot

2008-09-03 Thread Glauber Costa
On Tue, Sep 02, 2008 at 06:20:55PM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> On Tue, Sep 2, 2008 at 5:39 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: >> >>> Glauber Costa wrote: >>> >>>> diff --git a/target-i386/op_helper.c b/target-

Re: [PATCH] Fix up pxe boot

2008-09-02 Thread Glauber Costa
On Tue, Sep 2, 2008 at 12:20 PM, Avi Kivity <[EMAIL PROTECTED]> wrote: > Glauber Costa wrote: >> >> On Tue, Sep 2, 2008 at 5:39 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: >> >>> >>> Glauber Costa wrote: >>> >>>> >>>&g

Re: [PATCH] Fix up pxe boot

2008-09-02 Thread Glauber Costa
On Tue, Sep 2, 2008 at 5:39 AM, Avi Kivity <[EMAIL PROTECTED]> wrote: > Glauber Costa wrote: >> >> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c >> index 0b5fdc0..433aa3f 100644 >> --- a/target-i386/op_helper.c >> +++ b/target-i38

[PATCH] Fix up pxe boot

2008-09-01 Thread Glauber Costa
POPL macro to a 32-bit value. This is also done, although just theorectically, for PUSHL too. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> Reported-by: Chris Lalancette <[EMAIL PROTECTED]> CC: Eduardo Habkost <[EMAIL PROTECTED]> --- target-i386/op_helper.c |4 ++-- 1 file

Re: serial/ rs232 and qemu /kvm?

2008-08-19 Thread Glauber Costa
warded to /dev/ttyS0 on > the host? check out for qemu's "-serial" option > > Marc Weber > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.ke

Re: Un-googlable

2008-08-16 Thread Glauber Costa
> Dave Abrahams > BoostPro Computing > http://www.boostpro.com > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- G

<    5   6   7   8   9   10   11   >