On Mon, Jun 6, 2011 at 11:37 AM, Cyrill Gorcunov gorcu...@gmail.com wrote:
On Mon, Jun 06, 2011 at 11:28:56AM +0300, Avi Kivity wrote:
On 06/03/2011 10:37 PM, Pekka Enberg wrote:
This patch fixes access to 'ah' in int10_vesa() by masking the high bits.
@@ -131,7 +131,7 @@ static void
...@suse.de
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/hw/vesa.c | 17 +
tools/kvm/include/kvm/kvm.h |1
...@suse.de
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
v1 - v2: Fix mem slot index passed to KVM_SET_USER_MEMORY_REGION
tools/kvm/hw/vesa.c
On Mon, 2011-06-06 at 15:56 +0200, Alexander Graf wrote:
@@ -216,7 +216,7 @@ void kvm__init_ram(struct kvm *kvm)
phys_size = kvm-ram_size - phys_size;
host_mem = kvm-ram_start + phys_start;
- kvm_register_mem_slot(kvm, 1, phys_start, phys_size,
On Mon, 2011-06-06 at 15:59 +0200, Alexander Graf wrote:
Please keep in mind that this is pretty fragile. It will probably work out
for you now, but memslots are
1) limited
I assume KVM_SET_USER_MEMORY_REGION doesn't fail silenty here?
2) don't deal with overlap
So please add at
...@suse.de
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
v2 - v3: Add comment that kvm__register_mem() doesn't support overlapping
memory
...@suse.de
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
v3 - v4: Fix overlapping memory region when guest has 4 GB of memory.
tools/kvm/hw/vesa.c
On Mon, Jun 6, 2011 at 7:06 PM, Sasha Levin levinsasha...@gmail.com wrote:
Currently VESA was mapping itself into 0xd000 which means that we'll
have an overlap when we're using more than 4GB.
Maybe we should increase our PCI gap size (which starts at 0xf000
currently) to include that
On Thu, Jun 2, 2011 at 11:22 PM, Sasha Levin levinsasha...@gmail.com wrote:
This patch adds a 'kvm debug' command that's currently an alias for
kill -USR2 `pidof kvm`
Which pauses a guest (freezes all VCPU threads).
Signed-off-by: Sasha Levin levinsasha...@gmail.com
What is this useful
On Fri, Jun 3, 2011 at 10:15 AM, Ingo Molnar mi...@elte.hu wrote:
I personally prefer the sizeof(*cache) variant for a subtle reason:
because during review it's easier to match up local variable names
than to match up types.
[snip, snip]
Aye, aye, cap'n!
As long as we have good volunteers
This patch introduces 'struct framebuffer' and related API as a preparational
step to killing libvnc dependency from hw/vesa.c.
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg
This patch adds support for SDL based framebuffer. Use the '--sdl' command line
option to enable the feature.
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb
This patch makes use of 'struct framebuffer' and moves the VNC code to ui/vnc.c
in preparation for other framebuffer output targets.
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka
console alongside with a graphic one.
Signed-off-by: John Floren j...@jfloren.net
[ turning code into patches and cleanup ]
Signed-off-by: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
Pekka
--
To unsubscribe from this list: send the line
On Fri, 3 Jun 2011, Ingo Molnar wrote:
i don't seem to be able to get the SDL window to inizialize over ssh
X-forwarding:
linux/tools/kvm ./kvm run --sdl
# kvm run -k ../../arch/x86/boot/bzImage -m 1216 -c 16
Warning: Unable to open /dev/net/tun
?
Please pass
-p console=ttyS0
On Fri, 3 Jun 2011, Ingo Molnar wrote:
It says:
[0.639000] vesafb: mode is 640x480x32, linelength=2560, pages=0
[0.64] vesafb: scrolling: redraw
[0.641000] vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16
[0.642000] vesafb: framebuffer at 0xd000, mapped to
On Fri, 3 Jun 2011, Ingo Molnar wrote:
Oh ... because the SDL library is not present on that box and it
silently did not get built.
Now *that* is not an obvious failure pattern ;-)
Oh, sorry about that. I'll just drop the '--sdl' command line option if
the library is not present. Does that
On Fri, 3 Jun 2011, Ingo Molnar wrote:
it would be better to display a meaningful error message in that case
and not run, the user very likely has added --sdl expecting a
framebuffer to pop up!
Is this better?
penberg@tiger:~/linux/tools/kvm$ ./kvm run --sdl -p root=/dev/vda1 -d
This patch fixes access to 'ah' in int10_vesa() by masking the high bits.
Cc: Ingo Molnar mi...@elte.hu
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/bios/int10.c |2
This patch cleans up the code in bios/int10.c without changing functionality.
Cc: Ingo Molnar mi...@elte.hu
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: John Floren j...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/bios/int10.c
...@jfloren.net
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/ui/sdl.c | 60 +--
1 files changed, 57 insertions(+), 3 deletions(-)
diff --git a/tools/kvm/ui/sdl.c b/tools/kvm/ui/sdl.c
index
On Wed, 1 Jun 2011, Sasha Levin wrote:
From: John Floren j...@jfloren.net
Add support for PS/2 keyboard system with AUX device (aka mouse).
The device works with vnc, the guest must be started with the
'--vnc' parameter for the device to be initialized.
Signed-off-by: John Floren
On Wed, 1 Jun 2011, Sasha Levin wrote:
As defined in the spec, the reserved space in struct vesa_general_info
should be used to store vesa oem string an a list of possible modes.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
Francis, could you test this, please? I sent you a copy of the
On Thu, 2 Jun 2011, Ingo Molnar wrote:
Since this is a PS2 keyboard and mouse driver please name it
i8042.[ch] like the kernel-side does.
that will also make it easier to find the guest-side - host-side
pair of guest-driver/host-driver files :-)
Fixed, thanks!
--
To unsubscribe from this
On Thu, 2 Jun 2011, Sasha Levin wrote:
Strange, those are the same errors you're supposed to get when theres no
i8042 device at all.
Could you verify that hw/pckbd.c is being built? Did the makefile get
updated?
What I'm seeing here is:
[ 49.326316] i8042: PNP: No PS/2 controller found.
On Thu, 2011-06-02 at 11:18 +0200, Ingo Molnar wrote:
* Pekka Enberg penb...@kernel.org wrote:
On Thu, 2 Jun 2011, Sasha Levin wrote:
Strange, those are the same errors you're supposed to get when theres no
i8042 device at all.
Could you verify that hw/pckbd.c is being built? Did
This patch sorts the status register bits in preparation for switching over to
kernel constant names.
Cc: Ingo Molnar mi...@elte.hu
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/hw/i8042.c |9 ++---
1 files changed, 6 insertions
This patch renames the status register bit constant names to be identical with
drivers/input/serio/i8042.h. This makes code review easier.
Cc: Ingo Molnar mi...@elte.hu
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/hw/i8042.c | 18
This patch renames the command constants in hw/i8042.c to use similar names as
in linux/i8042.h. Note: we cannot use linux/i8042.h constants directly
because they include the command and data.
Cc: Ingo Molnar mi...@elte.hu
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb
On Thu, Jun 2, 2011 at 2:19 PM, Ingo Molnar mi...@elte.hu wrote:
ok, with the shared commands it place here's some
feature-completeness comparison of the kernel driver and the
emulator:
guest driver i8042.h | hw/i8042.c emu
/*
* Status register bits
*/
in the switch statement was never executed.
Cc: Ingo Molnar mi...@elte.hu
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/hw/i8042.c | 48 +---
1 files changed, 29 insertions(+), 19 deletions(-)
diff
On Thu, Jun 2, 2011 at 4:40 PM, Ingo Molnar mi...@elte.hu wrote:
+ case I8042_COMMAND_REG: {
+ u8 value = kbd_read_status();
+ ioport__write8(data, value);
+ break;
+ }
+ case I8042_DATA_REG: {
+ u32 value = kbd_read_data();
+
On Thu, Jun 2, 2011 at 11:01 PM, Prasad Joshi prasadjoshi...@gmail.com wrote:
QCOW uses two tables level1 (L1) table and level2 (L2) table. The L1 table
points to offset of L2 table. When a QCOW image is probed, the L1 table is
cached in the memory to avoid reading it from disk on every access.
On Thu, Jun 2, 2011 at 11:01 PM, Prasad Joshi prasadjoshi...@gmail.com wrote:
There is not much difference with sequential character operations are
performed, the code with caching performed better by small margin. The caching
code performance raised by 18% to 24% with sequential block output
On Fri, Jun 3, 2011 at 12:19 AM, Sasha Levin levinsasha...@gmail.com wrote:
+static int cache_table(struct qcow *q, u64 *table, u64 offset)
+{
+ struct qcow_l2_cache *n;
+ struct rb_root *r = q-root;
+ struct qcow_l2_cache *lru;
+
+ n = calloc(1, sizeof(struct
On Tue, May 31, 2011 at 2:53 AM, Asias He asias.he...@gmail.com wrote:
TAP based network performance with ioeventfd
Heh, so how did it look _before_ ioeventfd? Did performance improve
and how much?
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to
Hi Francis,
[ Please remember to CC me and/or other tools/kvm developers for bug reports. ]
On Mon, May 30, 2011 at 9:55 AM, Francis Moreau francis.m...@gmail.com wrote:
I just wanted to give kvm-tool a try and it unfortunately seems to be
stuck somewhere:
$ ./kvm run --disk linux-0.2.img
Hi Francis,
On Mon, May 30, 2011 at 10:30 AM, Francis Moreau francis.m...@gmail.com wrote:
Nothing. That looks like a bug. Could you try to do
kill -3 `pidof kvm`
Here it is:
#
# vCPU #0's dump:
#
Registers:
--
rip: rsp: 7e3a flags:
On Mon, May 30, 2011 at 11:43 AM, Ingo Molnar mi...@elte.hu wrote:
Testing idea: for example 'make test locking' could do the bzImage
test-bootup, with rwlocks built instead of the brlocksj?
Pekka might have more ideas about how a good locking test-suite
should be done, as JATO has one,
Hi Sasha,
On Mon, May 30, 2011 at 12:34 PM, Sasha Levin levinsasha...@gmail.com wrote:
It would mean we need that many VCPUs: current br_read_lock() doesn't
really do anything, which means that running these tests with dummy
threads won't work.
Heh, sure they're doing something - they're
On Mon, May 30, 2011 at 12:46 PM, Sasha Levin levinsasha...@gmail.com wrote:
I'm just saying that we're limited to as many VCPU threads as we can
create. br_read_lock() won't do anything on a non-VCPU thread, which
makes it impossible to test it on non-VCPUs.
It sure would be useful to be able
On Mon, May 30, 2011 at 3:23 PM, Avi Kivity a...@redhat.com wrote:
IIRC there never was a memset() of all RAM, at least since kvm started
booting Linux. Windows has a zeroing thread which causes all of RAM to be
committed shortly after boot, though.
Yup, I haven't heard of such thing either.
On Fri, 2011-05-27 at 18:52 +0200, Ingo Molnar wrote:
In such cases it would *really* be useful, in addition of dumping
80-100 raw numbers to summarize results and compare them for the
reader, as i suspect you've done already? Please don't keep it a
secret and don't force the reader to
On Fri, May 27, 2011 at 1:36 PM, Sasha Levin levinsasha...@gmail.com wrote:
+void ioeventfd__start(void)
+{
+ pthread_t thread;
+
+ pthread_create(thread, NULL, ioeventfd__thread, NULL);
Please be more careful with error handling. If an API call can fail,
there's almost never any
Hi Ingo,
On Fri, May 27, 2011 at 1:54 PM, Ingo Molnar mi...@elte.hu wrote:
A sidenote: i think 'struct kvm *kvm' was a naming mistake - it's way
too aspecific, it tells us nothing. What is a 'kvm'?
Why, an instance of a kernel virtual machine, of course! It was the
very first thing I wrote for
On Thu, 2011-05-26 at 09:42 +0300, Sasha Levin wrote:
Allow specifying an optional parameter when registering an
ioport range. The callback functions provided by the registering
module will be called with the same parameter.
This may be used to keep context during callbacks on IO operations.
On Thu, May 26, 2011 at 12:02 PM, Sasha Levin levinsasha...@gmail.com wrote:
On Thu, 2011-05-26 at 11:53 +0300, Pekka Enberg wrote:
On Thu, 2011-05-26 at 09:42 +0300, Sasha Levin wrote:
Allow specifying an optional parameter when registering an
ioport range. The callback functions provided
On Thu, May 26, 2011 at 12:14 PM, Sasha Levin levinsasha...@gmail.com wrote:
I've wanted to keep the original interface clean, Most of the IO port
users don't (and probably won't) require a parameter.
Well now struct ioport_operations isn't very clean is it - or the code
that needs to
On Thu, May 26, 2011 at 12:38 PM, Sasha Levin levinsasha...@gmail.com wrote:
One option here is to rename 'struct ioport_entry' to 'struct ioport'
and pass a pointer to that as the first argument to all of the ops.
That's what most APIs in the kernel do anyway.
Why do it like that? this way
that? this way users of the callback functions will need
to know the internal structure of struct ioport_entry.
On Thu, May 26, 2011 at 12:43 PM, Pekka Enberg penb...@kernel.org wrote:
Look at 'struct inode' or similar data structure in the kernel. That's
how we do it. You can then also do s/params
On Thu, 26 May 2011, Sasha Levin wrote:
Makes ioport thread-safe.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
---
tools/kvm/ioport.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/tools/kvm/ioport.c b/tools/kvm/ioport.c
index 1f13960..db9ff0f 100644
---
On Thu, 26 May 2011, Sasha Levin wrote:
Adds a rwlock wrapper which like the mutex wrapper makes rwlock calls
similar to their kernel counterparts.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
There's no explanation why a mutex isn't sufficient. The pthread locking
primitives aren't
On Thu, May 26, 2011 at 9:11 PM, Avi Kivity a...@redhat.com wrote:
On 05/26/2011 09:05 PM, Ingo Molnar wrote:
I've added some rwlocks because of what Ingo said yesterday about
adding/removing devices after the first initialization phase.
Take MMIO lock for example: Since we can now
On Tue, May 24, 2011 at 12:10 PM, Paolo Bonzini pbonz...@redhat.com wrote:
I know portability is not relevant to tools/kvm/, but using unportable
tricks for the sake of using them is a direct way to NIH. But oh well all
of tools/kvm/ is NIH after all. :)
Hmm?
The point is to follow Linux
Hi Avi,
On Tue, May 24, 2011 at 2:22 PM, Avi Kivity a...@redhat.com wrote:
The point is to follow Linux kernel conventions and idioms (and share
code) as much as possible so it's familiar to devs who are already
working on the kernel. That's why section tricks seem more appropriate
than using
Hi Avi,
On Tue, May 24, 2011 at 2:30 PM, Avi Kivity a...@redhat.com wrote:
What happens when you start using userspace libraries?
Eventually you'll have a lot more of that than kernel code.
I don't quite understand what problems you think we might have. We're
already using userspace libraries
Hi Avi,
On Tue, May 24, 2011 at 2:41 PM, Avi Kivity a...@redhat.com wrote:
I don't quite understand what problems you think we might have. We're
already using userspace libraries (libvnc) and most of us code is
non-kernel code.
If uint64_t is defined differently than u64, you won't be able
Hi Avi,
On Tue, May 24, 2011 at 5:37 PM, Avi Kivity a...@redhat.com wrote:
Another thing, I believe reuse of actual kernel code has limited utility.
OK, I don't agree with that.
On Tue, May 24, 2011 at 5:37 PM, Avi Kivity a...@redhat.com wrote:
The kernel has vast infrastructure and porting
On 5/23/11 2:38 PM, Ingo Molnar wrote:
* Sasha Levinlevinsasha...@gmail.com wrote:
@@ -511,7 +515,13 @@ int kvm_cmd_run(int argc, const char **argv, const char
*prefix)
kvm-nrcpus = nrcpus;
memset(real_cmdline, 0, sizeof(real_cmdline));
- strcpy(real_cmdline, notsc
On Mon, May 23, 2011 at 2:19 PM, Sasha Levin levinsasha...@gmail.com wrote:
Requirements - Kernel compiled with:
CONFIG_FB_BOOT_VESA_SUPPORT=y
CONFIG_FB_VESA=y
CONFIG_FRAMEBUFFER_CONSOLE=y
Dunno if it's possible but it would be nice to have a more readable
error message if you don't have that
On Sat, May 21, 2011 at 3:10 PM, Cyrill Gorcunov gorcu...@gmail.com wrote:
Without 'ret' usage I get
| cyrill@sun kvm $ make
| CC virtio/9p.o
| virtio/9p.c: In function ‘virtio_p9_wstat’:
| virtio/9p.c:448:6: error: variable ‘res’ set but not used
On Fri, May 20, 2011 at 10:01 AM, Amerigo Wang amw...@redhat.com wrote:
'kvm run --help' works fine but 'kvm help run' shows nothing,
this patch implements it.
Signed-off-by: WANG Cong amw...@redhat.com
Looks good to me. Prasad?
---
diff --git a/tools/kvm/include/kvm/kvm-cmd.h
On Fri, 20 May 2011, Sasha Levin wrote:
This is the implementation of (most of) the original
9p2000 protocol, without the .u or the .l extensions.
How to use:
1. Make sure kernel is compiled with:
CONFIG_NET_9P=y
CONFIG_NET_9P_VIRTIO=y
CONFIG_NET_9P_DEBUG=y (At least until code is
On Tue, May 17, 2011 at 9:35 PM, Sasha Levin levinsasha...@gmail.com wrote:
Overview:
9p allows for simple RPC based resource sharing over
different transports (in our case, virtio).
This is the implementation of (most of) the original
9p2000 protocol, without the .u or the .l extensions.
On Wed, May 18, 2011 at 1:17 PM, Prasad Joshi prasadjoshi...@gmail.com wrote:
Add a new function virtio_blk__fini() which goes
through array of block devices and releases
memory allocated for block device.
Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com
@@ -6,5 +6,6 @@
struct kvm;
On Wed, May 18, 2011 at 1:17 PM, Prasad Joshi prasadjoshi...@gmail.com wrote:
QCOW uses two tables level1 (L1) table and level2
(L2) table. The L1 table points to offset of L2
table. When a QCOW image is probed, the L1 table is
cached in the memory to avoid reading it from disk
on every
On Wed, May 18, 2011 at 1:35 PM, Sasha Levin levinsasha...@gmail.com wrote:
I'm not sure how to do the guest part automatically, it's just a simple
mount command - but I don't see how we can do it in a simple manner.
IIRC, Ingo suggested a kernel config option - a kernel parameter might
also
On Wed, May 18, 2011 at 1:41 PM, Prasad Joshi prasadjoshi...@gmail.com wrote:
On Wed, May 18, 2011 at 11:27 AM, Pekka Enberg penb...@kernel.org wrote:
On Wed, May 18, 2011 at 1:17 PM, Prasad Joshi prasadjoshi...@gmail.com
wrote:
QCOW uses two tables level1 (L1) table and level2
(L2) table
asias.he...@gmail.com
Cc: Avi Kivity a...@redhat.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Prasad Joshi prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Reported-by: born2bef...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm
On Tue, May 17, 2011 at 11:05 AM, Ingo Molnar mi...@elte.hu wrote:
* Sasha Levin levinsasha...@gmail.com wrote:
On Tue, 2011-05-17 at 09:41 +0200, Ingo Molnar wrote:
* Sasha Levin levinsasha...@gmail.com wrote:
+#include kvm/interval-rbtree.h
+#include stdio.h
+#include stdlib.h
On Fri, May 13, 2011 at 11:19 AM, Ingo Molnar mi...@elte.hu wrote:
@@ -162,7 +162,7 @@ static void kvm_register_mem_slot(struct kvm *kvm, u32
slot, u64 guest_phys, u64
.slot = slot,
.guest_phys_addr = guest_phys,
On 5/13/11 5:40 AM, Asias He wrote:
commit b764422bb0b46b00b896f6d4538ac3d3dde9e56b
(kvm tools: Add support for multiple virtio-blk)
removed the VIRTIO_BLK_F_SEG_MAX publishment to guest.
There is no reason we should not support it. Just bring it back.
Signed-off-by: Asias
On 5/11/11 12:06 PM, Avi Kivity wrote:
Well, I guess you can map the framebuffer lower, but that means giving
up memory hotplug if you ever wish to implement it (and doesn't allow
the guest to remap the framebuffer if it wishes to).
True. As I said, we need to do it properly at some point.
On Wed, 11 May 2011, Ingo Molnar wrote:
Ok, with your fixes applied i can boot a 10 GB RAM guest just fine - both the
hang and the later IO errors and IO corruptions are gone:
[root@aldebaran ~]# free
total used free sharedbuffers cached
Mem: 10019972
On 5/11/11 9:21 AM, Sasha Levin wrote:
If you feel the 512MB vs guest_flat_to_host() trade-off is worth it,
I'll change it to work that way.
Why would it not be? This is 64-bit only, right? There's plenty of
virtual address
space and mprotect() should make sure we never allocate physical
On Wed, May 11, 2011 at 12:05 AM, Sasha Levin levinsasha...@gmail.com wrote:
+ if (kvm-ram_size 0xe000) {
Please use the ULL postfix for constants to ensure the types are sane.
Also, please come up with a sane name for these.
@@ -60,7 +60,14 @@ static inline u32 segment_to_flat(u16
Fix up coding style issues in QCOW code.
Cc: Asias He asias.he...@gmail.com
Cc: Avi Kivity a...@redhat.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Prasad Joshi prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb
...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/kvm-run.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/kvm/kvm-run.c b/tools/kvm/kvm-run.c
index 829b33f..9b5176f 100644
--- a/tools/kvm/kvm-run.c
: Asias He asias.he...@gmail.com
Cc: Avi Kivity a...@redhat.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Prasad Joshi prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/kvm-run.c |2 ++
1
: Avi Kivity a...@redhat.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Prasad Joshi prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/Makefile |2 +
tools/kvm/include/kvm/kvm.h
On Wed, May 11, 2011 at 12:05 AM, Sasha Levin levinsasha...@gmail.com wrote:
queue-pfn may be used to point at addresses larger
than 32 bit.
Prevent a wraparound when shifting it left.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
---
tools/kvm/virtio/blk.c | 2 +-
Document KVM_CAP_NR_VCPUS that can be used by the userspace to determine
maximum number of VCPUs it can create with the KVM_CREATE_VCPU ioctl.
Cc: Avi Kivity a...@redhat.com
Cc: Marcelo Tosatti mtosa...@redhat.com
Cc: Jan Kiszka jan.kis...@web.de
Signed-off-by: Pekka Enberg penb...@kernel.org
From: Cyrill Gorcunov gorcu...@gmail.com
Subject: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique v2
PCI device numbers must be unique on a bus (as a part
of Bus/Device/Function tuple).Make it so. Note the patch
is rather a fast fix since we need a bit more smart pci device
Hi!
We've noticed that sometimes KVM_GET_SREGS from a signal handler
hangs. We use it like this:
static void handle_sigquit(int sig)
{
int i;
for (i = 0; i nrcpus; i++) {
struct kvm_cpu *cpu = kvm_cpus[i];
kvm_cpu__show_registers(cpu); --
On Sun, May 8, 2011 at 11:50 AM, Avi Kivity a...@redhat.com wrote:
On 05/08/2011 11:24 AM, Pekka Enberg wrote:
Hi!
We've noticed that sometimes KVM_GET_SREGS from a signal handler
hangs. We use it like this:
static void handle_sigquit(int sig)
{
int i;
for (i = 0; i
...@elte.hu
Cc: Prasad Joshi prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/kvm-run.c | 20 +---
1 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/tools/kvm/kvm-run.c b/tools/kvm/kvm-run.c
On Sun, 2011-05-08 at 21:09 +0800, Asias He wrote:
As virtio spec says:
Because this is high importance and low bandwidth, the current Linux
implementation polls for the buffer to be used, rather than waiting
for an interrupt, simplifying the implementation signicantly.
On Sun, May 8, 2011 at 8:21 PM, Sasha Levin levinsasha...@gmail.com wrote:
I'm seeing no more hangs, but why enable it unconditionally?
Maybe enable it by default, but we shouldn't force the activation of
virtio modules if the user doesn't want them.
I meant enabling the device on PCI bus like
On Sun, May 8, 2011 at 8:29 PM, Sasha Levin levinsasha...@gmail.com wrote:
On Sun, 2011-05-08 at 20:28 +0300, Pekka Enberg wrote:
On Sun, May 8, 2011 at 8:21 PM, Sasha Levin levinsasha...@gmail.com wrote:
I'm seeing no more hangs, but why enable it unconditionally?
Maybe enable it by default
On Sun, 2011-05-08 at 20:35 +0300, Sasha Levin wrote:
I fully support enabling it by default, I'm against enabling it even if
the user asked to have it disabled.
Sure.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More
On Fri, 6 May 2011, Sasha Levin wrote:
Use /dev/block to find the block device used for root
instead of searching through mounts.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
Weren't there distro differences in this area? Prasad, Asias, does this
work for you?
--
To unsubscribe from
On Sat, 7 May 2011, Ingo Molnar wrote:
Very nice!
Btw., do we have a firm resolution for the ping latency problem that the virtio
ring-buffer and net driver suffered from? If it's fixed, which commit fixed the
root cause?
Oh, it seems that the patches fixed the ping -f problems for me! Asias,
On Fri, 6 May 2011, Sasha Levin wrote:
+int irq__register_device(u32 dev, u8 *num, u8 *pin, u8 *line)
+{
+ struct pci_dev *node;
+
+ node = search(pci_tree, dev);
+
+ if (!node) {
+ /* We haven't found a node - First device of it's kind */
+ node =
Hi!
Documentation/kvm/api.txt says the following:
4.6 KVM_CREATE_VCPU
Capability: basic
Architectures: all
Type: vm ioctl
Parameters: vcpu id (apic id on x86)
Returns: vcpu fd on success, -1 on error
This API adds a vcpu to a virtual machine. The vcpu id is a small integer
in
On Sat, 2011-05-07 at 13:34 +0300, Sasha Levin wrote:
Why was this change only implemented in virtio-net? shouldn't it go to
the other virtio drivers as well?
Yes, definitely.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
...@gmail.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Prasad Joshi prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Suggested-by: Ingo Molnar mi...@elte.hu
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/kvm-run.c | 26
prasadjoshi...@gmail.com
Cc: Sasha Levin levinsasha...@gmail.com
Signed-off-by: Pekka Enberg penb...@kernel.org
---
tools/kvm/include/kvm/kvm.h |1 +
tools/kvm/kvm-run.c | 10 +-
tools/kvm/kvm.c | 11 +++
3 files changed, 21 insertions(+), 1 deletions
Document KVM_CAP_NR_VCPUS that can be used by the userspace to determine
maximum number of VCPUs it can create with the KVM_CREATE_VCPU ioctl.
Cc: Avi Kivity a...@redhat.com
Cc: Marcelo Tosatti mtosa...@redhat.com
Cc: Jan Kiszka jan.kis...@web.de
Signed-off-by: Pekka Enberg penb...@kernel.org
On Sat, 2011-05-07 at 13:12 +0200, Jan Kiszka wrote:
On 2011-05-07 12:16, Pekka Enberg wrote:
Hi!
Documentation/kvm/api.txt says the following:
4.6 KVM_CREATE_VCPU
Capability: basic
Architectures: all
Type: vm ioctl
Parameters: vcpu id (apic id on x86)
Returns
On Sat, 2011-05-07 at 08:14 -0500, Anthony Liguori wrote:
It seems like this patch is simply avoiding raising the interrupt line
if the ISR has not been acknowledged yet. I don't think there's a
functional issue here but I'm surprised that it's a win. There should
be a very short window
501 - 600 of 746 matches
Mail list logo
