Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-30 Thread Dor Laor
On 09/29/2009 05:50 PM, Lucas Meneghel Rodrigues wrote: On Fri, 2009-09-25 at 05:22 -0400, Jiri Zupka wrote: - Dor Laordl...@redhat.com wrote: On 09/16/2009 04:09 PM, Jiri Zupka wrote: - Dor Laordl...@redhat.com wrote: On 09/15/2009 09:58 PM, Jiri Zupka wrote: After a quick

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-29 Thread Lucas Meneghel Rodrigues
On Fri, 2009-09-25 at 05:22 -0400, Jiri Zupka wrote: - Dor Laor dl...@redhat.com wrote: On 09/16/2009 04:09 PM, Jiri Zupka wrote: - Dor Laordl...@redhat.com wrote: On 09/15/2009 09:58 PM, Jiri Zupka wrote: After a quick review I have the following questions: 1. Why

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-25 Thread Jiri Zupka
- Dor Laor dl...@redhat.com wrote: On 09/16/2009 04:09 PM, Jiri Zupka wrote: - Dor Laordl...@redhat.com wrote: On 09/15/2009 09:58 PM, Jiri Zupka wrote: After a quick review I have the following questions: 1. Why did you implement the guest tool in 'c' and not in python?

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-16 Thread Dor Laor
On 09/15/2009 09:58 PM, Jiri Zupka wrote: After a quick review I have the following questions: 1. Why did you implement the guest tool in 'c' and not in python? Python is much simpler and you can share some code with the server. This 'test protocol' would also be easier to understand this

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-16 Thread Jiri Zupka
- Dor Laor dl...@redhat.com wrote: On 09/15/2009 09:58 PM, Jiri Zupka wrote: After a quick review I have the following questions: 1. Why did you implement the guest tool in 'c' and not in python? Python is much simpler and you can share some code with the server. This 'test

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-16 Thread Dor Laor
On 09/16/2009 04:09 PM, Jiri Zupka wrote: - Dor Laordl...@redhat.com wrote: On 09/15/2009 09:58 PM, Jiri Zupka wrote: After a quick review I have the following questions: 1. Why did you implement the guest tool in 'c' and not in python? Python is much simpler and you can share some

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-15 Thread Jiri Zupka
After a quick review I have the following questions: 1. Why did you implement the guest tool in 'c' and not in python? Python is much simpler and you can share some code with the server. This 'test protocol' would also be easier to understand this way. We need speed and the precise

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-07 Thread Dor Laor
On 08/31/2009 12:35 PM, Lukáš Doktor wrote: allocator.c is a program, which allocates pages in the memory and allow us to fill or test those pages. It's controlled using sockets. After a quick review I have the following questions: 1. Why did you implement the guest tool in 'c' and not in

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-09-01 Thread Lukáš Doktor
I'm sorry but thunderbird apparently crippled the path. Resending as the attachment. diff --git a/client/tests/kvm/allocator.c b/client/tests/kvm/allocator.c new file mode 100644 index 000..89e8ce4 --- /dev/null +++ b/client/tests/kvm/allocator.c @@ -0,0 +1,571 @@ +/* + * KSM test program. +

Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

2009-08-31 Thread Lukáš Doktor
allocator.c is a program, which allocates pages in the memory and allow us to fill or test those pages. It's controlled using sockets. Signed-off-by: Lukáš Doktor ldok...@redhat.com Signed-off-by: Jiří Župka jzu...@redhat.com --- client/tests/kvm/allocator.c | 571