Re: [PATCH] Handle vma regions with no backing page

2008-06-04 Thread Avi Kivity
Ben-Ami Yassour wrote: Anthony Liguori [EMAIL PROTECTED] wrote on 04/29/2008 05:32:09 PM: Subject [PATCH] Handle vma regions with no backing page This patch allows VMA's that contain no backing page to be used for guest memory. This is a drop-in replacement for Ben-Ami's first page in his

Re: [PATCH] Handle vma regions with no backing page

2008-06-04 Thread Ben-Ami Yassour
On Tue, 2008-06-03 at 13:39 +0200, Andrea Arcangeli wrote: On Tue, Jun 03, 2008 at 02:17:55PM +0300, Ben-Ami Yassour wrote: Anthony Liguori [EMAIL PROTECTED] wrote on 04/29/2008 05:32:09 PM: Subject [PATCH] Handle vma regions with no backing page This patch allows VMA's that contain

Re: [PATCH] Handle vma regions with no backing page

2008-06-04 Thread Anthony Liguori
Avi Kivity wrote: Looks like we need to reintroduce a refcount bit in the pte, and check the page using the VMA. I don't think mucking with the VMA is going to help. We're already using the VMA to determine that the region is MMIO. What we need to be able to do is figure out, given a

Re: [PATCH] Handle vma regions with no backing page

2008-06-04 Thread Muli Ben-Yehuda
On Wed, Jun 04, 2008 at 06:09:24PM +0300, Ben-Ami Yassour1 wrote: We noticed that pfn_valid does not always works as expected by this patch to indicate that a pfn has a backing page. We have seen a case where CONFIG_NUMA was not set and then where pfn_valid returned 1 for an mmio

Re: [PATCH] Handle vma regions with no backing page

2008-06-04 Thread Andrea Arcangeli
On Wed, Jun 04, 2008 at 07:17:55PM +0300, Muli Ben-Yehuda wrote: On Wed, Jun 04, 2008 at 06:09:24PM +0300, Ben-Ami Yassour1 wrote: We noticed that pfn_valid does not always works as expected by this patch to indicate that a pfn has a backing page. We have seen a case where

Re: [PATCH] Handle vma regions with no backing page

2008-06-04 Thread Andrea Arcangeli
On Wed, Jun 04, 2008 at 02:41:20PM -0500, Anthony Liguori wrote: The pfn does have a backing page. When using CONFIG_FLATMEM, pfn_valid() is simply: #ifdef CONFIG_FLATMEM #define pfn_valid(pfn) ((pfn) end_pfn) #endif And this is true, pfn_valid() just indicates whether there is

Re: [PATCH] Handle vma regions with no backing page

2008-06-04 Thread Dave Hansen
On Wed, 2008-06-04 at 21:51 +0200, Andrea Arcangeli wrote: Dave mentioned that SetPageReserved() doesn't necessarily get called for zones with bad alignment. What does 'bad alignment' mean? Buddy was used to require each zone to start at 1MAX_ORDER naturally aligned physical address (any

Re: [PATCH] Handle vma regions with no backing page

2008-06-03 Thread Ben-Ami Yassour
Anthony Liguori [EMAIL PROTECTED] wrote on 04/29/2008 05:32:09 PM: Subject [PATCH] Handle vma regions with no backing page This patch allows VMA's that contain no backing page to be used for guest memory. This is a drop-in replacement for Ben-Ami's first page in his direct mmio series. Here

Re: [PATCH] Handle vma regions with no backing page

2008-06-03 Thread Andrea Arcangeli
On Tue, Jun 03, 2008 at 02:17:55PM +0300, Ben-Ami Yassour wrote: Anthony Liguori [EMAIL PROTECTED] wrote on 04/29/2008 05:32:09 PM: Subject [PATCH] Handle vma regions with no backing page This patch allows VMA's that contain no backing page to be used for guest memory. This is a drop