Re: [PATCH] KVM: Eliminate extra function calls in kvm_get_dirty_log_protect()

2015-03-18 Thread Marcelo Tosatti
On Tue, Mar 17, 2015 at 09:58:21AM +0100, Paolo Bonzini wrote: > > > On 17/03/2015 08:19, Takuya Yoshikawa wrote: > > When all bits in mask are not set, > > kvm_arch_mmu_enable_log_dirty_pt_masked() has nothing to do. But since > > it needs to be called from the generic code, it cannot be inline

Re: [PATCH] KVM: Eliminate extra function calls in kvm_get_dirty_log_protect()

2015-03-17 Thread Paolo Bonzini
On 17/03/2015 08:19, Takuya Yoshikawa wrote: > When all bits in mask are not set, > kvm_arch_mmu_enable_log_dirty_pt_masked() has nothing to do. But since > it needs to be called from the generic code, it cannot be inlined, and > a few function calls, two when PML is enabled, are wasted. > > Si

[PATCH] KVM: Eliminate extra function calls in kvm_get_dirty_log_protect()

2015-03-17 Thread Takuya Yoshikawa
When all bits in mask are not set, kvm_arch_mmu_enable_log_dirty_pt_masked() has nothing to do. But since it needs to be called from the generic code, it cannot be inlined, and a few function calls, two when PML is enabled, are wasted. Since it is common to see many pages remain clean, e.g. frame