Re: [PATCH] KVM: MMU: Segregate shadow pages with different cr0.wp

2010-05-14 Thread Marcelo Tosatti
On Wed, May 12, 2010 at 11:48:18AM +0300, Avi Kivity wrote: When cr0.wp=0, we may shadow a gpte having u/s=1 and r/w=0 with an spte having u/s=0 and r/w=1. This allows excessive access if the guest sets cr0.wp=1 and accesses through this spte. Fix by making cr0.wp part of the base role;

[PATCH] KVM: MMU: Segregate shadow pages with different cr0.wp

2010-05-12 Thread Avi Kivity
When cr0.wp=0, we may shadow a gpte having u/s=1 and r/w=0 with an spte having u/s=0 and r/w=1. This allows excessive access if the guest sets cr0.wp=1 and accesses through this spte. Fix by making cr0.wp part of the base role; we'll have different sptes for the two cases and the problem