RE: [PATCH] KVM: arm/arm64: BUG FIX: Do not inject spurious interrupts

2015-09-25 Thread Pavel Fedin
Hello! > The alternative is to just call compute_pending which does nothing more > than a few bitwise and/or operations plus a couple of handfuls of > load/stores on this IRQ injection path, so I don't see the problem doing > this. I looked at it, convinced. After all, resetting pending_on_cpu

Re: [PATCH] KVM: arm/arm64: BUG FIX: Do not inject spurious interrupts

2015-09-14 Thread Christoffer Dall
On Fri, Aug 28, 2015 at 12:11:17PM +0300, Pavel Fedin wrote: > Hello! > > > It's a bit weird to just sned this as a new patch without replying to my > > mail from yesterday with feedback > > Sorry. But changes are actually minimal, and i remember that i replied to > you with the promise of >

RE: [PATCH] KVM: arm/arm64: BUG FIX: Do not inject spurious interrupts

2015-08-28 Thread Pavel Fedin
Hello! It's a bit weird to just sned this as a new patch without replying to my mail from yesterday with feedback Sorry. But changes are actually minimal, and i remember that i replied to you with the promise of testing your suggestion. So, done, works fine. :) I think you're missing a

Re: [PATCH] KVM: arm/arm64: BUG FIX: Do not inject spurious interrupts

2015-08-27 Thread Christoffer Dall
On Thu, Aug 27, 2015 at 02:51:22PM +0300, Pavel Fedin wrote: Commit 71760950bf3dc796e5e53ea3300dec724a09f593 (arm/arm64: KVM: add a common vgic_queue_irq_to_lr fn) introduced vgic_queue_irq_to_lr() function with additional vgic_dist_irq_is_pending() check before setting LR_STATE_PENDING bit.

[PATCH] KVM: arm/arm64: BUG FIX: Do not inject spurious interrupts

2015-08-27 Thread Pavel Fedin
Commit 71760950bf3dc796e5e53ea3300dec724a09f593 (arm/arm64: KVM: add a common vgic_queue_irq_to_lr fn) introduced vgic_queue_irq_to_lr() function with additional vgic_dist_irq_is_pending() check before setting LR_STATE_PENDING bit. In some cases it started causing the following situation if the