Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-27 Thread Christian Borntraeger
Am 27.04.2015 um 16:03 schrieb Alexander Graf: > On 04/27/2015 03:57 PM, Martin Schwidefsky wrote: >> On Mon, 27 Apr 2015 15:48:42 +0200 >> Alexander Graf wrote: >> >>> On 04/23/2015 02:13 PM, Martin Schwidefsky wrote: On Thu, 23 Apr 2015 14:01:23 +0200 Alexander Graf wrote: >

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-27 Thread Alexander Graf
On 04/27/2015 03:57 PM, Martin Schwidefsky wrote: On Mon, 27 Apr 2015 15:48:42 +0200 Alexander Graf wrote: On 04/23/2015 02:13 PM, Martin Schwidefsky wrote: On Thu, 23 Apr 2015 14:01:23 +0200 Alexander Graf wrote: As far as alternative approaches go, I don't have a great idea otoh. We coul

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-27 Thread Martin Schwidefsky
On Mon, 27 Apr 2015 15:48:42 +0200 Alexander Graf wrote: > On 04/23/2015 02:13 PM, Martin Schwidefsky wrote: > > On Thu, 23 Apr 2015 14:01:23 +0200 > > Alexander Graf wrote: > > > >> As far as alternative approaches go, I don't have a great idea otoh. > >> We could have an elf flag indicating th

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-27 Thread Paolo Bonzini
On 27/04/2015 15:48, Alexander Graf wrote: > Well, you could also make it a personality flag for example, no? Then > every new process below a certain one always gets 4k page tables until > they drop the personality, at which point each child would only get 2k > page tables again. But if you hav

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-27 Thread Alexander Graf
On 04/23/2015 02:08 PM, Christian Borntraeger wrote: Am 23.04.2015 um 14:01 schrieb Alexander Graf: Am 23.04.2015 um 13:43 schrieb Christian Borntraeger : Am 23.04.2015 um 13:37 schrieb Alexander Graf: Am 23.04.2015 um 13:08 schrieb Christian Borntraeger : From: Martin Schwidefsky Repl

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-27 Thread Alexander Graf
On 04/23/2015 02:13 PM, Martin Schwidefsky wrote: On Thu, 23 Apr 2015 14:01:23 +0200 Alexander Graf wrote: As far as alternative approaches go, I don't have a great idea otoh. We could have an elf flag indicating that this process needs 4k page tables to limit the impact to a single process. I

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Cole Robinson
On 04/23/2015 08:07 AM, Paolo Bonzini wrote: > > > On 23/04/2015 13:43, Christian Borntraeger wrote: Couldn't you make this a hidden kconfig option that gets automatically selected when kvm is enabled? Or is there a non-kvm case that needs it too? >> For things like RHEV the defau

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Martin Schwidefsky
On Thu, 23 Apr 2015 14:01:23 +0200 Alexander Graf wrote: > As far as alternative approaches go, I don't have a great idea otoh. > We could have an elf flag indicating that this process needs 4k page > tables to limit the impact to a single process. In fact, could we > maybe still limit the scope

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Christian Borntraeger
Am 23.04.2015 um 14:01 schrieb Alexander Graf: > > >> Am 23.04.2015 um 13:43 schrieb Christian Borntraeger >> : >> >>> Am 23.04.2015 um 13:37 schrieb Alexander Graf: >>> >>> Am 23.04.2015 um 13:08 schrieb Christian Borntraeger : From: Martin Schwidefsky Replacing

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 13:43, Christian Borntraeger wrote: >> > >> > Couldn't you make this a hidden kconfig option that gets automatically >> > selected when kvm is enabled? Or is there a non-kvm case that needs it too? > For things like RHEV the default could certainly be "enabled", but for normal > d

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Alexander Graf
> Am 23.04.2015 um 13:43 schrieb Christian Borntraeger : > >> Am 23.04.2015 um 13:37 schrieb Alexander Graf: >> >> >>> Am 23.04.2015 um 13:08 schrieb Christian Borntraeger >>> : >>> >>> From: Martin Schwidefsky >>> >>> Replacing a 2K page table with a 4K page table while a VMA is active >>

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Christian Borntraeger
Am 23.04.2015 um 13:37 schrieb Alexander Graf: > > >> Am 23.04.2015 um 13:08 schrieb Christian Borntraeger >> : >> >> From: Martin Schwidefsky >> >> Replacing a 2K page table with a 4K page table while a VMA is active >> for the affected memory region is fundamentally broken. Rip out the >> pag

Re: [PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Alexander Graf
> Am 23.04.2015 um 13:08 schrieb Christian Borntraeger : > > From: Martin Schwidefsky > > Replacing a 2K page table with a 4K page table while a VMA is active > for the affected memory region is fundamentally broken. Rip out the > page table reallocation code and replace it with a simple syste

[PATCH] KVM: s390: remove delayed reallocation of page tables for KVM

2015-04-23 Thread Christian Borntraeger
From: Martin Schwidefsky Replacing a 2K page table with a 4K page table while a VMA is active for the affected memory region is fundamentally broken. Rip out the page table reallocation code and replace it with a simple system control 'vm.allocate_pgste'. If the system control is set the page tab