Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-14 Thread Jan Kiszka
Gleb Natapov wrote: On Sat, Feb 13, 2010 at 08:20:41PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 07:41:35PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 06:49:44PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-14 Thread Paolo Bonzini
On 02/13/2010 08:20 PM, Jan Kiszka wrote: But I still fail to see the case where event_exit_inst_len is set to anything but 1 or 2 and where it is related to anything else than exits at INT3, INT X, or INTO. What about BOUND? (I want to hide for suggesting anyone uses that instruction).

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-14 Thread Gleb Natapov
On Sun, Feb 14, 2010 at 02:44:39PM +0100, Paolo Bonzini wrote: On 02/13/2010 08:20 PM, Jan Kiszka wrote: But I still fail to see the case where event_exit_inst_len is set to anything but 1 or 2 and where it is related to anything else than exits at INT3, INT X, or INTO. What about BOUND?

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-14 Thread Avi Kivity
On 02/14/2010 03:44 PM, Paolo Bonzini wrote: On 02/13/2010 08:20 PM, Jan Kiszka wrote: But I still fail to see the case where event_exit_inst_len is set to anything but 1 or 2 and where it is related to anything else than exits at INT3, INT X, or INTO. What about BOUND? (I want to hide for

[PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com VMX requires a properly set instruction length VM entry field when trying to inject soft exception and interrupts. We have to preserve this state across VM save/restore to avoid breaking the re-injection of such events on Intel. So add it to the new VCPU

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Avi Kivity
On 02/13/2010 11:51 AM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com VMX requires a properly set instruction length VM entry field when trying to inject soft exception and interrupts. We have to preserve this state across VM save/restore to avoid breaking the re-injection of such

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Jan Kiszka
Avi Kivity wrote: On 02/13/2010 11:51 AM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com VMX requires a properly set instruction length VM entry field when trying to inject soft exception and interrupts. We have to preserve this state across VM save/restore to avoid breaking the

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Gleb Natapov
On Sat, Feb 13, 2010 at 10:51:40AM +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com VMX requires a properly set instruction length VM entry field when trying to inject soft exception and interrupts. We have to preserve this state across VM save/restore to avoid breaking the

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Jan Kiszka
Gleb Natapov wrote: On Sat, Feb 13, 2010 at 10:51:40AM +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com VMX requires a properly set instruction length VM entry field when trying to inject soft exception and interrupts. We have to preserve this state across VM save/restore to

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Gleb Natapov
On Sat, Feb 13, 2010 at 06:49:44PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 10:51:40AM +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com VMX requires a properly set instruction length VM entry field when trying to inject soft exception and

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Jan Kiszka
Gleb Natapov wrote: On Sat, Feb 13, 2010 at 06:49:44PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 10:51:40AM +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com VMX requires a properly set instruction length VM entry field when trying to inject soft

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Gleb Natapov
On Sat, Feb 13, 2010 at 07:41:35PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 06:49:44PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 10:51:40AM +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com VMX requires a properly

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Jan Kiszka
Gleb Natapov wrote: On Sat, Feb 13, 2010 at 07:41:35PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 06:49:44PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 10:51:40AM +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com VMX

Re: [PATCH] KVM: x86: Add instruction length to VCPU event state

2010-02-13 Thread Gleb Natapov
On Sat, Feb 13, 2010 at 08:20:41PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 07:41:35PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 06:49:44PM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Sat, Feb 13, 2010 at 10:51:40AM +0100, Jan