Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Avi Kivity
On 03/23/2010 01:21 PM, Jan Kiszka wrote: A 44-byte TSS has a limit of 43 (just like a 4GB segment has a limit of 0x), so there is an off-by-one here. Right - you just found an (harmless) off-by-one in our legacy OS as well (I blindly copied its limit). It's a very common

Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Jan Kiszka
Avi Kivity wrote: > On 03/23/2010 12:25 PM, Avi Kivity wrote: >>> This should be stable material as well. I can provide a patch that >>> applies on .32 and .33, or what will be the procedure? >> >> I'd like to drop the Cc: stable and maintain stable queues explicitly >> (in kvm-updates/2.6.3[23]).

Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Jan Kiszka
Avi Kivity wrote: > On 03/22/2010 12:29 PM, Jan Kiszka wrote: >> A 16-bit TSS is only 44 bytes long. So make sure to test for the correct >> size on task switch. >> > >> This should be stable material as well. I can provide a patch that >> applies on .32 and .33, or what will be the procedure?

Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Avi Kivity
On 03/23/2010 12:25 PM, Avi Kivity wrote: This should be stable material as well. I can provide a patch that applies on .32 and .33, or what will be the procedure? I'd like to drop the Cc: stable and maintain stable queues explicitly (in kvm-updates/2.6.3[23]). I'll fast-forward these to curr

Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Avi Kivity
On 03/22/2010 12:29 PM, Jan Kiszka wrote: A 16-bit TSS is only 44 bytes long. So make sure to test for the correct size on task switch. This should be stable material as well. I can provide a patch that applies on .32 and .33, or what will be the procedure? I'd like to drop the Cc: s

[PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-22 Thread Jan Kiszka
A 16-bit TSS is only 44 bytes long. So make sure to test for the correct size on task switch. Signed-off-by: Jan Kiszka --- This should be stable material as well. I can provide a patch that applies on .32 and .33, or what will be the procedure? arch/x86/kvm/emulate.c |6 +- 1 files ch