Re: [PATCH] VMX: Fix and improve guest state validity checks

2010-05-25 Thread Avi Kivity
On 05/13/2010 11:15 PM, Mohammed Gamal wrote: On Thu, May 13, 2010 at 9:24 AM, Avi Kivitya...@redhat.com wrote: On 05/11/2010 07:52 PM, Mohammed Gamal wrote: - Add 's' and 'g' field checks on segment registers - Correct SS checks for request and descriptor privilege levels

Re: [PATCH] VMX: Fix and improve guest state validity checks

2010-05-25 Thread Mohammed Gamal
On Tue, May 25, 2010 at 12:37 PM, Avi Kivity a...@redhat.com wrote: On 05/13/2010 11:15 PM, Mohammed Gamal wrote: On Thu, May 13, 2010 at 9:24 AM, Avi Kivitya...@redhat.com  wrote: On 05/11/2010 07:52 PM, Mohammed Gamal wrote: - Add 's' and 'g' field checks on segment registers - Correct

Re: [PATCH] VMX: Fix and improve guest state validity checks

2010-05-25 Thread Avi Kivity
On 05/25/2010 01:36 PM, Mohammed Gamal wrote: Any reference to back this up? I think rpl is valid regardless of ss.unusable (i.e. loading selector 0003 results in an unusable segment with rpl=3), but I don't see how dpl can be valid in an unusable segment. Intel 64 and IA-32

Re: [PATCH] VMX: Fix and improve guest state validity checks

2010-05-13 Thread Avi Kivity
On 05/11/2010 07:52 PM, Mohammed Gamal wrote: - Add 's' and 'g' field checks on segment registers - Correct SS checks for request and descriptor privilege levels Signed-off-by: Mohammed Gamalm.gamal...@gmail.com --- arch/x86/kvm/vmx.c | 73 +++

Re: [PATCH] VMX: Fix and improve guest state validity checks

2010-05-13 Thread Mohammed Gamal
On Thu, May 13, 2010 at 9:24 AM, Avi Kivity a...@redhat.com wrote: On 05/11/2010 07:52 PM, Mohammed Gamal wrote: - Add 's' and 'g' field checks on segment registers - Correct SS checks for request and descriptor privilege levels Signed-off-by: Mohammed Gamalm.gamal...@gmail.com ---  

Re: [PATCH] VMX: Fix and improve guest state validity checks

2010-05-12 Thread Marcelo Tosatti
On Tue, May 11, 2010 at 07:52:41PM +0300, Mohammed Gamal wrote: - Add 's' and 'g' field checks on segment registers - Correct SS checks for request and descriptor privilege levels Signed-off-by: Mohammed Gamal m.gamal...@gmail.com --- arch/x86/kvm/vmx.c | 73

[PATCH] VMX: Fix and improve guest state validity checks

2010-05-11 Thread Mohammed Gamal
- Add 's' and 'g' field checks on segment registers - Correct SS checks for request and descriptor privilege levels Signed-off-by: Mohammed Gamal m.gamal...@gmail.com --- arch/x86/kvm/vmx.c | 73 +++ 1 files changed, 67 insertions(+), 6