Re: [PATCH] VMX: Invalid guest state detection enhancements and bug fixes

2010-05-11 Thread Gleb Natapov
On Tue, May 11, 2010 at 01:53:51PM +0300, Mohammed Gamal wrote: > >>                if (err != EMULATE_DONE) { > >> +                       kvm_report_emulation_failure(vcpu, "invalid guest > >> state handler"); > >>                        vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR; > >>    

Re: [PATCH] VMX: Invalid guest state detection enhancements and bug fixes

2010-05-11 Thread Mohammed Gamal
On Tue, May 11, 2010 at 12:24 PM, Avi Kivity wrote: > On 05/10/2010 06:51 PM, Mohammed Gamal wrote: >> >> - Correct unusable flag check on SS, DS, ES, FS, GS, and LDTR >> - Add rflags checks >> - Report failed instruction on emulation failure >> >> > > Please post as separate patches. > >> diff --

Re: [PATCH] VMX: Invalid guest state detection enhancements and bug fixes

2010-05-11 Thread Avi Kivity
On 05/10/2010 06:51 PM, Mohammed Gamal wrote: - Correct unusable flag check on SS, DS, ES, FS, GS, and LDTR - Add rflags checks - Report failed instruction on emulation failure Please post as separate patches. diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 777e00d..968384b 10

[PATCH] VMX: Invalid guest state detection enhancements and bug fixes

2010-05-10 Thread Mohammed Gamal
- Correct unusable flag check on SS, DS, ES, FS, GS, and LDTR - Add rflags checks - Report failed instruction on emulation failure Signed-off-by: Mohammed Gamal --- arch/x86/kvm/vmx.c | 31 +++ 1 files changed, 27 insertions(+), 4 deletions(-) diff --git a/arch/x86

[PATCH] VMX: Invalid guest state detection enhancements and bug fixes

2010-05-09 Thread Mohammed Gamal
- Correct unusable flag check on SS, DS, ES, FS, GS, and LDTR - Add IDTR and GDTR checks - Add rflags checks Signed-off-by: Mohammed Gamal --- arch/x86/kvm/vmx.c | 64 --- 1 files changed, 60 insertions(+), 4 deletions(-) diff --git a/arch/x86/k