Re: [PATCH] VT-d: fix PCI device detach from virtual machine

2010-06-17 Thread David Woodhouse
On Thu, 2010-06-17 at 11:35 +0800, Weidong Han wrote: David Woodhouse wrote: So why do we bother setting up a context in the IOMMU for the device itself, when no DMA will ever appear to come from this device? And if the device is behind PCI Express-to-PCI/PCI-X bridge, the source-id

Re: [PATCH] VT-d: fix PCI device detach from virtual machine

2010-06-17 Thread Weidong Han
David Woodhouse wrote: On Thu, 2010-06-17 at 11:35 +0800, Weidong Han wrote: David Woodhouse wrote: So why do we bother setting up a context in the IOMMU for the device itself, when no DMA will ever appear to come from this device? And if the device is behind PCI

Re: [PATCH] VT-d: fix PCI device detach from virtual machine

2010-06-15 Thread Joerg Roedel
On Mon, Jun 14, 2010 at 07:19:17PM -0400, David Woodhouse wrote: Why not just jump straight to the 'DMA proxy' device, and use that _only_? Not sure about Intel chipsets, but on AMD chipset a legacy device can be seen by the IOMMU with both device-ids, its own and the bridge device. So the

Re: [PATCH] VT-d: fix PCI device detach from virtual machine

2010-06-15 Thread David Woodhouse
On Tue, 2010-06-15 at 16:10 +0200, Joerg Roedel wrote: On Mon, Jun 14, 2010 at 07:19:17PM -0400, David Woodhouse wrote: Why not just jump straight to the 'DMA proxy' device, and use that _only_? Not sure about Intel chipsets, but on AMD chipset a legacy device can be seen by the IOMMU

Re: [PATCH] VT-d: fix PCI device detach from virtual machine

2010-06-14 Thread David Woodhouse
On Thu, 2009-02-26 at 17:31 +0800, Han, Weidong wrote: When assign a device behind conventional PCI bridge or PCIe to PCI/PCI-x bridge to a domain, it must assign its bridge and may also need to assign secondary interface to the same domain. Dependent assignment is already there, but

[PATCH] VT-d: fix PCI device detach from virtual machine

2009-02-26 Thread Han, Weidong
When assign a device behind conventional PCI bridge or PCIe to PCI/PCI-x bridge to a domain, it must assign its bridge and may also need to assign secondary interface to the same domain. Dependent assignment is already there, but dependent deassignment is missed when detach device from virtual