Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-27 Thread Avi Kivity
On 05/26/2010 02:08 AM, Alex Williamson wrote: PCI_MSIX_TABSIZE is 0x07ff Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-27 Thread Jes Sorensen
On 05/26/10 14:48, Avi Kivity wrote: > On 05/26/2010 03:27 AM, Juan Quintela wrote: >> BTW, I also noticed the lack of pci_set_long() and friend functions, but >> arrived to the same conclusion that you: all the device assignment >> assumes that the world is x86_64 :) >> > > IIRC it used to wo

Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-26 Thread Juan Quintela
Avi Kivity wrote: > On 05/26/2010 03:27 AM, Juan Quintela wrote: >> Alex Williamson wrote: >> >>> PCI_MSIX_TABSIZE is 0x07ff >>> >>> Reported-by: Juan Quintela >>> Signed-off-by: Alex Williamson >>> >> Acked-by: Juan Quintela >> >> BTW, I also noticed the lack of pci_set_long() and frie

Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-26 Thread Avi Kivity
On 05/26/2010 03:27 AM, Juan Quintela wrote: Alex Williamson wrote: PCI_MSIX_TABSIZE is 0x07ff Reported-by: Juan Quintela Signed-off-by: Alex Williamson Acked-by: Juan Quintela BTW, I also noticed the lack of pci_set_long() and friend functions, but arrived to the same conclusion t

Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-25 Thread Juan Quintela
Alex Williamson wrote: > PCI_MSIX_TABSIZE is 0x07ff > > Reported-by: Juan Quintela > Signed-off-by: Alex Williamson Acked-by: Juan Quintela BTW, I also noticed the lack of pci_set_long() and friend functions, but arrived to the same conclusion that you: all the device assignment assumes that

Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-25 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 2010-05-25 at 16:09 -0700, Chris Wright wrote: > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > PCI_MSIX_TABSIZE is 0x07ff > > > > while not an issue now, i think that only works for little endian > > Yep. This is con

Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-25 Thread Alex Williamson
On Tue, 2010-05-25 at 16:09 -0700, Chris Wright wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > PCI_MSIX_TABSIZE is 0x07ff > > while not an issue now, i think that only works for little endian Yep. This is consistent with rest of the device assignment code though, so I suspect

Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-25 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: > PCI_MSIX_TABSIZE is 0x07ff while not an issue now, i think that only works for little endian -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

[PATCH] device-assignment: don't truncate MSIX capabilities table size

2010-05-25 Thread Alex Williamson
PCI_MSIX_TABSIZE is 0x07ff Reported-by: Juan Quintela Signed-off-by: Alex Williamson --- Applies on top of: [PATCH qemu-kvm 1/2] device-assignment: use stdint types [PATCH qemu-kvm 2/2] device-assignment: Don't use libpci hw/device-assignment.c |6 +++--- 1 files changed, 3 insertions(