Re: [PATCH] fix "info cpus" halted state display

2010-05-23 Thread Avi Kivity
On 05/20/2010 01:16 PM, Gleb Natapov wrote: On Thu, May 13, 2010 at 04:17:14PM +0300, Gleb Natapov wrote: When in-kernel irqchip is used env->halted is never used for anything except "info cpus" command. Halted state is synced in kvm_arch_save_mpstate() and showed by do_info_cpus() but other

Re: [PATCH] fix "info cpus" halted state display

2010-05-20 Thread Gleb Natapov
On Thu, May 13, 2010 at 04:17:14PM +0300, Gleb Natapov wrote: > When in-kernel irqchip is used env->halted is never used for anything > except "info cpus" command. Halted state is synced in > kvm_arch_save_mpstate() and showed by do_info_cpus() but otherwise never > looked at. Zeroing it here break

Re: [PATCH] fix "info cpus" halted state display

2010-05-15 Thread Gleb Natapov
On Thu, May 13, 2010 at 03:57:05PM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > When in-kernel irqchip is used env->halted is never used for anything > > except "info cpus" command. > > In fact, it's used in a few more places, namely cpu_dump_state and the > gdbstub. > Both of those places

Re: [PATCH] fix "info cpus" halted state display

2010-05-13 Thread Jan Kiszka
Gleb Natapov wrote: > When in-kernel irqchip is used env->halted is never used for anything > except "info cpus" command. In fact, it's used in a few more places, namely cpu_dump_state and the gdbstub. > Halted state is synced in > kvm_arch_save_mpstate() and showed by do_info_cpus() but otherwis

[PATCH] fix "info cpus" halted state display

2010-05-13 Thread Gleb Natapov
When in-kernel irqchip is used env->halted is never used for anything except "info cpus" command. Halted state is synced in kvm_arch_save_mpstate() and showed by do_info_cpus() but otherwise never looked at. Zeroing it here breaks "info cpus" since before do_info_cpus() outputs env->halted in io th