Re: [PATCH] kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()

2013-09-04 Thread Will Deacon
On Wed, Sep 04, 2013 at 11:13:55AM +0100, Pekka Enberg wrote: > On Wed, Sep 4, 2013 at 1:07 PM, Will Deacon wrote: > > Like this? It gets a bit confusing, because there is a KVM_IOEVENTFD_FLAG_* > > namespace as part of the kernel KVM API, but which doesn't have the flags we > > need (e.g. userspa

Re: [PATCH] kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()

2013-09-04 Thread Pekka Enberg
On Wed, Sep 4, 2013 at 1:07 PM, Will Deacon wrote: > Like this? It gets a bit confusing, because there is a KVM_IOEVENTFD_FLAG_* > namespace as part of the kernel KVM API, but which doesn't have the flags we > need (e.g. userspace polling). Looks good. I applied the fix so can you please redo thi

Re: [PATCH] kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()

2013-09-04 Thread Will Deacon
On Wed, Sep 04, 2013 at 10:21:26AM +0100, Pekka Enberg wrote: > On 8/30/13 4:58 PM, Ying-Shiuan Pan wrote: > > From: Ying-Shiuan Pan > > > > This patch fixes a bug that vtirtio_mmio_init_ioeventfd() passed a wrong > > value when it invoked ioeventfd__add_event(). True value of 2nd parameter > > in

Re: [PATCH] kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()

2013-09-04 Thread Pekka Enberg
On 8/30/13 4:58 PM, Ying-Shiuan Pan wrote: From: Ying-Shiuan Pan This patch fixes a bug that vtirtio_mmio_init_ioeventfd() passed a wrong value when it invoked ioeventfd__add_event(). True value of 2nd parameter indicates the eventfd uses PIO bus which is used by virito-pci, however, for virtio

[PATCH] kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()

2013-08-30 Thread Ying-Shiuan Pan
From: Ying-Shiuan Pan This patch fixes a bug that vtirtio_mmio_init_ioeventfd() passed a wrong value when it invoked ioeventfd__add_event(). True value of 2nd parameter indicates the eventfd uses PIO bus which is used by virito-pci, however, for virtio-mmio, the value should be false. Signed-off