Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate fails

2010-10-26 Thread Stefan Hajnoczi
On Tue, Oct 26, 2010 at 2:48 PM, Kevin Wolf wrote: > Am 26.10.2010 15:23, schrieb Stefan Hajnoczi: >> When an image is created with -o preallocate, ensure that we only call >> preallocate() if the image was indeed opened successfully.  Also use >> bdrv_delete() instead of bdrv_close() to avoid lea

Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate fails

2010-10-26 Thread Kevin Wolf
Am 26.10.2010 15:23, schrieb Stefan Hajnoczi: > When an image is created with -o preallocate, ensure that we only call > preallocate() if the image was indeed opened successfully. Also use > bdrv_delete() instead of bdrv_close() to avoid leaking the > BlockDriverState structure. > > This fixes th

[PATCH] qcow2: Fix segfault when qcow2 preallocate fails

2010-10-26 Thread Stefan Hajnoczi
When an image is created with -o preallocate, ensure that we only call preallocate() if the image was indeed opened successfully. Also use bdrv_delete() instead of bdrv_close() to avoid leaking the BlockDriverState structure. This fixes the segfault reported at https://bugzilla.redhat.com/show_bu