RE: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-09 Thread Zhang, Xiantao
Hollis Blanchard wrote: > On Thursday 06 November 2008 19:38:40 Zhang, Xiantao wrote: >> >> Hi, Hollis >> Currenlty, kvm-qemu only supports the only case which is host >> page_size = > qemu's target page size for ia64. Does your patch meets the > requirement ? For ia64, current linux support

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Hollis Blanchard
On Thursday 06 November 2008 19:38:40 Zhang, Xiantao wrote: > > Hi, Hollis > Currenlty, kvm-qemu only supports the only case which is host page_size > = qemu's target page size for ia64. Does your patch meets the requirement ? For ia64, current linux support 4K, 16K and 64k page size, and

RE: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Zhang, Xiantao
Hollis Blanchard wrote: > On Thu, 2008-11-06 at 08:01 -0600, Anthony Liguori wrote: >> Hollis Blanchard wrote: >>> # HG changeset patch >>> # User Hollis Blanchard <[EMAIL PROTECTED]> >>> # Date 1225946837 21600 >>> # Node ID 43a111ea61b542d3823e2a11d017e7b06b7ec254 >>> # Parent b63967268af119e0fa

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: I wanted to make sure people on non-x86 architectures couldn't run into vring-size related problems that didn't also appear on x86. Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1 << VRING_SHIFT) is almost certainly going to break things in une

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Hollis Blanchard
On Thu, 2008-11-06 at 08:01 -0600, Anthony Liguori wrote: > Hollis Blanchard wrote: > > # HG changeset patch > > # User Hollis Blanchard <[EMAIL PROTECTED]> > > # Date 1225946837 21600 > > # Node ID 43a111ea61b542d3823e2a11d017e7b06b7ec254 > > # Parent b63967268af119e0faa4adc3086cdef857815548 > >

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1225946837 21600 # Node ID 43a111ea61b542d3823e2a11d017e7b06b7ec254 # Parent b63967268af119e0faa4adc3086cdef857815548 qemu: define and use VIRTIO_PFN_SHIFT The virtio front and back ends must agree a

Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-06 Thread Mark McLoughlin
On Wed, 2008-11-05 at 22:49 -0600, Hollis Blanchard wrote: > diff --git a/qemu/hw/virtio.c b/qemu/hw/virtio.c > --- a/qemu/hw/virtio.c > +++ b/qemu/hw/virtio.c > @@ -56,6 +56,10 @@ > */ > #define wmb() do { } while (0) > > +#define VRING_PAGE_SIZE (1<<12) > + > +#define ALIGN(x, a) (((x)+(a)

[PATCH] qemu: define and use VIRTIO_PFN_SHIFT

2008-11-05 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1225946837 21600 # Node ID 43a111ea61b542d3823e2a11d017e7b06b7ec254 # Parent b63967268af119e0faa4adc3086cdef857815548 qemu: define and use VIRTIO_PFN_SHIFT The virtio front and back ends must agree about how big a pfn really