Re: [PATCH] stop and show registers on error.

2011-02-24 Thread Avi Kivity
On 02/21/2011 02:57 PM, Gleb Natapov wrote: FWIW, this patch just aligns qemu-kvm to what upstream already does and what qemu-kvm will soon or later do as well when it starts using the upstream loop. I'm neutral /wrt applying this patch before the cleanup or achieving the same by

[PATCH] stop and show registers on error.

2011-02-21 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index 49cd683..2f3f683 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -644,8 +644,7 @@ int kvm_run(CPUState *env) break; #endif case KVM_EXIT_INTERNAL_ERROR: -

Re: [PATCH] stop and show registers on error.

2011-02-21 Thread Avi Kivity
On 02/21/2011 12:16 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapovg...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index 49cd683..2f3f683 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -644,8 +644,7 @@ int kvm_run(CPUState *env) break; #endif case

Re: [PATCH] stop and show registers on error.

2011-02-21 Thread Gleb Natapov
On Mon, Feb 21, 2011 at 02:24:19PM +0200, Avi Kivity wrote: On 02/21/2011 12:16 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapovg...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index 49cd683..2f3f683 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -644,8 +644,7 @@ int kvm_run(CPUState

Re: [PATCH] stop and show registers on error.

2011-02-21 Thread Jan Kiszka
On 2011-02-21 13:25, Gleb Natapov wrote: On Mon, Feb 21, 2011 at 02:24:19PM +0200, Avi Kivity wrote: On 02/21/2011 12:16 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapovg...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index 49cd683..2f3f683 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c

Re: [PATCH] stop and show registers on error.

2011-02-21 Thread Gleb Natapov
On Mon, Feb 21, 2011 at 01:53:15PM +0100, Jan Kiszka wrote: On 2011-02-21 13:25, Gleb Natapov wrote: On Mon, Feb 21, 2011 at 02:24:19PM +0200, Avi Kivity wrote: On 02/21/2011 12:16 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapovg...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c