Re: [PATCH] virtio-net: fill only rx queues which are being used

2013-04-23 Thread Michael S. Tsirkin
On Mon, Apr 22, 2013 at 08:35:36PM -0400, Sasha Levin wrote: Due to MQ support we may allocate a whole bunch of rx queues but never use them. With this patch we'll safe the space used by the receive buffers until they are actually in use: sh-4.2# free -h total used

Re: [PATCH] virtio-net: fill only rx queues which are being used

2013-04-23 Thread Will Deacon
Hi guys, On Tue, Apr 23, 2013 at 05:49:23AM +0100, Sasha Levin wrote: On 04/23/2013 12:13 AM, Rusty Russell wrote: We don't free up buffers when we're reducing queues, but I consider that a corner case. It didn't bother anyone up until now, and the spec doesn't state anything about it -

Re: [PATCH] virtio-net: fill only rx queues which are being used

2013-04-23 Thread Sasha Levin
On 04/23/2013 03:08 AM, Michael S. Tsirkin wrote: On Mon, Apr 22, 2013 at 08:35:36PM -0400, Sasha Levin wrote: Due to MQ support we may allocate a whole bunch of rx queues but never use them. With this patch we'll safe the space used by the receive buffers until they are actually in use:

[PATCH] virtio-net: fill only rx queues which are being used

2013-04-22 Thread Sasha Levin
Due to MQ support we may allocate a whole bunch of rx queues but never use them. With this patch we'll safe the space used by the receive buffers until they are actually in use: sh-4.2# free -h total used free sharedbuffers cached Mem: 490M35M

Re: [PATCH] virtio-net: fill only rx queues which are being used

2013-04-22 Thread Rusty Russell
Sasha Levin sasha.le...@oracle.com writes: Due to MQ support we may allocate a whole bunch of rx queues but never use them. With this patch we'll safe the space used by the receive buffers until they are actually in use: Idea is good, implementation needs a tiny tweak: @@ -912,8 +913,13 @@

Re: [PATCH] virtio-net: fill only rx queues which are being used

2013-04-22 Thread Sasha Levin
On 04/23/2013 12:13 AM, Rusty Russell wrote: Sasha Levin sasha.le...@oracle.com writes: Due to MQ support we may allocate a whole bunch of rx queues but never use them. With this patch we'll safe the space used by the receive buffers until they are actually in use: Idea is good,