Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

2015-04-09 Thread Paolo Bonzini
On 02/04/2015 14:47, Paolo Bonzini wrote: On 01/04/2015 23:12, Bandan Das wrote: Before: ./x86-run ./x86/msr.flat QEMU binary has no support for test device. Exiting. After: ./x86-run ./x86/msr.flat A QEMU binary was not found, You can set a custom location by using the QEMU=path

Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

2015-04-09 Thread Bandan Das
Bandan Das b...@redhat.com writes: ... I think we still want to print this if the user supplied qemu has no test device support. I think this is better - --- a/x86/run +++ b/x86/run @@ -8,6 +8,7 @@ qemusystem=${QEMU:-qemu-system-x86_64} if ! [ -z ${QEMU} ] then qemu=${QEMU}

Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 19:14, Bandan Das wrote: Paolo Bonzini pbonz...@redhat.com writes: ... This breaks QEMU=... ./x86-run ./x86/msr.flat Fixed as follows: diff --git a/x86/run b/x86/run index d5adf8d..219a93b 100755 --- a/x86/run +++ b/x86/run @@ -20,16 +20,15 @@ else

Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

2015-04-09 Thread Bandan Das
Paolo Bonzini pbonz...@redhat.com writes: ... This breaks QEMU=... ./x86-run ./x86/msr.flat Fixed as follows: diff --git a/x86/run b/x86/run index d5adf8d..219a93b 100755 --- a/x86/run +++ b/x86/run @@ -20,16 +20,15 @@ else break fi done -fi -

Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

2015-04-02 Thread Paolo Bonzini
On 01/04/2015 23:12, Bandan Das wrote: Before: ./x86-run ./x86/msr.flat QEMU binary has no support for test device. Exiting. After: ./x86-run ./x86/msr.flat A QEMU binary was not found, You can set a custom location by using the QEMU=path environment variable Signed-off-by: Bandan

[PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

2015-04-01 Thread Bandan Das
Before: ./x86-run ./x86/msr.flat QEMU binary has no support for test device. Exiting. After: ./x86-run ./x86/msr.flat A QEMU binary was not found, You can set a custom location by using the QEMU=path environment variable Signed-off-by: Bandan Das b...@redhat.com --- x86/run | 37