Re: [PATCH 0/2] vfio: virtualize INTX_DISABLE

2010-11-09 Thread Tom Lyon
Alex - I am rejecting these 2 patches. For patch 1/2, I started with yours and found a couple of problems, but then I got into the spirit and did a buinch more cleaning up. My patch to follow. For patch 2/2, the INTX stuff, I don't really see the problem. If the user turns on the bit, it'll

Re: [PATCH 0/2] vfio: virtualize INTX_DISABLE

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 16:59 -0800, Tom Lyon wrote: Alex - I am rejecting these 2 patches. For patch 1/2, I started with yours and found a couple of problems, but then I got into the spirit and did a buinch more cleaning up. My patch to follow. Great, I'll take a look. For patch 2/2, the

[PATCH 0/2] vfio: virtualize INTX_DISABLE

2010-11-05 Thread Alex Williamson
Tom, Since we use INTX_DISABLE internally for PCI 2.3 devices, it's probably not a good idea to allow vfio users direct access to it. In trying to virtualize it, I stumbled on some config space virtualization issues. I think we want vconfig and the value written to hardware to be different when