Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-04-16 Thread Wen Congyang
At 03/20/2012 11:45 PM, Gleb Natapov Wrote: On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-04-02 Thread Wen Congyang
At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-04-02 Thread Amit Shah
On (Mon) 02 Apr 2012 [18:05:45], Wen Congyang wrote: At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is:

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-22 Thread Gleb Natapov
On Wed, Mar 21, 2012 at 02:19:34PM -0500, Anthony Liguori wrote: On 03/21/2012 11:25 AM, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-22 Thread Gleb Natapov
On Thu, Mar 22, 2012 at 09:05:12AM +0800, Wen Congyang wrote: At 03/22/2012 03:19 AM, Anthony Liguori Wrote: On 03/21/2012 11:25 AM, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-22 Thread Gleb Natapov
On Wed, Mar 21, 2012 at 02:04:34PM -0500, Anthony Liguori wrote: On 03/13/2012 05:47 AM, Avi Kivity wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-22 Thread Wen Congyang
At 03/22/2012 03:28 PM, Gleb Natapov Wrote: On Wed, Mar 21, 2012 at 02:19:34PM -0500, Anthony Liguori wrote: On 03/21/2012 11:25 AM, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-22 Thread Wen Congyang
At 03/22/2012 03:12 AM, Anthony Liguori Wrote: On 03/15/2012 06:46 AM, Avi Kivity wrote: On 03/15/2012 01:25 PM, Jan Kiszka wrote: There was such vm exit (KVM_EXIT_HYPERCALL), but it was deemed to be a bad idea. BTW, this would help a lot in emulating hypercalls of other hypervisors (or of

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-22 Thread Wen Congyang
At 03/22/2012 03:31 PM, Gleb Natapov Wrote: On Thu, Mar 22, 2012 at 09:05:12AM +0800, Wen Congyang wrote: At 03/22/2012 03:19 AM, Anthony Liguori Wrote: On 03/21/2012 11:25 AM, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-22 Thread Gleb Natapov
On Thu, Mar 22, 2012 at 03:44:45PM +0800, Wen Congyang wrote: At 03/22/2012 03:31 PM, Gleb Natapov Wrote: On Thu, Mar 22, 2012 at 09:05:12AM +0800, Wen Congyang wrote: At 03/22/2012 03:19 AM, Anthony Liguori Wrote: On 03/21/2012 11:25 AM, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Gleb Natapov
On Wed, Mar 21, 2012 at 08:56:03AM +0800, Wen Congyang wrote: At 03/20/2012 11:45 PM, Gleb Natapov Wrote: On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Wen Congyang
At 03/21/2012 05:11 PM, Gleb Natapov Wrote: On Wed, Mar 21, 2012 at 08:56:03AM +0800, Wen Congyang wrote: At 03/20/2012 11:45 PM, Gleb Natapov Wrote: On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Gleb Natapov
On Wed, Mar 21, 2012 at 05:35:49PM +0800, Wen Congyang wrote: At 03/21/2012 05:11 PM, Gleb Natapov Wrote: On Wed, Mar 21, 2012 at 08:56:03AM +0800, Wen Congyang wrote: At 03/20/2012 11:45 PM, Gleb Natapov Wrote: On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: At 03/19/2012

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Corey Minyard
Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going to implement something more complex than simple hypercall for panic notification we better do something more interesting with it than just saying panic

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Gleb Natapov
On Wed, Mar 21, 2012 at 11:18:16AM -0500, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going to implement something more complex than simple hypercall for panic notification we

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Avi Kivity
On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going to implement something more complex than simple hypercall for panic notification we better do something more

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Daniel P. Berrange
On Wed, Mar 21, 2012 at 06:25:16PM +0200, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going to implement something more complex than

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Avi Kivity
On 03/21/2012 07:04 PM, Daniel P. Berrange wrote: In fact the feature can be implemented 100% host side by searching for a panic string signature in the console logs. You can even go one better and search for the panic string in the guest memory directly, which is what virt-dmesg does

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Jan Kiszka
On 2012-03-21 18:34, Avi Kivity wrote: On 03/21/2012 07:04 PM, Daniel P. Berrange wrote: In fact the feature can be implemented 100% host side by searching for a panic string signature in the console logs. You can even go one better and search for the panic string in the guest memory

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Anthony Liguori
On 03/13/2012 05:47 AM, Avi Kivity wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Anthony Liguori
On 03/15/2012 06:46 AM, Avi Kivity wrote: On 03/15/2012 01:25 PM, Jan Kiszka wrote: There was such vm exit (KVM_EXIT_HYPERCALL), but it was deemed to be a bad idea. BTW, this would help a lot in emulating hypercalls of other hypervisors (or of KVM's VAPIC in the absence of in-kernel irqchip

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Anthony Liguori
On 03/21/2012 11:25 AM, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going to implement something more complex than simple hypercall for

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Wen Congyang
At 03/22/2012 03:19 AM, Anthony Liguori Wrote: On 03/21/2012 11:25 AM, Avi Kivity wrote: On 03/21/2012 06:18 PM, Corey Minyard wrote: Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going to implement

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-20 Thread Wen Congyang
At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-20 Thread Gleb Natapov
On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is:

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-20 Thread Wen Congyang
At 03/20/2012 11:45 PM, Gleb Natapov Wrote: On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-19 Thread Wen Congyang
At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest is crashed. If management app does not do

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-15 Thread Wen Congyang
At 03/15/2012 02:46 AM, Eric Northup Wrote: On Wed, Mar 14, 2012 at 6:25 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: On 03/14/2012 03:14 PM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: On 03/14/2012

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-15 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 11:46:08AM -0700, Eric Northup wrote: On Wed, Mar 14, 2012 at 6:25 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: On 03/14/2012 03:14 PM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-15 Thread Jan Kiszka
On 2012-03-15 11:39, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 11:46:08AM -0700, Eric Northup wrote: On Wed, Mar 14, 2012 at 6:25 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: On 03/14/2012 03:14 PM, Gleb Natapov wrote: On Wed, Mar 14,

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-15 Thread Avi Kivity
On 03/15/2012 01:25 PM, Jan Kiszka wrote: There was such vm exit (KVM_EXIT_HYPERCALL), but it was deemed to be a bad idea. BTW, this would help a lot in emulating hypercalls of other hypervisors (or of KVM's VAPIC in the absence of in-kernel irqchip - I had to jump through hoops

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch?

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 05:51 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 11:53 AM, Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:04 PM, Wen Congyang wrote: This is sufficient. On the host, you can open /tmp/foo using a custom program or nc (nc -U /tmp/foo). On the guest, you can just open /dev/virtio-ports/port1 and read/write into it. I have two questions: 1. does it OK to open this device

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:07 PM, Avi Kivity Wrote: On 03/14/2012 11:53 AM, Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:26 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may write the same message to the channel. Surely there's some kind of access control on channels. The

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: At 03/14/2012 05:51 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 04:10:04PM +0530, Amit Shah wrote: On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote: At 03/14/2012 05:51 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P.

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: On 03/14/2012 12:26 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may write the same message to the channel.

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:46 PM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: On 03/14/2012 12:26 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:37 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 12:52 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may write the same message to the channel. Access control is via permissions. You can have udev scripts

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:52 PM, Gleb Natapov Wrote: On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:52 PM, Avi Kivity Wrote: On 03/14/2012 12:52 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may write the same message to the channel. Access control is via

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 03:21:14PM +0530, Amit Shah wrote: On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Amit Shah
On (Wed) 14 Mar 2012 [18:52:07], Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi Kivity Wrote: On 03/14/2012 10:29 AM, Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:57:59PM +0800, Wen Congyang wrote: At 03/14/2012 06:52 PM, Gleb Natapov Wrote: On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote: At 03/14/2012 05:24 PM, Avi

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: At 03/14/2012 06:52 PM, Avi Kivity Wrote: On 03/14/2012 12:52 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: At 03/14/2012 06:52 PM, Avi Kivity Wrote: On 03/14/2012 12:52 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the program running in userspace may

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:57 PM, Daniel P. Berrange Wrote: On Wed, Mar 14, 2012 at 03:21:14PM +0530, Amit Shah wrote: On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote: At 03/13/2012 06:47 PM, Avi Kivity Wrote: On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: At 03/14/2012 06:52 PM, Avi Kivity Wrote: On 03/14/2012 12:52 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:48 PM, Avi Kivity Wrote: On 03/14/2012 12:46 PM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 12:29:57PM +0200, Avi Kivity wrote: On 03/14/2012 12:26 PM, Wen Congyang wrote: If so, is this channel visible to guest userspace? If the channle is visible to guest userspace, the

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 07:06:50PM +0800, Wen Congyang wrote: At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: At 03/14/2012 06:52 PM, Avi Kivity Wrote: On 03/14/2012 12:52 PM, Wen Congyang wrote: If so, is this channel

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Wen Congyang
At 03/14/2012 06:58 PM, Gleb Natapov Wrote: On Wed, Mar 14, 2012 at 06:57:59PM +0800, Wen Congyang wrote: At 03/14/2012 06:52 PM, Gleb Natapov Wrote: On Wed, Mar 14, 2012 at 06:52:07PM +0800, Wen Congyang wrote: At 03/14/2012 06:37 PM, Amit Shah Wrote: On (Wed) 14 Mar 2012 [17:53:00], Wen

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 07:06:50PM +0800, Wen Congyang wrote: At 03/14/2012 06:59 PM, Daniel P. Berrange Wrote: On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote: At 03/14/2012 06:52 PM, Avi Kivity Wrote: On 03/14/2012 12:52 PM, Wen Congyang wrote: If so, is this channel

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 01:11 PM, Wen Congyang wrote: I don't think we want to use the driver. Instead, have a small piece of code that resets the device and pushes out a string (the panic message?) without any interrupts etc. It's still going to be less reliable than a hypercall, I agree.

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 03:07 PM, Avi Kivity wrote: On 03/14/2012 01:11 PM, Wen Congyang wrote: I don't think we want to use the driver. Instead, have a small piece of code that resets the device and pushes out a string (the panic message?) without any interrupts etc. It's still going

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: On 03/14/2012 01:11 PM, Wen Congyang wrote: I don't think we want to use the driver. Instead, have a small piece of code that resets the device and pushes out a string (the panic message?) without any interrupts etc.

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Avi Kivity
On 03/14/2012 03:14 PM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: On 03/14/2012 01:11 PM, Wen Congyang wrote: I don't think we want to use the driver. Instead, have a small piece of code that resets the device and pushes out a string (the

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: On 03/14/2012 03:14 PM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: On 03/14/2012 01:11 PM, Wen Congyang wrote: I don't think we want to use the driver. Instead, have a small piece

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-14 Thread Eric Northup
On Wed, Mar 14, 2012 at 6:25 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Mar 14, 2012 at 03:16:05PM +0200, Avi Kivity wrote: On 03/14/2012 03:14 PM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 03:07:46PM +0200, Avi Kivity wrote: On 03/14/2012 01:11 PM, Wen Congyang wrote: I

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Wen Congyang
At 03/12/2012 06:33 PM, Avi Kivity Wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to only be used by Linux, which has kexec facilities, and you can put talk to

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Avi Kivity
On 03/13/2012 08:44 AM, Wen Congyang wrote: At 03/12/2012 06:33 PM, Avi Kivity Wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to only be used by Linux,

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Daniel P. Berrange
On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to only be used by Linux, which has kexec facilities, and

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-13 Thread Avi Kivity
On 03/13/2012 11:18 AM, Daniel P. Berrange wrote: On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote: On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-12 Thread Wen Congyang
At 03/09/2012 09:21 AM, Wen Congyang Wrote: At 03/08/2012 07:13 PM, Avi Kivity Wrote: On 03/08/2012 09:57 AM, Wen Congyang wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-12 Thread Avi Kivity
On 03/09/2012 03:21 AM, Wen Congyang wrote: Changes from v2 to v3: 1. correct spelling Changes from v1 to v2: 1. split up host and guest-side changes 2. introduce new request flag to avoid changing return values. I see no Documentation/ changes. What shoude be writen into

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-12 Thread Avi Kivity
On 03/12/2012 11:04 AM, Wen Congyang wrote: Do you have any other comments about this patch? Not really, but I'm not 100% convinced the patch is worthwhile. It's likely to only be used by Linux, which has kexec facilities, and you can put talk to management via virtio-serial and describe the

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-08 Thread Avi Kivity
On 03/08/2012 09:57 AM, Wen Congyang wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest is crashed. If management app does not do

Re: [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-08 Thread Wen Congyang
At 03/08/2012 07:13 PM, Avi Kivity Wrote: On 03/08/2012 09:57 AM, Wen Congyang wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest

[PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-07 Thread Wen Congyang
We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest is crashed. If management app does not do auto dump, the guest's user can do dump by hand