Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2

2010-12-01 Thread Nadav Har'El
On Mon, Nov 29, 2010, Joerg Roedel wrote about [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2: Hi Avi, Hi Marcelo, here is the re-spin I promised. The change to V1 are essentially the renames: kvm_vcpu_enter_gm - enter_guest_mode kvm_vcpu_leave_gm

Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2

2010-12-01 Thread Roedel, Joerg
On Wed, Dec 01, 2010 at 03:01:49AM -0500, Nadav Har'El wrote: On Mon, Nov 29, 2010, Joerg Roedel wrote about [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2: Hi Avi, Hi Marcelo, here is the re-spin I promised. The change to V1 are essentially the renames

Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2

2010-12-01 Thread Nadav Har'El
On Wed, Dec 01, 2010, Roedel, Joerg wrote about Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2: Btw, another idea which came up recently was to concentrate the actuall vmexit emulation at a single point. Every code place which does the exit directly today will be changed

Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2

2010-12-01 Thread Roedel, Joerg
On Wed, Dec 01, 2010 at 06:38:30AM -0500, Nadav Har'El wrote: Can you please say a few words why you'd want to move this nested-exit request bit to x86.c? I don't want to move the actual exit-code itself into generic code. This code is different between svm and vmx. I think we could implement

Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2

2010-12-01 Thread Marcelo Tosatti
On Mon, Nov 29, 2010 at 05:51:46PM +0100, Joerg Roedel wrote: Hi Avi, Hi Marcelo, here is the re-spin I promised. The change to V1 are essentially the renames: kvm_vcpu_enter_gm - enter_guest_mode kvm_vcpu_leave_gm - leave_guest_mode kvm_vcpu_is_gm- is_guest_mode

[PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode

2010-11-29 Thread Joerg Roedel
Hi Avi, Hi Marcelo, this patch-set introduces a generic notion of guest-mode for VCPUs in KVM. This is already useful as seen in patch 3/3. Nested-VMX also has a guest-mode, so it will make sense for this code too. Regards, Joerg As usual: arch/x86/include/asm/kvm_host.h |1 +

Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode

2010-11-29 Thread Avi Kivity
On 11/29/2010 05:38 PM, Joerg Roedel wrote: Hi Avi, Hi Marcelo, this patch-set introduces a generic notion of guest-mode for VCPUs in KVM. This is already useful as seen in patch 3/3. Nested-VMX also has a guest-mode, so it will make sense for this code too. Looks good, apart from the

Re: [PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode

2010-11-29 Thread Roedel, Joerg
On Mon, Nov 29, 2010 at 11:10:59AM -0500, Avi Kivity wrote: On 11/29/2010 05:38 PM, Joerg Roedel wrote: Hi Avi, Hi Marcelo, this patch-set introduces a generic notion of guest-mode for VCPUs in KVM. This is already useful as seen in patch 3/3. Nested-VMX also has a guest-mode, so it

[PATCH 0/3] KVM: Introduce VCPU-wide notion of guest-mode V2

2010-11-29 Thread Joerg Roedel
Hi Avi, Hi Marcelo, here is the re-spin I promised. The change to V1 are essentially the renames: kvm_vcpu_enter_gm - enter_guest_mode kvm_vcpu_leave_gm - leave_guest_mode kvm_vcpu_is_gm- is_guest_mode No other changes are in this patch-set compared to V1. Regards,