Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-16 Thread Juan Quintela
Alex Williamson alex.william...@redhat.com wrote: Our code paths for saving or migrating a VM are full of functions that return void, leaving no opportunity for a device to cancel a migration, either from error or incompatibility. The ivshmem driver attempted to solve this with a no_migrate

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 07:59:57AM

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 17:07 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 22:59 +0200,

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 18:54 +0200,

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 02:23:37PM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 10:20:46AM

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 08:34:54AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 17:07 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 14:00 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 02:23:37PM

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 17:42 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 08:34:54AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 17:07 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 07:58:23AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 14:00 +0200,

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: But it could. What if ivshmem is acting in a peer role, but has no clients, could it migrate? What if ivshmem is migratable when the migration begins, but while the migration continues, a connection is setup and it

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: But it could. What if ivshmem is acting in a peer role, but has no clients, could it migrate? What if ivshmem is migratable when the migration begins, but

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Michael S. Tsirkin
On Tue, Nov 09, 2010 at 09:30:45AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: But it could. What if ivshmem is acting in a peer role, but has no clients, could it migrate?

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 18:49 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 09:30:45AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 08:47:00AM -0700, Alex Williamson wrote: But it could. What if ivshmem is

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-09 Thread Alex Williamson
On Tue, 2010-11-09 at 10:44 -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 18:49 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 09:30:45AM -0700, Alex Williamson wrote: On Tue, 2010-11-09 at 18:15 +0200, Michael S. Tsirkin wrote: On Tue, Nov 09, 2010 at 08:47:00AM -0700,

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Michael S. Tsirkin
On Wed, Oct 06, 2010 at 02:58:57PM -0600, Alex Williamson wrote: Our code paths for saving or migrating a VM are full of functions that return void, leaving no opportunity for a device to cancel a migration, either from error or incompatibility. The ivshmem driver attempted to solve this with

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 13:40 +0200, Michael S. Tsirkin wrote: On Wed, Oct 06, 2010 at 02:58:57PM -0600, Alex Williamson wrote: Our code paths for saving or migrating a VM are full of functions that return void, leaving no

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Alex Williamson
On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 13:40 +0200, Michael S. Tsirkin wrote: On Wed, Oct 06, 2010 at 02:58:57PM -0600, Alex Williamson wrote: Our code paths for saving or

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 13:40 +0200, Michael S. Tsirkin wrote: On Wed, Oct 06, 2010 at 02:58:57PM

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-11-08 Thread Alex Williamson
On Mon, 2010-11-08 at 22:59 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 10:20:46AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 18:54 +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 07:59:57AM -0700, Alex Williamson wrote: On Mon, 2010-11-08 at 13:40 +0200,

Re: [PATCH 0/6] Save state error handling (kill off no_migrate)

2010-10-07 Thread Alex Williamson
Avi, Marcelo, Assuming this gets merged to qemu.git, you'll need the attached trivial updates for the qemu-kvm.git merge. Thanks, Alex On Wed, 2010-10-06 at 14:58 -0600, Alex Williamson wrote: Our code paths for saving or migrating a VM are full of functions that return void, leaving no

[PATCH 0/6] Save state error handling (kill off no_migrate)

2010-10-06 Thread Alex Williamson
Our code paths for saving or migrating a VM are full of functions that return void, leaving no opportunity for a device to cancel a migration, either from error or incompatibility. The ivshmem driver attempted to solve this with a no_migrate flag on the save state entry. I think the more generic