Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-02 Thread Avi Kivity
On 11/01/2009 01:56 PM, Gleb Natapov wrote: Add hypercall that allows guest and host to setup per cpu shared memory. Better to set this up as an MSR (with bit zero enabling, bits 1-5 features, and 64-byte alignment). This allows auto-reset on INIT and live migration using the existing

Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-02 Thread Gleb Natapov
On Mon, Nov 02, 2009 at 02:18:54PM +0200, Avi Kivity wrote: On 11/01/2009 01:56 PM, Gleb Natapov wrote: Add hypercall that allows guest and host to setup per cpu shared memory. Better to set this up as an MSR (with bit zero enabling, bits 1-5 features, and 64-byte alignment). This allows

Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-02 Thread Avi Kivity
On 11/02/2009 06:18 PM, Gleb Natapov wrote: +#define KVM_PV_SHM_VERSION 1 versions = bad, feature bits = good I have both! Do you want me to drop version? Yes. Once a kernel is released you can't realistically change the version. Some documentation for this? Also, the

Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-02 Thread Gleb Natapov
On Tue, Nov 03, 2009 at 07:15:10AM +0200, Avi Kivity wrote: On 11/02/2009 06:18 PM, Gleb Natapov wrote: +#define KVM_PV_SHM_VERSION 1 versions = bad, feature bits = good I have both! Do you want me to drop version? Yes. Once a kernel is released you can't realistically change the

Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-02 Thread Avi Kivity
On 11/03/2009 09:16 AM, Gleb Natapov wrote: I have both! Do you want me to drop version? Yes. Once a kernel is released you can't realistically change the version. Why not? If version doesn't match apf will not be used. Then you cause a large performance regression

[PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-01 Thread Gleb Natapov
Add hypercall that allows guest and host to setup per cpu shared memory. Signed-off-by: Gleb Natapov g...@redhat.com --- arch/x86/include/asm/kvm_host.h |3 + arch/x86/include/asm/kvm_para.h | 11 + arch/x86/kernel/kvm.c | 82 +++

Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-01 Thread Rik van Riel
On 11/01/2009 06:56 AM, Gleb Natapov wrote: Add hypercall that allows guest and host to setup per cpu shared memory. While it is pretty obvious that we should implement the asynchronous pagefaults for KVM, so a swap-in of a page the host swapped out does not stall the entire virtual CPU, I

Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

2009-11-01 Thread Gleb Natapov
On Sun, Nov 01, 2009 at 11:27:15PM -0500, Rik van Riel wrote: On 11/01/2009 06:56 AM, Gleb Natapov wrote: Add hypercall that allows guest and host to setup per cpu shared memory. While it is pretty obvious that we should implement the asynchronous pagefaults for KVM, so a swap-in of a page