Re: [PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2009-01-08 Thread Sheng Yang
On Thursday 08 January 2009 05:39:32 Marcelo Tosatti wrote: > On Wed, Jan 07, 2009 at 06:42:41PM +0800, Sheng Yang wrote: > > Using kvm_set_irq to handle all interrupt injection. > > > > Signed-off-by: Sheng Yang > > --- > > include/linux/kvm_host.h |2 +- > > virt/kvm/irq_comm.c | 79

Re: [PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2009-01-07 Thread Marcelo Tosatti
On Wed, Jan 07, 2009 at 06:42:41PM +0800, Sheng Yang wrote: > Using kvm_set_irq to handle all interrupt injection. > > Signed-off-by: Sheng Yang > --- > include/linux/kvm_host.h |2 +- > virt/kvm/irq_comm.c | 79 +++-- > virt/kvm/kvm_main.c

[PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2009-01-07 Thread Sheng Yang
Using kvm_set_irq to handle all interrupt injection. Signed-off-by: Sheng Yang --- include/linux/kvm_host.h |2 +- virt/kvm/irq_comm.c | 79 +++-- virt/kvm/kvm_main.c | 79 +++--- 3 files changed, 8

Re: [PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2008-12-30 Thread Sheng Yang
On Tuesday 30 December 2008 19:07:52 Avi Kivity wrote: > Sheng Yang wrote: > >>> + mutex_lock(&kvm->gsi_msg_lock); > >> > >> The lock is already taken here? > > > > Um? For gsi_msg_lock? > > Sorry, my mistake. Will have to get used to all those locks. > > Is there a way to avoid the lock? We're s

Re: [PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2008-12-30 Thread Avi Kivity
Sheng Yang wrote: + mutex_lock(&kvm->gsi_msg_lock); The lock is already taken here? Um? For gsi_msg_lock? Sorry, my mistake. Will have to get used to all those locks. Is there a way to avoid the lock? We're starting to complicate things... This looks very messy. Wo

Re: [PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2008-12-30 Thread Sheng Yang
On Tuesday 30 December 2008 18:48:42 Avi Kivity wrote: > Sheng Yang wrote: > > Using kvm_set_irq to handle all interrupt injection. > > > > > > /* This should be called with the kvm->lock mutex held */ > > -void kvm_set_irq(struct kvm *kvm, int irq_source_id, int irq, int level) > > +void kvm_set_

Re: [PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2008-12-30 Thread Avi Kivity
Sheng Yang wrote: Using kvm_set_irq to handle all interrupt injection. /* This should be called with the kvm->lock mutex held */ -void kvm_set_irq(struct kvm *kvm, int irq_source_id, int irq, int level) +void kvm_set_irq(struct kvm *kvm, int irq_source_id, u32 gsi, int level) { - unsi

[PATCH 05/10] KVM: Merge MSI handling to kvm_set_irq

2008-12-29 Thread Sheng Yang
Using kvm_set_irq to handle all interrupt injection. Signed-off-by: Sheng Yang --- include/linux/kvm_host.h |2 +- virt/kvm/irq_comm.c | 98 +++--- virt/kvm/kvm_main.c | 77 +++- 3 files changed, 90 inserti