Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-22 Thread Tejun Heo
Hello, On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote: +/* insert @work before @pos in @worker */ Hi Tejun, Would a comment that the caller should be holding worker-lock be useful here? Anyway, comment or not: Acked-by: Andy Walls aw...@md.metrocast.net Will add

Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-22 Thread Andy Walls
On Sun, 2012-07-22 at 09:46 -0700, Tejun Heo wrote: Hello, On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote: +/* insert @work before @pos in @worker */ Hi Tejun, Would a comment that the caller should be holding worker-lock be useful here? Anyway, comment or not:

Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-21 Thread Andy Walls
On Thu, 2012-07-19 at 14:15 -0700, Tejun Heo wrote: From c9bba34243a86fb3ac82d1bdd0ce4bf796b79559 Mon Sep 17 00:00:00 2001 From: Tejun Heo t...@kernel.org Date: Thu, 19 Jul 2012 13:52:53 -0700 Make the following two non-functional changes. * Separate out insert_kthread_work() from

[PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-19 Thread Tejun Heo
From c9bba34243a86fb3ac82d1bdd0ce4bf796b79559 Mon Sep 17 00:00:00 2001 From: Tejun Heo t...@kernel.org Date: Thu, 19 Jul 2012 13:52:53 -0700 Make the following two non-functional changes. * Separate out insert_kthread_work() from queue_kthread_work(). * Relocate struct kthread_flush_work and