Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-04-30 Thread Luis R. Rodriguez
On Tue, Apr 22, 2014 at 12:41 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: Stephen, I'd like to respin this series to address all pending feedback, I'd still like your feedback / call / judgement on this part. I'm fine either way, just wanted to ensure I highlight the reasoning of why

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-04-30 Thread Vlad Yasevich
On 04/22/2014 03:41 PM, Luis R. Rodriguez wrote: On Wed, Mar 19, 2014 at 7:05 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Tue, Mar 18, 2014 at 08:10:56PM -0700, Stephen Hemminger wrote: On Wed, 12 Mar 2014 20:15:25 -0700 Luis R. Rodriguez mcg...@do-not-panic.com wrote: As it is now if

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-04-22 Thread Luis R. Rodriguez
On Wed, Mar 19, 2014 at 7:05 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Tue, Mar 18, 2014 at 08:10:56PM -0700, Stephen Hemminger wrote: On Wed, 12 Mar 2014 20:15:25 -0700 Luis R. Rodriguez mcg...@do-not-panic.com wrote: As it is now if you add create a bridge it gets started with a

Re: [Bridge] [PATCH 1/3] bridge: preserve random init MAC address

2014-03-19 Thread Toshiaki Makita
On Tue, 2014-03-18 at 18:10 -0700, Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 6:04 PM, Toshiaki Makita makita.toshi...@lab.ntt.co.jp wrote: (2014/03/19 9:50), Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita makita.toshi...@lab.ntt.co.jp wrote: nit, If

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-19 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 08:10:56PM -0700, Stephen Hemminger wrote: On Wed, 12 Mar 2014 20:15:25 -0700 Luis R. Rodriguez mcg...@do-not-panic.com wrote: As it is now if you add create a bridge it gets started with a random MAC address and if you then add a net_device as a slave but later

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Toshiaki Makita
(2014/03/13 12:15), Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com As it is now if you add create a bridge it gets started with a random MAC address and if you then add a net_device as a slave but later kick it out you end up with a zero MAC address. Instead preserve the

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita makita.toshi...@lab.ntt.co.jp wrote: nit, If the last detached port happens to have the same addr as random_init_addr, this seems to call br_stp_change_bridge_id() even though bridge_id is not changed. Ah good point. Shouldn't the assignment

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Toshiaki Makita
(2014/03/19 9:50), Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita makita.toshi...@lab.ntt.co.jp wrote: nit, If the last detached port happens to have the same addr as random_init_addr, this seems to call br_stp_change_bridge_id() even though bridge_id is not

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 6:04 PM, Toshiaki Makita makita.toshi...@lab.ntt.co.jp wrote: (2014/03/19 9:50), Luis R. Rodriguez wrote: On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita makita.toshi...@lab.ntt.co.jp wrote: nit, If the last detached port happens to have the same addr as

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Stephen Hemminger
On Wed, 12 Mar 2014 20:15:25 -0700 Luis R. Rodriguez mcg...@do-not-panic.com wrote: As it is now if you add create a bridge it gets started with a random MAC address and if you then add a net_device as a slave but later kick it out you end up with a zero MAC address. Instead preserve the

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 8:10 PM, Stephen Hemminger step...@networkplumber.org wrote: On Wed, 12 Mar 2014 20:15:25 -0700 Luis R. Rodriguez mcg...@do-not-panic.com wrote: As it is now if you add create a bridge it gets started with a random MAC address and if you then add a net_device as a

[PATCH 1/3] bridge: preserve random init MAC address

2014-03-12 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com As it is now if you add create a bridge it gets started with a random MAC address and if you then add a net_device as a slave but later kick it out you end up with a zero MAC address. Instead preserve the original random MAC address and use it. If you