Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-08-04 Thread Nadav Har'El
On Wed, Jun 16, 2010, Gleb Natapov wrote about Re: [PATCH 13/24] Implement VMREAD and VMWRITE: + set_rflags_to_vmx_fail_valid(vcpu); + vmcs_write32(VM_INSTRUCTION_ERROR, 12); VM_INSTRUCTION_ERROR is read only and when do you transfer it to vmcs12 anyway?. I think

Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-08-04 Thread Nadav Har'El
On Wed, Jun 16, 2010, Gleb Natapov wrote about Re: [PATCH 13/24] Implement VMREAD and VMWRITE: On Mon, Jun 14, 2010 at 12:36:02PM +0300, Avi Kivity wrote: vmread doesn't support 64-bit writes to memory outside long mode, so you'll have to truncate the write. I think you'll be better off

Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-08-04 Thread Nadav Har'El
On Mon, Jun 14, 2010, Avi Kivity wrote about Re: [PATCH 13/24] Implement VMREAD and VMWRITE: +#ifdef CONFIG_X86_64 +switch (vmcs_field_type(field)) { +case VMCS_FIELD_TYPE_U64: case VMCS_FIELD_TYPE_ULONG: +if (!is_long_mode(vcpu)) { +kvm_register_write

Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-08-04 Thread Avi Kivity
On 08/04/2010 07:09 PM, Nadav Har'El wrote: + kvm_read_guest_virt(gva,field_value, + vmcs_field_size(field_type, vcpu), vcpu, NULL); Check for exception. I am not sure what I should really do here... In emulating VMWRITE, we try to read from memory the

Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-06-16 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 12:36:02PM +0300, Avi Kivity wrote: On 06/13/2010 03:29 PM, Nadav Har'El wrote: Implement the VMREAD and VMWRITE instructions. With these instructions, L1 can read and write to the VMCS it is holding. The values are read or written to the fields of the shadow_vmcs

Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-06-16 Thread Gleb Natapov
On Sun, Jun 13, 2010 at 03:29:13PM +0300, Nadav Har'El wrote: Implement the VMREAD and VMWRITE instructions. With these instructions, L1 can read and write to the VMCS it is holding. The values are read or written to the fields of the shadow_vmcs structure introduced in the previous patch.

[PATCH 13/24] Implement VMREAD and VMWRITE

2010-06-13 Thread Nadav Har'El
Implement the VMREAD and VMWRITE instructions. With these instructions, L1 can read and write to the VMCS it is holding. The values are read or written to the fields of the shadow_vmcs structure introduced in the previous patch. Signed-off-by: Nadav Har'El n...@il.ibm.com --- ---