Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for exit_request on vcpu entry and timer signals arriving before KVM starts to catch them. Plug it by blocking both timer related signals also on

Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 13:47, Marcelo Tosatti wrote: On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for exit_request on vcpu entry and timer signals arriving before KVM starts to catch them. Plug it by blocking both

Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: On 2011-02-01 13:47, Marcelo Tosatti wrote: On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for exit_request on vcpu entry and timer signals

Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 14:48, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: On 2011-02-01 13:47, Marcelo Tosatti wrote: On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for

Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: On 2011-02-01 14:48, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: On 2011-02-01 13:47, Marcelo Tosatti wrote: On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: Found by Stefan

Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:10, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: On 2011-02-01 14:48, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: On 2011-02-01 13:47, Marcelo Tosatti wrote: On Thu, Jan 27, 2011 at 02:09:58PM +0100,

Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:21, Jan Kiszka wrote: On 2011-02-01 15:10, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: On 2011-02-01 14:48, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: On 2011-02-01 13:47, Marcelo Tosatti wrote:

Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:37, Jan Kiszka wrote: On 2011-02-01 15:21, Jan Kiszka wrote: On 2011-02-01 15:10, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: On 2011-02-01 14:48, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: On

[PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-01-27 Thread Jan Kiszka
Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for exit_request on vcpu entry and timer signals arriving before KVM starts to catch them. Plug it by blocking both timer related signals also on !CONFIG_IOTHREAD and process those via signalfd. Signed-off-by: Jan Kiszka