Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-11 Thread Alex Williamson
On Mon, 2010-10-11 at 17:21 +0200, Michael S. Tsirkin wrote: > On Mon, Oct 11, 2010 at 09:15:52AM -0600, Alex Williamson wrote: > > On Sat, 2010-10-09 at 23:44 +0200, Michael S. Tsirkin wrote: > > > On Fri, Oct 08, 2010 at 09:12:52AM -0600, Alex Williamson wrote: > > > > On Fri, 2010-10-08 at 10:40

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-11 Thread Michael S. Tsirkin
On Mon, Oct 11, 2010 at 09:15:52AM -0600, Alex Williamson wrote: > On Sat, 2010-10-09 at 23:44 +0200, Michael S. Tsirkin wrote: > > On Fri, Oct 08, 2010 at 09:12:52AM -0600, Alex Williamson wrote: > > > On Fri, 2010-10-08 at 10:40 +0200, Michael S. Tsirkin wrote: > > > > On Thu, Oct 07, 2010 at 10:

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-11 Thread Alex Williamson
On Sat, 2010-10-09 at 23:44 +0200, Michael S. Tsirkin wrote: > On Fri, Oct 08, 2010 at 09:12:52AM -0600, Alex Williamson wrote: > > On Fri, 2010-10-08 at 10:40 +0200, Michael S. Tsirkin wrote: > > > On Thu, Oct 07, 2010 at 10:02:25PM -0600, Alex Williamson wrote: > > > > On Fri, 2010-10-08 at 00:45

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-09 Thread Michael S. Tsirkin
On Fri, Oct 08, 2010 at 09:12:52AM -0600, Alex Williamson wrote: > On Fri, 2010-10-08 at 10:40 +0200, Michael S. Tsirkin wrote: > > On Thu, Oct 07, 2010 at 10:02:25PM -0600, Alex Williamson wrote: > > > On Fri, 2010-10-08 at 00:45 +0200, Michael S. Tsirkin wrote: > > > > On Thu, Oct 07, 2010 at 11:

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-08 Thread Alex Williamson
On Fri, 2010-10-08 at 10:40 +0200, Michael S. Tsirkin wrote: > On Thu, Oct 07, 2010 at 10:02:25PM -0600, Alex Williamson wrote: > > On Fri, 2010-10-08 at 00:45 +0200, Michael S. Tsirkin wrote: > > > On Thu, Oct 07, 2010 at 11:34:01AM -0600, Alex Williamson wrote: > > > > On Thu, 2010-10-07 at 19:18

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-08 Thread Michael S. Tsirkin
On Thu, Oct 07, 2010 at 10:02:25PM -0600, Alex Williamson wrote: > On Fri, 2010-10-08 at 00:45 +0200, Michael S. Tsirkin wrote: > > On Thu, Oct 07, 2010 at 11:34:01AM -0600, Alex Williamson wrote: > > > On Thu, 2010-10-07 at 19:18 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 04, 2010 at 03:

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-07 Thread Alex Williamson
On Fri, 2010-10-08 at 00:45 +0200, Michael S. Tsirkin wrote: > On Thu, Oct 07, 2010 at 11:34:01AM -0600, Alex Williamson wrote: > > On Thu, 2010-10-07 at 19:18 +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 04, 2010 at 03:26:30PM -0600, Alex Williamson wrote: > > > > --- a/hw/device-assignment.

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-07 Thread Michael S. Tsirkin
On Thu, Oct 07, 2010 at 11:34:01AM -0600, Alex Williamson wrote: > On Thu, 2010-10-07 at 19:18 +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 04, 2010 at 03:26:30PM -0600, Alex Williamson wrote: > > > --- a/hw/device-assignment.c > > > +++ b/hw/device-assignment.c > ... > > > @@ -1644,58 +1621,64

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-07 Thread Alex Williamson
On Thu, 2010-10-07 at 19:18 +0200, Michael S. Tsirkin wrote: > On Mon, Oct 04, 2010 at 03:26:30PM -0600, Alex Williamson wrote: > > --- a/hw/device-assignment.c > > +++ b/hw/device-assignment.c ... > > @@ -1644,58 +1621,64 @@ void add_assigned_devices(PCIBus *bus, const char > > **devices, int n_d

Re: [PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-07 Thread Michael S. Tsirkin
On Mon, Oct 04, 2010 at 03:26:30PM -0600, Alex Williamson wrote: > We don't need to duplicate PCI code for mapping and managing the > option ROM for an assigned device. We're already using an in-memory > copy of the ROM, so we can simply fill the contents from the physical > device and pass the re

[PATCH 2/2] device-assignment: Allow PCI to manage the option ROM

2010-10-04 Thread Alex Williamson
We don't need to duplicate PCI code for mapping and managing the option ROM for an assigned device. We're already using an in-memory copy of the ROM, so we can simply fill the contents from the physical device and pass the rest off to PCI. As a benefit, we can now make use of the rombar and romfi