Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info

2010-12-06 Thread Avi Kivity
On 12/06/2010 10:57 AM, Takuya Yoshikawa wrote: (2010/12/06 16:55), Takuya Yoshikawa wrote: (2010/12/06 15:37), Xiao Guangrong wrote: On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote: From: Takuya Yoshikawa Index calculation to access lpage_info appears three times. A helper is worthwhile. W

Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info

2010-12-06 Thread Takuya Yoshikawa
(2010/12/06 16:55), Takuya Yoshikawa wrote: (2010/12/06 15:37), Xiao Guangrong wrote: On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote: From: Takuya Yoshikawa Index calculation to access lpage_info appears three times. A helper is worthwhile. Why not get lpage_info instead of index in the hel

Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info

2010-12-05 Thread Takuya Yoshikawa
(2010/12/06 15:37), Xiao Guangrong wrote: On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote: From: Takuya Yoshikawa Index calculation to access lpage_info appears three times. A helper is worthwhile. Why not get lpage_info instead of index in the helper? Seems a better way! I didn't think abo

Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info

2010-12-05 Thread Xiao Guangrong
On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote: > From: Takuya Yoshikawa > > Index calculation to access lpage_info appears three times. > A helper is worthwhile. > Why not get lpage_info instead of index in the helper? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the bo

[PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info

2010-12-05 Thread Takuya Yoshikawa
From: Takuya Yoshikawa Index calculation to access lpage_info appears three times. A helper is worthwhile. Signed-off-by: Takuya Yoshikawa --- arch/x86/kvm/mmu.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c