Re: [PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-24 Thread Avi Kivity
On 01/17/2012 04:28 AM, Xiao Guangrong wrote: On 01/16/2012 05:38 PM, Avi Kivity wrote: On 01/16/2012 11:32 AM, Xiao Guangrong wrote: - trace vcpu_id for these events We can infer the vcpu id from the kvm_entry tracepoints, no? Thanks for your review, Avi! Hmm. i think it is

Re: [PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-17 Thread Marcelo Tosatti
On Tue, Jan 17, 2012 at 10:28:11AM +0800, Xiao Guangrong wrote: On 01/16/2012 05:38 PM, Avi Kivity wrote: On 01/16/2012 11:32 AM, Xiao Guangrong wrote: - trace vcpu_id for these events We can infer the vcpu id from the kvm_entry tracepoints, no? Thanks for your review, Avi!

Re: [PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-17 Thread David Ahern
On 01/17/2012 04:55 AM, Marcelo Tosatti wrote: On Tue, Jan 17, 2012 at 10:28:11AM +0800, Xiao Guangrong wrote: On 01/16/2012 05:38 PM, Avi Kivity wrote: On 01/16/2012 11:32 AM, Xiao Guangrong wrote: - trace vcpu_id for these events We can infer the vcpu id from the kvm_entry tracepoints,

Re: [PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-17 Thread Xiao Guangrong
On 01/18/2012 01:31 AM, David Ahern wrote: Relying on the existing tracepoints will make the tool work on older kernels. We can drop all new events, but unfortunately, the information of the origin tracepoints is not enough, at least vcpu_id need be traced in theses events to match its

Re: [PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-17 Thread David Ahern
On 01/17/2012 07:32 PM, Xiao Guangrong wrote: There is an ongoing 'discussion' about modifying existing tracepoints which your proposed patch violates. This is the start of it: Hmm, i think we can still add completed tracepoints in the new version kernel, if old version kernel is used, we

[PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-16 Thread Xiao Guangrong
- trace vcpu_id for these events - add kvm_mmio_done to trace the time when mmio/ioport emulation is completed Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/trace.h | 33 ++--- arch/x86/kvm/x86.c | 19

Re: [PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-16 Thread Avi Kivity
On 01/16/2012 11:32 AM, Xiao Guangrong wrote: - trace vcpu_id for these events We can infer the vcpu id from the kvm_entry tracepoints, no? - add kvm_mmio_done to trace the time when mmio/ioport emulation is completed ditto? Relying on the existing tracepoints will make the tool work on

Re: [PATCH 2/3] KVM: improve trace events of vmexit/mmio/ioport

2012-01-16 Thread Xiao Guangrong
On 01/16/2012 05:38 PM, Avi Kivity wrote: On 01/16/2012 11:32 AM, Xiao Guangrong wrote: - trace vcpu_id for these events We can infer the vcpu id from the kvm_entry tracepoints, no? Thanks for your review, Avi! Hmm. i think it is hard to do since the vcpu thread can be scheduled