Re: [PATCH 2/3] kvm: commonize allocation of the new memory slots

2014-11-16 Thread Takuya Yoshikawa
On 2014/11/14 20:12, Paolo Bonzini wrote: The two kmemdup invocations can be unified. I find that the new placement of the comment makes it easier to see what happens. A lot easier to follow the logic. Reviewed-by: Takuya Yoshikawa yoshikawa_takuya...@lab.ntt.co.jp Signed-off-by: Paolo

[PATCH 2/3] kvm: commonize allocation of the new memory slots

2014-11-14 Thread Paolo Bonzini
The two kmemdup invocations can be unified. I find that the new placement of the comment makes it easier to see what happens. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- virt/kvm/kvm_main.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git

Re: [PATCH 2/3] kvm: commonize allocation of the new memory slots

2014-11-14 Thread Igor Mammedov
On Fri, 14 Nov 2014 12:12:01 +0100 Paolo Bonzini pbonz...@redhat.com wrote: The two kmemdup invocations can be unified. I find that the new placement of the comment makes it easier to see what happens. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- virt/kvm/kvm_main.c | 28