Re: [PATCH 2/4] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()

2013-05-21 Thread Sanjay Lal
On May 21, 2013, at 1:00 AM, Gleb Natapov wrote: > On Sun, May 19, 2013 at 10:36:32AM -0400, Sanjay Lal wrote: >> >> On May 19, 2013, at 8:52 AM, Gleb Natapov wrote: >> >>> On Sat, May 18, 2013 at 06:54:24AM -0700, Sanjay Lal wrote: - As suggested by Gleb, wrap calls to gfn_to_pfn() with

Re: [PATCH 2/4] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()

2013-05-21 Thread Gleb Natapov
On Sun, May 19, 2013 at 10:36:32AM -0400, Sanjay Lal wrote: > > On May 19, 2013, at 8:52 AM, Gleb Natapov wrote: > > > On Sat, May 18, 2013 at 06:54:24AM -0700, Sanjay Lal wrote: > >> - As suggested by Gleb, wrap calls to gfn_to_pfn() with > >> srcu_read_lock/unlock(). > >> Memory slots should

Re: [PATCH 2/4] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()

2013-05-19 Thread Sanjay Lal
On May 19, 2013, at 8:52 AM, Gleb Natapov wrote: > On Sat, May 18, 2013 at 06:54:24AM -0700, Sanjay Lal wrote: >> - As suggested by Gleb, wrap calls to gfn_to_pfn() with >> srcu_read_lock/unlock(). >> Memory slots should be acccessed from a SRCU read section. >> - kvm_mips_map_page() now return

Re: [PATCH 2/4] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()

2013-05-19 Thread Gleb Natapov
On Sat, May 18, 2013 at 06:54:24AM -0700, Sanjay Lal wrote: > - As suggested by Gleb, wrap calls to gfn_to_pfn() with > srcu_read_lock/unlock(). > Memory slots should be acccessed from a SRCU read section. > - kvm_mips_map_page() now returns an error code to it's callers, instead of > calling p

[PATCH 2/4] KVM/MIPS32: Wrap calls to gfn_to_pfn() with srcu_read_lock/unlock()

2013-05-18 Thread Sanjay Lal
- As suggested by Gleb, wrap calls to gfn_to_pfn() with srcu_read_lock/unlock(). Memory slots should be acccessed from a SRCU read section. - kvm_mips_map_page() now returns an error code to it's callers, instead of calling panic() if it cannot find a mapping for a particular gfn. Signed-off-b