Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-24 Thread Gleb Natapov
On Wed, Apr 17, 2013 at 02:16:59PM +0200, Alexander Graf wrote: On 17.04.2013, at 14:15, Paolo Bonzini wrote: Il 17/04/2013 14:10, Alexander Graf ha scritto: Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC; defining one without the other makes no sense and will

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Paolo Bonzini
Il 16/04/2013 19:26, Alexander Graf ha scritto: Quite a bit of code in KVM has been conditionalized on availability of IOAPIC emulation. However, most of it is generically applicable to platforms that don't have an IOPIC, but a different type of irq chip. Introduce a new define to

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 13:49, Paolo Bonzini wrote: Il 16/04/2013 19:26, Alexander Graf ha scritto: Quite a bit of code in KVM has been conditionalized on availability of IOAPIC emulation. However, most of it is generically applicable to platforms that don't have an IOPIC, but a different type of

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 13:53, Alexander Graf ha scritto: arch/x86/include/uapi/asm/kvm.h |1 + include/linux/kvm_host.h|4 ++-- include/uapi/linux/kvm.h|2 +- virt/kvm/eventfd.c |6 +++--- 4 files changed, 7 insertions(+), 6 deletions(-) You need to

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 13:54, Paolo Bonzini wrote: Il 17/04/2013 13:53, Alexander Graf ha scritto: arch/x86/include/uapi/asm/kvm.h |1 + include/linux/kvm_host.h|4 ++-- include/uapi/linux/kvm.h|2 +- virt/kvm/eventfd.c |6 +++--- 4 files changed, 7

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 13:59, Alexander Graf ha scritto: Well, we just got a patch to make it at least compile, That was really just Yang (blindly?) fixing an issue I pointed out on ARM. There is no kvm user space support for IA64. The kernel side has been KConfig depending on BROKEN for a year

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 14:06, Paolo Bonzini wrote: Il 17/04/2013 13:59, Alexander Graf ha scritto: Well, we just got a patch to make it at least compile, That was really just Yang (blindly?) fixing an issue I pointed out on ARM. There is no kvm user space support for IA64. The kernel side has

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 14:10, Alexander Graf ha scritto: Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC; defining one without the other makes no sense and will cause compilation or link errors for trace_kvm_ack_irq. Either we drop it altogether, or we should not break compilation

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 14:15, Paolo Bonzini wrote: Il 17/04/2013 14:10, Alexander Graf ha scritto: Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC; defining one without the other makes no sense and will cause compilation or link errors for trace_kvm_ack_irq. Either we drop

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Paolo Bonzini
Il 16/04/2013 19:26, Alexander Graf ha scritto: Quite a bit of code in KVM has been conditionalized on availability of IOAPIC emulation. However, most of it is generically applicable to platforms that don't have an IOPIC, but a different type of irq chip. Introduce a new define to

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 13:49, Paolo Bonzini wrote: Il 16/04/2013 19:26, Alexander Graf ha scritto: Quite a bit of code in KVM has been conditionalized on availability of IOAPIC emulation. However, most of it is generically applicable to platforms that don't have an IOPIC, but a different type of

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 13:54, Paolo Bonzini wrote: Il 17/04/2013 13:53, Alexander Graf ha scritto: arch/x86/include/uapi/asm/kvm.h |1 + include/linux/kvm_host.h|4 ++-- include/uapi/linux/kvm.h|2 +- virt/kvm/eventfd.c |6 +++--- 4 files changed, 7

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 13:59, Alexander Graf ha scritto: Well, we just got a patch to make it at least compile, That was really just Yang (blindly?) fixing an issue I pointed out on ARM. There is no kvm user space support for IA64. The kernel side has been KConfig depending on BROKEN for a year

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 14:06, Paolo Bonzini wrote: Il 17/04/2013 13:59, Alexander Graf ha scritto: Well, we just got a patch to make it at least compile, That was really just Yang (blindly?) fixing an issue I pointed out on ARM. There is no kvm user space support for IA64. The kernel side has

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 14:10, Alexander Graf ha scritto: Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC; defining one without the other makes no sense and will cause compilation or link errors for trace_kvm_ack_irq. Either we drop it altogether, or we should not break compilation

Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-17 Thread Alexander Graf
On 17.04.2013, at 14:15, Paolo Bonzini wrote: Il 17/04/2013 14:10, Alexander Graf ha scritto: Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC; defining one without the other makes no sense and will cause compilation or link errors for trace_kvm_ack_irq. Either we drop

[PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-16 Thread Alexander Graf
Quite a bit of code in KVM has been conditionalized on availability of IOAPIC emulation. However, most of it is generically applicable to platforms that don't have an IOPIC, but a different type of irq chip. Introduce a new define to distinguish between generic code and IOAPIC specific code.

[PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

2013-04-16 Thread Alexander Graf
Quite a bit of code in KVM has been conditionalized on availability of IOAPIC emulation. However, most of it is generically applicable to platforms that don't have an IOPIC, but a different type of irq chip. Introduce a new define to distinguish between generic code and IOAPIC specific code.