Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-03-13 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 04:11:17PM +0800, Jason Wang wrote: We can use lock_sock_fast() instead of lock_sock() in order to get speedup in peek_head_len(). Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-03-13 Thread Eric Dumazet
Le dimanche 13 mars 2011 à 17:06 +0200, Michael S. Tsirkin a écrit : On Mon, Jan 17, 2011 at 04:11:17PM +0800, Jason Wang wrote: We can use lock_sock_fast() instead of lock_sock() in order to get speedup in peek_head_len(). Signed-off-by: Jason Wang jasow...@redhat.com ---

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-03-13 Thread Michael S. Tsirkin
On Sun, Mar 13, 2011 at 04:52:50PM +0100, Eric Dumazet wrote: Le dimanche 13 mars 2011 à 17:06 +0200, Michael S. Tsirkin a écrit : On Mon, Jan 17, 2011 at 04:11:17PM +0800, Jason Wang wrote: We can use lock_sock_fast() instead of lock_sock() in order to get speedup in peek_head_len().

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-03-13 Thread Eric Dumazet
Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit : Other side is in drivers/net/tun.c and net/packet/af_packet.c At least wrt tun it seems clear socket is not locked. Yes (assuming you refer to tun_net_xmit()) Besides queue, dequeue seems to be done without socket locked.

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-03-13 Thread Michael S. Tsirkin
On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote: Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit : Other side is in drivers/net/tun.c and net/packet/af_packet.c At least wrt tun it seems clear socket is not locked. Yes (assuming you refer to

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-03-13 Thread Eric Dumazet
Le dimanche 13 mars 2011 à 18:43 +0200, Michael S. Tsirkin a écrit : On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote: Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit : Other side is in drivers/net/tun.c and net/packet/af_packet.c At least wrt tun it

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-03-13 Thread Michael S. Tsirkin
On Sun, Mar 13, 2011 at 06:41:32PM +0100, Eric Dumazet wrote: Le dimanche 13 mars 2011 à 18:43 +0200, Michael S. Tsirkin a écrit : On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote: Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit : Other side is in

[PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-01-17 Thread Jason Wang
We can use lock_sock_fast() instead of lock_sock() in order to get speedup in peek_head_len(). Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-01-17 Thread Eric Dumazet
Le lundi 17 janvier 2011 à 16:11 +0800, Jason Wang a écrit : We can use lock_sock_fast() instead of lock_sock() in order to get speedup in peek_head_len(). Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 04:11:17PM +0800, Jason Wang wrote: We can use lock_sock_fast() instead of lock_sock() in order to get speedup in peek_head_len(). Signed-off-by: Jason Wang jasow...@redhat.com Queued for 2.6.39, thanks everyone. --- drivers/vhost/net.c |4 ++-- 1 files