Re: [PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-21 Thread Avi Kivity
Subject: Re: [PATCH 4/4] Enabling Access bit when doing memory swapping On Wed, May 16, 2012 at 09:12:30AM +0800, Xudong Hao wrote: Enabling Access bit when doing memory swapping. Signed-off-by: Haitao Shan haitao.s...@intel.com Signed-off-by: Xudong Hao xudong@intel.com

RE: [PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-21 Thread Hao, Xudong
, Xiantao; Hao, Xudong Subject: Re: [PATCH 4/4] Enabling Access bit when doing memory swapping On Wed, May 16, 2012 at 09:12:30AM +0800, Xudong Hao wrote: Enabling Access bit when doing memory swapping. Signed-off-by: Haitao Shan haitao.s...@intel.com Signed-off-by: Xudong Hao

Re: [PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-21 Thread Avi Kivity
On 05/21/2012 01:35 PM, Hao, Xudong wrote: That doesn't answer the question. An atomic operation is now non-atomic. You can calculate shadow_accessed_bit and keep on using clear_bit(), or switch to cmpxchg64(), but don't just drop the dirty bit here. I know your meaning. How

RE: [PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-21 Thread Hao, Xudong
-Original Message- From: Avi Kivity [mailto:a...@redhat.com] Sent: Monday, May 21, 2012 6:48 PM To: Hao, Xudong Cc: Marcelo Tosatti; Xudong Hao; kvm@vger.kernel.org; linux-ker...@vger.kernel.org; Shan, Haitao; Zhang, Xiantao Subject: Re: [PATCH 4/4] Enabling Access bit when doing

Re: [PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-21 Thread Avi Kivity
: Re: [PATCH 4/4] Enabling Access bit when doing memory swapping On 05/21/2012 01:35 PM, Hao, Xudong wrote: That doesn't answer the question. An atomic operation is now non-atomic. You can calculate shadow_accessed_bit and keep on using clear_bit(), or switch to cmpxchg64

RE: [PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-20 Thread Hao, Xudong
-Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Friday, May 18, 2012 10:23 AM To: Xudong Hao Cc: a...@redhat.com; kvm@vger.kernel.org; linux-ker...@vger.kernel.org; Shan, Haitao; Zhang, Xiantao; Hao, Xudong Subject: Re: [PATCH 4/4] Enabling Access bit

Re: [PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-17 Thread Marcelo Tosatti
On Wed, May 16, 2012 at 09:12:30AM +0800, Xudong Hao wrote: Enabling Access bit when doing memory swapping. Signed-off-by: Haitao Shan haitao.s...@intel.com Signed-off-by: Xudong Hao xudong@intel.com --- arch/x86/kvm/mmu.c | 13 +++-- arch/x86/kvm/vmx.c |6 -- 2

[PATCH 4/4] Enabling Access bit when doing memory swapping

2012-05-15 Thread Xudong Hao
Enabling Access bit when doing memory swapping. Signed-off-by: Haitao Shan haitao.s...@intel.com Signed-off-by: Xudong Hao xudong@intel.com --- arch/x86/kvm/mmu.c | 13 +++-- arch/x86/kvm/vmx.c |6 -- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git